ff8375879e
This seems to be an empty class meant to be removed at some point. Today, this is only a class supporting `SupportsUserData`. I observed every content/ embedder was required to provide one, and none of them was really providing some kind of customization. This patch merge all the different embedders implementations into the content/ implementation. This has the side effect of helping linnan@chromium.org to remove a dangling pointer. This is an alternative to her patch from: https://chromium-review.googlesource.com/c/chromium/src/+/5132493 Bug: chromium:1471070, chromium:908955 Change-Id: I4938957822d0a77be642aef3098faaa87616295f Fixed: 1471070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5139789 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Owners-Override: John Abd-El-Malek <jam@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1240500}
fuchsia.web - Fuchsia WebEngine and Runners
This directory contains code related to the
fuchsia.web FIDL API.
Specifically, it contains the implementation of Fuchsia WebEngine and code
related to it, including the Runners that use it. Code in this
directory must not be used outside it and its subdirectories.
General information about Chromium on Fuchsia is here.
[TOC]
Code organization
Each of the following subdirectories contain code for a specific Fuchsia service:
./commoncontains code shared by both WebEngine and Runners../runnerscontains implementations of Fuchsiasys.runner../runners/castEnables the Fuchsia system to launch Cast applications.
./shellcontains WebEngineShell, a simple wrapper for launching URLs in WebEngine from the command line../webenginecontains the WebEngine implementation. WebEngine is an implementation offuchsia.webthat enables Fuchsia Components to render web content using Chrome's Content layer../webinstance_hostcontains code for WebEngine clients to directly instantiate a WebInstance Component (web_instance.cm) using the WebEngine package.
Test code
There are 3 major types of tests within this directory:
- Unit tests: Exercise a single class in isolation, allowing full control over the external environment of this class.
- Browser tests: Spawn a full browser process and its child processes. The test code is run inside the browser process, allowing for full access to the browser code - but not other processes.
- Integration tests: Exercise the published FIDL API of a Fuchsia Component. For
instance,
//fuchsia_web/webengine:web_engine_integration_testsmake use of the//fuchsia_web/webengine:web_enginecomponent. The test code runs in a separate process in a separate Fuchsia Component, allowing only access to the published API of the component under test.
Integration tests are more resource-intensive than browser tests, which are in turn more expensive than unit tests. Therefore, when writing new tests, it is preferred to write unit tests over browser tests over integration tests.
As a general rule, test-only code should live in the same directory as the code
under test with an explicit file name, either fake_*, test_*,
*_unittest.cc, *_ browsertest.cc or *_integration_test.cc.
Test code that is shared across Components should live in a dedicated ``test
directory. For example, the //fuchsia_web/webengine/test directory, which
contains code shared by all browser tests, and
//fuchsia_web/common/test, which contains code shared by tests for both
WebEngine and Runners.