
There are two headers to declare features in content. - the public one: `content/public/common/content_features.h` - the private one: `content/common/features.h`. Unfortunately, most are declared in the public one, despite being used privately exclusively. This violate the `content/public/` rules. This patches provides a fix. Parts of this patch was made programmatically using this script: https://paste.googleplex.com/6699322946093056, with the following output: https://paste.googleplex.com/5591288895242240 This patch: 1. Update `docs/how_to_add_your_feature_flag.md` to incentive developers to the non public versions. 2. Move ~70 features back into the private version. 3. Programmatically update the includes to include the correct #include header(s). 4. For consistency and minimizing the amount of files modified, the two headers to use the `features::` namespace. AX-Relnotes: n/a. Change-Id: Id9126a95dfbc533d4778b188b659b5acc9b3d9e3 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4836057 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194718}
50 lines
1.7 KiB
C++
50 lines
1.7 KiB
C++
// Copyright 2019 The Chromium Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "content/app/mojo_ipc_support.h"
|
|
|
|
#include <utility>
|
|
|
|
#include "base/command_line.h"
|
|
#include "base/task/single_thread_task_runner.h"
|
|
#include "build/build_config.h"
|
|
#include "content/browser/browser_process_io_thread.h"
|
|
#include "content/browser/startup_data_impl.h"
|
|
#include "content/common/features.h"
|
|
#include "content/common/mojo_core_library_support.h"
|
|
#include "mojo/core/embedder/embedder.h"
|
|
#include "mojo/core/embedder/scoped_ipc_support.h"
|
|
|
|
namespace content {
|
|
|
|
MojoIpcSupport::MojoIpcSupport(
|
|
std::unique_ptr<BrowserProcessIOThread> io_thread)
|
|
: io_thread_(std::move(io_thread)) {
|
|
scoped_refptr<base::SingleThreadTaskRunner> mojo_ipc_task_runner =
|
|
io_thread_->task_runner();
|
|
if (!IsMojoCoreSharedLibraryEnabled()) {
|
|
// NOTE: If Mojo Core was loaded via shared library, IPC support is already
|
|
// initialized.
|
|
if (base::FeatureList::IsEnabled(features::kMojoDedicatedThread)) {
|
|
mojo_ipc_thread_.StartWithOptions(
|
|
base::Thread::Options(base::MessagePumpType::IO, 0));
|
|
mojo_ipc_task_runner = mojo_ipc_thread_.task_runner();
|
|
}
|
|
mojo_ipc_support_ = std::make_unique<mojo::core::ScopedIPCSupport>(
|
|
mojo_ipc_task_runner,
|
|
mojo::core::ScopedIPCSupport::ShutdownPolicy::FAST);
|
|
}
|
|
}
|
|
|
|
MojoIpcSupport::~MojoIpcSupport() = default;
|
|
|
|
std::unique_ptr<StartupDataImpl> MojoIpcSupport::CreateBrowserStartupData() {
|
|
auto startup_data = std::make_unique<StartupDataImpl>();
|
|
startup_data->io_thread = std::move(io_thread_);
|
|
startup_data->mojo_ipc_support = std::move(mojo_ipc_support_);
|
|
return startup_data;
|
|
}
|
|
|
|
} // namespace content
|