chromium/src
0
Fork 0
Code Activity
Files
c00a82207919bc98340dc417e76b083a9c20e1a1
src/cc/tiles
History
Arthur Sonzogni 91423838c1 C++11 std::array rewrite for memory safety [12/19] 
Split from:
https://chromium-review.googlesource.com/c/chromium/src/+/6004959/21

Generated patch
---------------
- Tool: ./tool/clang/spanify/rewrite-multiple-platform.sh
- Platform: Linux.
- Filter: This includes 2400/4222 patches. I included the std::array
      ones and excluded build errors.

Google announcement:
--------------------
https://groups.google.com/a/google.com/g/chrome-memory-safety/c/RMiO4gaVLQA/m/Yz-3NCObAgAJ

Benchmarks:
----------
See design doc and
https://chromium-review.googlesource.com/c/chromium/src/+/6004959/21

Description
-----------
The consensus during the memory safety summit was to begin rewriting
relevant C-style arrays to C++11 std::array. It can be done immediately,
offers better developer ergonomics, and fix large chunks of the
-Wunsafe-buffer-usage errors in Chrome.

To clarify, this effort is complementary to the longer plan work with
enabling -fsanitize=array-bounds, and we plan to leverage both,
especially for protecting 3p code.

[Attached] is a document detailing the rationale, benefits, and
considerations for potential compile-time and performance impacts.

[Attached]:https://docs.google.com/document/d/1z5aBDg26lHmNDjXRCysElWKx7E4PAJXqykI_k7ondJI/edit?tab=t.0#heading=h.cqgo7wvp0kzt

NO_IFTTT=No need to update base/debug/stack_trace.h

Bug: 378069401
Change-Id: I9a0271e4b45a2be44dfbb30e95d267745765b5fa
R: dcheng@chromium.org
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6044118
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395060}
2024-12-11 13:06:30 -08:00
..
checker_image_tracker_unittest.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
checker_image_tracker.cc
Migrate to NOTREACHED() in cc/
2024-09-24 18:04:39 +00:00
checker_image_tracker.h
…
decoded_image_tracker_unittest.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
decoded_image_tracker.cc
…
decoded_image_tracker.h
…
eviction_tile_priority_queue.cc
…
eviction_tile_priority_queue.h
…
frame_viewer_instrumentation.cc
…
frame_viewer_instrumentation.h
…
gpu_image_decode_cache_perftest.cc
Use moved Skia Ganesh headers
2024-09-04 01:32:55 +00:00
gpu_image_decode_cache_unittest.cc
Remove usage of base::make_span(): cc/
2024-11-28 19:37:04 +00:00
gpu_image_decode_cache.cc
Remove usage of base::make_span(): cc/
2024-11-28 19:37:04 +00:00
gpu_image_decode_cache.h
Fix image decode cache unsafe buffer usage
2024-11-11 15:23:19 +00:00
image_controller_unittest.cc
Disable feature PreventDuplicateImageDecodes
2024-10-31 04:55:56 +00:00
image_controller.cc
SpeculativeImageDecodes: gracefully handle un-decode-able images
2024-11-21 22:18:18 +00:00
image_controller.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
image_decode_cache_utils.cc
Revert MiracleParameter code for DecodedImageWorkingSetBudget
2024-11-07 02:21:15 +00:00
image_decode_cache_utils.h
…
image_decode_cache.cc
…
image_decode_cache.h
Migrate to NOTREACHED() in cc/
2024-09-24 18:04:39 +00:00
mipmap_util_unittest.cc
C++11 std::array rewrite for memory safety [12/19]
2024-12-11 13:06:30 -08:00
mipmap_util.cc
…
mipmap_util.h
…
picture_layer_tiling_set_unittest.cc
Revert previously deleted underscores
2024-12-03 00:19:42 +00:00
picture_layer_tiling_set.cc
[cc-slimming] Audit and fortify logic around all_tiles_done flags.
2024-09-12 20:52:29 +00:00
picture_layer_tiling_set.h
…
picture_layer_tiling_unittest.cc
[cc-slimming] Fix a bug in Web UI that invalidated region are missed.
2024-10-18 22:02:27 +00:00
picture_layer_tiling.cc
Fix more cc unsafe buffer usage
2024-11-26 22:19:23 +00:00
picture_layer_tiling.h
[cc-slimming] Audit and fortify logic around all_tiles_done flags.
2024-09-12 20:52:29 +00:00
prioritized_tile.cc
…
prioritized_tile.h
…
raster_dark_mode_filter.h
…
raster_tile_priority_queue_all.cc
…
raster_tile_priority_queue_all.h
…
raster_tile_priority_queue_required.cc
…
raster_tile_priority_queue_required.h
…
raster_tile_priority_queue.cc
Migrate to NOTREACHED() in cc/
2024-09-24 18:04:39 +00:00
raster_tile_priority_queue.h
…
software_image_decode_cache_perftest.cc
…
software_image_decode_cache_unittest_combinations.cc
…
software_image_decode_cache_unittest.cc
Revert previously deleted underscores
2024-12-03 00:19:42 +00:00
software_image_decode_cache_utils.cc
…
software_image_decode_cache_utils.h
…
software_image_decode_cache.cc
Revert MiracleParameter code from software_image_decode_cache.cc
2024-11-07 04:42:16 +00:00
software_image_decode_cache.h
Cleanup: combine redundant TaskType enums and fields
2024-09-06 17:14:06 +00:00
tile_draw_info.cc
…
tile_draw_info.h
Migrate to NOTREACHED() in cc/
2024-09-24 18:04:39 +00:00
tile_index.h
…
tile_manager_perftest.cc
C++11 std::array rewrite for memory safety [12/19]
2024-12-11 13:06:30 -08:00
tile_manager_settings.h
…
tile_manager_unittest.cc
C++11 std::array rewrite for memory safety [12/19]
2024-12-11 13:06:30 -08:00
tile_manager.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
tile_manager.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
tile_priority_unittest.cc
…
tile_priority.cc
…
tile_priority.h
…
tile_task_manager.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
tile_task_manager.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
tile.cc
…
tile.h
…
tiles_with_resource_iterator.cc
…
tiles_with_resource_iterator.h
…
tiling_coverage_iterator.h
…
tiling_internal.h
…
tiling_set_coverage_iterator.h
…
tiling_set_eviction_queue.cc
Migrate to NOTREACHED() in cc/
2024-09-24 18:04:39 +00:00
tiling_set_eviction_queue.h
…
tiling_set_raster_queue_all.cc
Fix more cc unsafe buffer usage
2024-11-26 22:19:23 +00:00
tiling_set_raster_queue_all.h
Fix more cc unsafe buffer usage
2024-11-26 22:19:23 +00:00
tiling_set_raster_queue_required.cc
…
tiling_set_raster_queue_required.h
…