
This CL replaces various custom clamping code with the standardized FCLAMP. Important note: this CL standardizes replacing NaNs with zeros, rather than -1.0 or +1.0, depending on the code path. This is a behavioral change, but it's better to replace NaNs with silence than with "the loudest possible value". Optimized FCLAMP code will be added per-architecture in upcoming CLs. Bug: 401598584 Change-Id: Id3c994bd574bf551652e70218496652f4b8508f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336773 Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#1430578}
Cast base
cast_features
This file contains tools for checking the feature state of all of the features which affect Cast products. Cast features build upon the Chrome feature system. Some aspects of Cast require the feature system to work differently, however, so some additional logic has been layered on top. Details are available in comments of the header file. The basics are:
- If you are adding a new feature, add it to
cast_features.cc
so it lives alongside existing features - Add your new feature to the list of
kFeatures
incast_features.cc
BASE_FEATURE(kMyFeature, "my_feature", base::FEATURE_DISABLED_BY_DEFAULT);
const base::Feature* kFeatures[] = {
// ..other features
&kMyFeature
}