
- Rename KeySystemSupportObserver to KeySystemSupportRegistration - Remove unnecessary virtual function - Add clarifying comments. TESTED: * Add logs to see the size observer remote set in browser process. (after this line https://source.chromium.org/chromium/chromium/src/+/main:content/browser/media/key_system_support_impl.cc;drc=eb3c1d87f1c717de44fdaadb8b83041584f6a6b3;l=59) The following is observed only when moving key systems to a per-frame model. See https://chromium-review.googlesource.com/c/chromium/src/+/5168850 * Visit integration.widevine.com/player * Click play observer logs (observer_remotes_.size() = 1) * Visit another site (e.g. shaka-player-demo.appspot.com) and play encrypted media * Check logs find (observer_remotes_.size() = 2) * Close integration.widevine.com/player tab and ensure render process for that tab is destroyed (e.g. in Task Manager) * Visit integration.staging.widevine.com/player and click play * Observer logs and find (observer_remotes_.size() = 2) whereas before https://chromium-review.googlesource.com/c/chromium/src/+/5168850 the logs would say (observer_remotes_.size() = 3) Bug: b/321307544 Change-Id: I78133a594c0fcf96326ce25aa42fbe754491bc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381159 Commit-Queue: Feras Aldahlawi <feras@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Zijie He <zijiehe@google.com> Reviewed-by: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/main@{#1275988}
Cast base
cast_features
This file contains tools for checking the feature state of all of the features which affect Cast products. Cast features build upon the Chrome feature system. Some aspects of Cast require the feature system to work differently, however, so some additional logic has been layered on top. Details are available in comments of the header file. The basics are:
- If you are adding a new feature, add it to
cast_features.cc
so it lives alongside existing features - Add your new feature to the list of
kFeatures
incast_features.cc
BASE_FEATURE(kMyFeature, "my_feature", base::FEATURE_DISABLED_BY_DEFAULT);
const base::Feature* kFeatures[] = {
// ..other features
&kMyFeature
}