
Before this CL, CDP events for prefetch are emitted from Prefetcher, which implements SpeculationHostDevToolsObserver. Prefetch ahead of prerender is managed by PrerendererImpl and some CDP events in Network domain are not emitted. This CL removes SpeculationHostDevToolsObserver and makes PrefetchContainer directly emit. Note that - CDP events are emitted only if the prefetch was triggered by Spec Rules. - CDP events are emitted only if the initiator document is alive. By this removal, CDP events of Network domain are emitted for prefetch ahead of prerender. No behavioral changes if kPrerender2FallbackPrefetchSpecRules disabled. Fixed: 342537094, 348139748 Change-Id: Ica11ce4ea62b4044d2503934ffd283b623ccdf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632873 Commit-Queue: Ken Okada <kenoss@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Danil Somsikov <dsv@chromium.org> Reviewed-by: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390718}
173 lines
6.0 KiB
C++
173 lines
6.0 KiB
C++
// Copyright 2022 The Chromium Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "content/browser/preloading/prefetcher.h"
|
|
|
|
#include <vector>
|
|
|
|
#include "base/test/scoped_feature_list.h"
|
|
#include "content/browser/preloading/prefetch/prefetch_document_manager.h"
|
|
#include "content/browser/preloading/prefetch/prefetch_features.h"
|
|
#include "content/browser/preloading/prefetch/prefetch_service.h"
|
|
#include "content/public/browser/speculation_host_delegate.h"
|
|
#include "content/public/common/content_client.h"
|
|
#include "content/public/test/test_browser_context.h"
|
|
#include "content/public/test/test_renderer_host.h"
|
|
#include "content/test/test_content_browser_client.h"
|
|
#include "content/test/test_web_contents.h"
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace content {
|
|
namespace {
|
|
|
|
class MockSpeculationHostDelegate : public SpeculationHostDelegate {
|
|
public:
|
|
explicit MockSpeculationHostDelegate(RenderFrameHost& render_frame_host) {}
|
|
~MockSpeculationHostDelegate() override = default;
|
|
|
|
void ProcessCandidates(
|
|
std::vector<blink::mojom::SpeculationCandidatePtr>& candidates) override {
|
|
for (auto&& candidate : candidates) {
|
|
candidates_.push_back(std::move(candidate));
|
|
}
|
|
}
|
|
std::vector<blink::mojom::SpeculationCandidatePtr>& Candidates() {
|
|
return candidates_;
|
|
}
|
|
|
|
base::WeakPtr<MockSpeculationHostDelegate> AsWeakPtr() {
|
|
return weak_ptr_factory_.GetWeakPtr();
|
|
}
|
|
|
|
private:
|
|
std::vector<blink::mojom::SpeculationCandidatePtr> candidates_;
|
|
base::WeakPtrFactory<MockSpeculationHostDelegate> weak_ptr_factory_{this};
|
|
};
|
|
|
|
class TestPrefetchService : public PrefetchService {
|
|
public:
|
|
explicit TestPrefetchService(BrowserContext* browser_context)
|
|
: PrefetchService(browser_context) {}
|
|
|
|
void PrefetchUrl(
|
|
base::WeakPtr<PrefetchContainer> prefetch_container) override {
|
|
prefetch_container->DisablePrecogLoggingForTest();
|
|
prefetches_.push_back(prefetch_container);
|
|
|
|
std::unique_ptr<network::ResourceRequest> request =
|
|
std::make_unique<network::ResourceRequest>();
|
|
network::ResourceRequest::TrustedParams trusted_params;
|
|
request->trusted_params = trusted_params;
|
|
}
|
|
|
|
std::vector<base::WeakPtr<PrefetchContainer>> prefetches_;
|
|
};
|
|
|
|
class MockContentBrowserClient : public TestContentBrowserClient {
|
|
public:
|
|
MockContentBrowserClient() {
|
|
old_browser_client_ = SetBrowserClientForTesting(this);
|
|
}
|
|
~MockContentBrowserClient() override {
|
|
EXPECT_EQ(this, SetBrowserClientForTesting(old_browser_client_));
|
|
}
|
|
|
|
std::unique_ptr<SpeculationHostDelegate> CreateSpeculationHostDelegate(
|
|
RenderFrameHost& render_frame_host) override {
|
|
auto delegate =
|
|
std::make_unique<MockSpeculationHostDelegate>(render_frame_host);
|
|
delegate_ = delegate->AsWeakPtr();
|
|
return delegate;
|
|
}
|
|
|
|
base::WeakPtr<MockSpeculationHostDelegate> GetDelegate() { return delegate_; }
|
|
|
|
private:
|
|
raw_ptr<ContentBrowserClient> old_browser_client_ = nullptr;
|
|
base::WeakPtr<MockSpeculationHostDelegate> delegate_;
|
|
};
|
|
|
|
class PrefetcherTest : public RenderViewHostTestHarness {
|
|
public:
|
|
PrefetcherTest() = default;
|
|
void SetUp() override {
|
|
RenderViewHostTestHarness::SetUp();
|
|
|
|
browser_context_ = std::make_unique<TestBrowserContext>();
|
|
web_contents_ = TestWebContents::Create(
|
|
browser_context_.get(),
|
|
SiteInstanceImpl::Create(browser_context_.get()));
|
|
web_contents_->NavigateAndCommit(GetSameOriginUrl("/"));
|
|
prefetch_service_ =
|
|
std::make_unique<TestPrefetchService>(GetBrowserContext());
|
|
PrefetchDocumentManager::SetPrefetchServiceForTesting(
|
|
prefetch_service_.get());
|
|
}
|
|
void TearDown() override {
|
|
// The PrefetchService we created for the test contains a
|
|
// PrefetchOriginProber, which holds a raw pointer to the BrowserContext.
|
|
// When tearing down, it's important to free our PrefetchService
|
|
// before freeing the BrowserContext, to avoid any chance of a use after
|
|
// free.
|
|
PrefetchDocumentManager::SetPrefetchServiceForTesting(nullptr);
|
|
prefetch_service_.reset();
|
|
|
|
web_contents_.reset();
|
|
browser_context_.reset();
|
|
RenderViewHostTestHarness::TearDown();
|
|
}
|
|
|
|
RenderFrameHostImpl& GetPrimaryMainFrame() {
|
|
return web_contents_->GetPrimaryPage().GetMainDocument();
|
|
}
|
|
|
|
GURL GetSameOriginUrl(const std::string& path) {
|
|
return GURL("https://example.com" + path);
|
|
}
|
|
|
|
GURL GetCrossOriginUrl(const std::string& path) {
|
|
return GURL("https://other.example.com" + path);
|
|
}
|
|
|
|
TestPrefetchService* GetPrefetchService() { return prefetch_service_.get(); }
|
|
|
|
private:
|
|
std::unique_ptr<TestBrowserContext> browser_context_;
|
|
std::unique_ptr<TestWebContents> web_contents_;
|
|
std::unique_ptr<TestPrefetchService> prefetch_service_;
|
|
};
|
|
|
|
TEST_F(PrefetcherTest, ProcessCandidatesForPrefetch) {
|
|
MockContentBrowserClient browser_client;
|
|
auto prefetcher = Prefetcher(GetPrimaryMainFrame());
|
|
base::WeakPtr<MockSpeculationHostDelegate> delegate =
|
|
browser_client.GetDelegate();
|
|
ASSERT_TRUE(delegate);
|
|
|
|
// Create list of SpeculationCandidatePtrs.
|
|
std::vector<blink::mojom::SpeculationCandidatePtr> candidates;
|
|
|
|
auto candidate1 = blink::mojom::SpeculationCandidate::New();
|
|
candidate1->action = blink::mojom::SpeculationAction::kPrefetch;
|
|
candidate1->requires_anonymous_client_ip_when_cross_origin = true;
|
|
candidate1->url = GetCrossOriginUrl("/candidate1.html");
|
|
candidate1->referrer = blink::mojom::Referrer::New();
|
|
candidates.push_back(std::move(candidate1));
|
|
|
|
prefetcher.ProcessCandidatesForPrefetch(candidates);
|
|
EXPECT_TRUE(delegate->Candidates().empty());
|
|
EXPECT_EQ(1u, GetPrefetchService()->prefetches_.size());
|
|
|
|
EXPECT_FALSE(prefetcher.IsPrefetchAttemptFailedOrDiscarded(
|
|
GetCrossOriginUrl("/candidate1.html")));
|
|
GetPrefetchService()->prefetches_[0]->SetPrefetchStatus(
|
|
PrefetchStatus::kPrefetchFailedNetError);
|
|
EXPECT_TRUE(prefetcher.IsPrefetchAttemptFailedOrDiscarded(
|
|
GetCrossOriginUrl("/candidate1.html")));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace content
|