241ca837df
New usage of (Sequenced|Thread)TaskRunnerHandle::Get() is banned in //content/renderer, but the presubmit was not updated to reflect the new APIs. This fixes that. Bug: 827065, 1026641 Change-Id: Id956180dd7c643251fa57901052316eb814ebf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4525136 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143539}
37 lines
1.4 KiB
Python
Executable File
37 lines
1.4 KiB
Python
Executable File
#!/usr/bin/env python
|
|
# Copyright 2018 The Chromium Authors
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import os
|
|
import sys
|
|
import unittest
|
|
|
|
import PRESUBMIT
|
|
|
|
sys.path.append(
|
|
os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', '..'))
|
|
from PRESUBMIT_test_mocks import (MockInputApi, MockOutputApi, MockAffectedFile)
|
|
|
|
class GetTest(unittest.TestCase):
|
|
def testNewUsageThreadTaskRunnerHandleGet(self):
|
|
diff = ['scoped_refptr<SingleThreadTaskRunner> task_runner =',
|
|
' base::ThreadTaskRunner::GetCurrentDefault()']
|
|
input_api = MockInputApi()
|
|
input_api.files = [MockAffectedFile('content/renderer/foo.cc', diff)]
|
|
errors = PRESUBMIT._CheckForUseOfGlobalTaskRunnerGetter(input_api,
|
|
MockOutputApi())
|
|
self.assertEqual(1, len(errors))
|
|
|
|
def testNewUsageSequencedTaskRunnerHandleGet(self):
|
|
diff = ['scoped_refptr<SequencedThreadTaskRunner> task_runner =',
|
|
' base::SequencedTaskRunner::GetCurrentDefault()']
|
|
input_api = MockInputApi()
|
|
input_api.files = [MockAffectedFile('content/renderer/foo.cc', diff)]
|
|
errors = PRESUBMIT._CheckForUseOfGlobalTaskRunnerGetter(input_api,
|
|
MockOutputApi())
|
|
self.assertEqual(1, len(errors))
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|