`loader_factories_` from the creator's RenderFrameImpl need to be
propagated into the created child/popup frame. This is important to
ensure that subresource loads work in the initial empty document - e.g.
in one created via |window.open('', '_blank')|. See also the earlier
r792963 and https://crbug.com/1106995.
Before this CL, this propagation was taking place in
RenderFrameImpl::DidCommitNavigation and was broken if `window.opener`
was already cleared at this point (as shown by the new test added in
this CL).
After this CL, this propagation is taking place earlier - right after
creating the new frame (by making sure the new
InheritLoaderFactoriesFrom is called from RenderViewImpl::CreateView and
RenderFrameImpl::CreateChildFrame). This fixes the new test.
This CL can remove the GetLoaderFactoryBundleFromCreator method, because
after the CL all the creator->new_frame propagation scenarios are
covered by the calls to the new InheritLoaderFactoriesFrom method.
Bug: 1191203
Change-Id: I35ad4b95ac7170d839ad2138e60ab742e783ab6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783353
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868510}
23fbe11dcb