This reverts commit 93d899e275.
Reason for revert: Breaks on official build due to inclusion of
//chromeos/components/telemetry*
Original change's description:
> Enable `gn check` on //chrome/browser.
>
> Changes are:
> - adding deps when missing.
> - adding "nogncheck" when needed (see below explanation).
> - deleting nonexistent files from sources.
> - new target :net_dns_access for files that depend on
> //net/dns:host_resolver (which has restricted visibility).
> Alternative: could open visibility to all of //chrome/browser instead
> of adding a new target that has visibility.
> - moving //c/b:test_support sources to //c/b/chromeos:test_support or
> //c/test:test_support when they depended on headers there (cannot
> add a dependency, there is a cycle).
> - moving includes to conditional sections when they are used only in
> conditional sections (where it caused deps issues).
> - removing unused includes of test code from non-test code.
> - merging sections in //c/b/BUILD.gn that had the same if() conditions.
> Alternative: revert these changes, they are cosmetic.
> - adding some asserts/conditional blocks in build files that only work
> under those conditions.
>
> "gn check" does not understand #if statements in cc/h files so it
> complains about missing deps in configurations where those deps were
> never actually included. "nogncheck" has been added to the include lines
> to suppress these spurious errors where necessary (sometimes it is not
> necessary because the include is used outside of #if statements in other
> files).
>
> Bug: 898837, 1125897
> Change-Id: I77e7dd3780fb93edb2b555a82b681a870990b496
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383400
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Glen Robertson <glenrob@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807321}
TBR=dpranke@google.com,blundell@chromium.org,dominickn@chromium.org,ericorth@chromium.org,glenrob@chromium.org
Change-Id: I13f4705899734213dd3f82fe60ac431f85584e70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898837
Bug: 1125897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413370
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807339}