
This is a precursor CL to allow SimpleMenuModel to include actions.h, in order to be able to create menu items from action items. Currently, simple_menu_model cannot include actions, as doing so creates a dependency cycle from ui/base -> ui/actions -> ui/base. Many of the changes here are simply renaming include paths from ui/base/models -> ui/menus/models. The only significant changes here that need to be reviewed are changes in BUILD.gn and DEPS files. Change-Id: I345efc6c42bbf2d7fdd539c0b312a8f5db338382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892572 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Joseph Park <josephjoopark@chromium.org> Reviewed-by: Emilia Paz <emiliapaz@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1370692}
46 lines
1.3 KiB
Python
46 lines
1.3 KiB
Python
include_rules = [
|
|
# Do not add Chrome dependencies. Much work went into removing them.
|
|
"+components/browsing_data",
|
|
"+components/crx_file",
|
|
"+components/guest_view",
|
|
"+components/prefs",
|
|
"+components/services/app_service/public",
|
|
"+components/url_matcher",
|
|
"+components/version_info",
|
|
"-content",
|
|
"+content/public/common",
|
|
"+content/public/test",
|
|
"+crypto",
|
|
"-extensions/components",
|
|
"+extensions/grit/extensions_renderer_resources.h",
|
|
"+extensions/grit/extensions_resources.h",
|
|
"+extensions/test",
|
|
"+mojo/public",
|
|
"+services/service_manager/public",
|
|
"+skia/public/mojom",
|
|
"+testing",
|
|
"+third_party/blink/public/common/loader/url_loader_throttle.h",
|
|
"+third_party/skia/include",
|
|
|
|
# Minimal UI dependencies. There are two good rules for UI dependencies here:
|
|
#
|
|
# 1) UI components should only be added as they are needed, and
|
|
# 2) if //content doesn't allow it, //extensions probably won't allow it.
|
|
# (see for example ui/views)
|
|
"-ui",
|
|
"+ui/base",
|
|
"+ui/menus",
|
|
"+ui/gfx",
|
|
"+ui/events",
|
|
|
|
# NOTE: Please do not add includes without talking to the app shell team;
|
|
# see OWNERS for this directory.
|
|
]
|
|
|
|
specific_include_rules = {
|
|
".*(test|test_util)\.(cc|h)$": [
|
|
"+chrome/browser/profiles/profile.h",
|
|
"+content/public/test",
|
|
],
|
|
}
|