chromium/src
0
Fork 0
Code Activity

Fix typos in the instructions.

Browse Source 
Correct an include file path; Correct the hello_world resource id enum; Add a tip for debugging.

Bug: N/A
Change-Id: Ic59fe15f35f974b16ae4354a61ec1b42e0d09d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4199469
Reviewed-by: Anunoy Ghosh <anunoy@chromium.org>
Commit-Queue: Zack Han <zackhan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1101048}
This commit is contained in:
Zack Han
2023-02-03 17:34:06 +00:00
committed by Chromium LUCI CQ
parent aefc1c378c
commit 0075f85e26
1 changed files with 3 additions and 3 deletions

6
docs/webui_in_chrome.md

@ -159,7 +159,7 @@ group("resources") {
Add an entry to resource_ids.spec
This file is for automatically generating resource ids. Ensure that your entry
has a unique ID and preserves numerical ordering.
has a unique ID and preserves numerical ordering. If you see an error like "ValueError: Cannot jump to unvisited", please check the numeric order of your resource ids.
`tools/gritsettings/resource_ids.spec`
@ -228,7 +228,7 @@ class HelloWorldUI : public content::WebUIController {
`chrome/browser/ui/webui/hello_world/hello_world_ui.cc`
```c++
#include "chrome/browser/ui/webui/hello_world_ui.h"
#include "chrome/browser/ui/webui/hello_world/hello_world_ui.h"
#include "chrome/browser/ui/webui/webui_util.h"
#include "chrome/common/webui_url_constants.h"
@ -251,7 +251,7 @@ HelloWorldUI::HelloWorldUI(content::WebUI* web_ui)
webui::SetupWebUIDataSource(
source,
base::make_span(kHelloWorldResources, kHelloWorldResourcesSize),
IDR_HELLO_WORLD_HELLO_WORLD_CONTAINER_HTML);
IDR_HELLO_WORLD_HELLO_WORLD_HTML);
// As a demonstration of passing a variable for JS to use we pass in some
// a simple message.