chromium/src
0
Fork 0
Code Activity

Added new test case for html structure nested inside link.

Browse Source 
This CL adds a new test case for a html structure with a link that has
a nested structure. This adds the expected outputs for auralinux and
blink, and updates some README files to be more descriptive and to
update them to be in-line with current test names.

Added a basic nested structure for <a href> links for future test case.

Added test case for the nested structure a link html.

Generated expected results for new nested structure <a href> tests.

Ran code formatter to complete checklist before raising CL.

Updated README to fix typo and incorrect command, added more info.

Updated tests.md readme to fix same typo as in unit_test readme file.

R=dmazzoni

Bug: 1018555
Change-Id: Ibdea155e586d7b4c00fa31b86d6209f1f63b0195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951781
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#722543}
This commit is contained in:
Mark Schillaci
2019-12-06 18:46:02 +00:00
committed by Commit Bot
parent 37da367a27
commit 00c48fb9e9
6 changed files with 76 additions and 3 deletions

5
content/browser/accessibility/dump_accessibility_tree_browsertest.cc

@ -373,6 +373,11 @@ IN_PROC_BROWSER_TEST_P(DumpAccessibilityTreeTest, AccessibilityAOnclick) {
RunHtmlTest(FILE_PATH_LITERAL("a-onclick.html"));
}
IN_PROC_BROWSER_TEST_P(DumpAccessibilityTreeTest,
AccessibilityANestedStructure) {
RunHtmlTest(FILE_PATH_LITERAL("a-nested-structure.html"));
}
IN_PROC_BROWSER_TEST_P(DumpAccessibilityTreeTest, AccessibilityAIsInteresting) {
RunHtmlTest(FILE_PATH_LITERAL("isInteresting.html"));
}

17
content/test/data/accessibility/html/a-nested-structure-expected-auralinux.txt Normal file

@ -0,0 +1,17 @@
[document web]
++[link] name='Header 1 List element 1 List element 2 List element 3'
++++[heading] name='Header 1'
++++++[static] name='Header 1'
++++[list]
++++++[list item]
++++++++[panel]
++++++++++[static] name='• '
++++++++[static] name='List element 1'
++++++[list item]
++++++++[panel]
++++++++++[static] name='• '
++++++++[static] name='List element 2'
++++++[list item]
++++++++[panel]
++++++++++[static] name='• '
++++++++[static] name='List element 3'

25
content/test/data/accessibility/html/a-nested-structure-expected-blink.txt Normal file

@ -0,0 +1,25 @@
rootWebArea
++genericContainer ignored
++++link name='Header 1 List element 1 List element 2 List element 3'
++++++heading name='Header 1' hierarchicalLevel=1
++++++++staticText name='Header 1'
++++++++++inlineTextBox name='Header 1'
++++++list
++++++++listItem
++++++++++listMarker name='• '
++++++++++++staticText name='• '
++++++++++++++inlineTextBox name='• '
++++++++++staticText name='List element 1'
++++++++++++inlineTextBox name='List element 1'
++++++++listItem
++++++++++listMarker name='• '
++++++++++++staticText name='• '
++++++++++++++inlineTextBox name='• '
++++++++++staticText name='List element 2'
++++++++++++inlineTextBox name='List element 2'
++++++++listItem
++++++++++listMarker name='• '
++++++++++++staticText name='• '
++++++++++++++inlineTextBox name='• '
++++++++++staticText name='List element 3'
++++++++++++inlineTextBox name='List element 3'

15
content/test/data/accessibility/html/a-nested-structure.html Normal file

@ -0,0 +1,15 @@
<!--
@WIN-ALLOW:LINKED
-->
<html>
<body>
<a href="http://www.foobar.com">
<h1>Header 1</h1>
<ul>
<li>List element 1</li>
<li>List element 2</li>
<li>List element 3</li>
</ul>
</a>
</body>
</html>

15
content/test/data/accessibility/readme.md

@ -155,13 +155,24 @@ then run the test with the `--generate-accessibility-test-expectations`
argument, for example:
```
out/Debug/content_browsertests \
--generate-accessibility-test-expectations
--gtest_filter="DumpAccessibilityTreeTest.AccessibilityAriaAtomic/*"
--generate-accessibility-test-expectations \
--gtest_filter="All/DumpAccessibilityTreeTest.AccessibilityAriaAtomic/*"
```
This will replace the `-expected-*.txt` file with the current output. It's
a great way to rebaseline a bunch of tests after making a change. Please
manually check the diff, of course!
The * is a wildcard and will match any substring, in this case all platforms.
To run on a single platform, replace the wildcard, e.g.:
```
--gtest_filter="All/DumpAccessibilityTreeTest.AccessibilityAriaAtomic/linux"
```
For more information, see the detailed help with:
```
out/Debug/content_browsertests --gtest_help
```
## Adding a new test:
If you are adding a new test file remember to add a corresponding test case in:

2
docs/accessibility/tests.md

@ -62,7 +62,7 @@ To run all tests:
```
autoninja -C out/release content_browsertests && \
out/release/content_browsertests --gtest_filter="DumpAccessibilityTree*"
out/release/content_browsertests --gtest_filter="All/DumpAccessibilityTree*"
```
## Other content_browsertests