0

histograms: Migrate ChromeOS Storage UMA to pattern histogram

Bug: none
Test: Check metric names did not change.
Change-Id: Ic9cf810bbd36dfe64b982ee23650516e4932ebc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5124236
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Howard Yang <hcyang@google.com>
Cr-Commit-Position: refs/heads/main@{#1239964}
This commit is contained in:
Gwendal Grignou
2023-12-21 02:14:30 +00:00
committed by Chromium LUCI CQ
parent 2fabf3683d
commit 023e24bb91
2 changed files with 32 additions and 44 deletions
tools/metrics/histograms/metadata

@ -2803,20 +2803,6 @@ chromium-metrics-reviews@google.com.
<affected-histogram name="Permissions.Usage.ElapsedTimeSinceGrant"/>
</histogram_suffixes>
<histogram_suffixes name="PlatformEmmcLifeUsed" separator=".">
<suffix name="TypeA" label="Memory Type A"/>
<suffix name="TypeB" label="Memory Type B"/>
<affected-histogram name="Platform.Emmc.LifeUsed"/>
</histogram_suffixes>
<histogram_suffixes name="PlatformFileSystem" separator="_" ordering="prefix,2">
<suffix name="EncStateful" label="Encrypted Stateful filesystem"/>
<suffix name="Stateful" label="Stateful filesystem /mnt/stateful"/>
<affected-histogram name="Platform.FileSystem.ErrorCount"/>
<affected-histogram name="Platform.FileSystem.FsckNeeded"/>
<affected-histogram name="Platform.FileSystem.RecoveryNeeded"/>
</histogram_suffixes>
<histogram_suffixes name="PlatformMeminfoPercentage" separator="">
<suffix name="infoActive" label="Active memory."/>
<suffix name="infoActiveAnon"
@ -2875,12 +2861,6 @@ chromium-metrics-reviews@google.com.
name="Net.QuicConnectivityMonitor.PercentageAllDegradedSessions"/>
</histogram_suffixes>
<histogram_suffixes name="PlatformStorageUfsLifeUsed" separator=".">
<suffix name="TypeA" label="Calculation Method A"/>
<suffix name="TypeB" label="Calculation Method B"/>
<affected-histogram name="Platform.Storage.Ufs.LifeUsed"/>
</histogram_suffixes>
<histogram_suffixes name="PNaClTranslatorTypes" separator=".">
<suffix name="" label="All translator types"/>
<suffix name="LLC" label="LLC-based translator"/>

@ -487,16 +487,20 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Platform.Emmc.LifeUsed" enum="EmmcLifeUsed"
<histogram name="Platform.Emmc.LifeUsed.{Type}" enum="EmmcLifeUsed"
expires_after="2024-08-07">
<owner>gwendal@google.com</owner>
<owner>chromeos-storage@google.com</owner>
<summary>
eMMC [5.0] Device lifetime estimation for flash. This field provides an
estimated indication about the device lifetime that is reflected by the
averaged wear out of memory of a given type relative to its maximum
estimated lifetime.
averaged wear out of memory of {Type} relative to its maximum estimated
lifetime.
</summary>
<token key="Type">
<variant name="TypeA"/>
<variant name="TypeB"/>
</token>
</histogram>
<histogram name="Platform.ExternalMetrics.SamplesRead" units="count"
@ -523,36 +527,36 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Platform.FileSystem.ErrorCount" units="errors"
<histogram name="Platform.FileSystem.{Partition}.ErrorCount" units="errors"
expires_after="2024-08-07">
<owner>gwendal@google.com</owner>
<owner>chromeos-storage@google.com</owner>
<summary>
Number of file system errors, as reported by dumpe2fs &quot;FS Error
count&quot; field. Reported once per boot.
Number of error in file system {Partition}, as reported by dumpe2fs &quot;FS
Error count&quot; field. Reported once per boot.
</summary>
<token key="Partition">
<variant name="EncStateful"/>
<variant name="Stateful"/>
</token>
</histogram>
<histogram name="Platform.FileSystem.FsckNeeded" enum="Boolean"
<histogram name="Platform.FileSystem.{Partition}_{MountResult}" enum="Boolean"
expires_after="2024-08-07">
<owner>gwendal@google.com</owner>
<owner>chromeos-storage@google.com</owner>
<summary>
True when kernel reports that the file system needs deep recovery. File
system has corruption the kernel can not fix by itself. Reported once per
boot.
</summary>
</histogram>
<histogram name="Platform.FileSystem.RecoveryNeeded" enum="Boolean"
expires_after="2024-08-07">
<owner>gwendal@google.com</owner>
<owner>chromeos-storage@google.com</owner>
<summary>
True when kernel reports that the file system needed recovery at boot. It
indicates the filesytem was not properly unmounted, but was recovered.
Reported once per boot.
{MountResult} is true when kernel reports that file system {Partition}
is/was needed.
</summary>
<token key="Partition">
<variant name="EncStateful"/>
<variant name="Stateful"/>
</token>
<token key="MountResult">
<variant name="FsckNeeded"/>
<variant name="RecoveryNeeded"/>
</token>
</histogram>
<histogram name="Platform.Firmware.Mismatch" enum="BooleanDetected"
@ -2009,16 +2013,20 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Platform.Storage.Ufs.LifeUsed" enum="EmmcLifeUsed"
<histogram name="Platform.Storage.Ufs.LifeUsed.{Type}" enum="EmmcLifeUsed"
expires_after="2024-08-07">
<owner>asavery@chromium.org</owner>
<owner>gwendal@chromium.org</owner>
<owner>chromeos-storage@google.com</owner>
<summary>
UFS Device life time estimation. This field provides an indication of the
device life time based on the amount of performed program/erase cycles. The
calculation is vendor specific.
device life time based on the amount of performed program/erase cycles for
memory {Type}. The calculation is vendor specific.
</summary>
<token key="Type">
<variant name="TypeA"/>
<variant name="TypeB"/>
</token>
</histogram>
<histogram name="Platform.StorageCapabilities"