Stop setting enable_reporting in Cronet gn args
The default for this gn arg is already true; there is no need to override it. This simplifies Cronet gn args. Bug: 40287068 Change-Id: I790a8011082e8c3fed3ab1e6e9b3b95ab34b6ae8 Cq-Include-Trybots: luci.chromium.try:android-cronet-x64-dbg-15-tests,android-cronet-x86-dbg-marshmallow-tests Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6375252 Commit-Queue: Etienne Dechamps <edechamps@google.com> Reviewed-by: Stefano Duo <stefanoduo@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/main@{#1435979}
This commit is contained in:
Etienne Dechamps
committed by
Chromium LUCI CQ
Chromium LUCI CQ
parent
718e8e47b1
commit
02676db3b1
infra/config
generated
builders
ci
android-cronet-arm-dbg
android-cronet-arm-rel
android-cronet-arm64-dbg
android-cronet-arm64-gn2bp-dbg
android-cronet-arm64-rel
android-cronet-asan-arm-rel
android-cronet-asan-x86-rel
android-cronet-code-coverage-java
android-cronet-code-coverage-native
android-cronet-mainline-clang-arm64-dbg
android-cronet-mainline-clang-arm64-rel
android-cronet-mainline-clang-riscv64-dbg
android-cronet-mainline-clang-riscv64-rel
android-cronet-mainline-clang-x86-dbg
android-cronet-mainline-clang-x86-rel
android-cronet-marshmallow-arm64-perf-rel
android-cronet-riscv64-dbg
android-cronet-riscv64-rel
android-cronet-x64-dbg
android-cronet-x64-rel
android-cronet-x86-dbg
android-cronet-x86-rel
try
android-cronet-arm-dbg
android-cronet-arm-rel
android-cronet-arm64-dbg
android-cronet-arm64-gn2bp-dbg
android-cronet-arm64-rel
android-cronet-asan-arm-rel
android-cronet-mainline-clang-arm64-dbg
android-cronet-mainline-clang-arm64-rel
android-cronet-mainline-clang-riscv64-dbg
android-cronet-mainline-clang-riscv64-rel
android-cronet-mainline-clang-x86-dbg
android-cronet-mainline-clang-x86-rel
android-cronet-riscv64-dbg
android-cronet-riscv64-rel
android-cronet-x64-dbg-12-tests
android-cronet-x64-dbg-13-tests
android-cronet-x64-dbg-14-tests
android-cronet-x64-dbg-15-tests
android-cronet-x64-dbg
android-cronet-x64-rel
android-cronet-x86-dbg-10-tests
android-cronet-x86-dbg-11-tests
android-cronet-x86-dbg-marshmallow-tests
android-cronet-x86-dbg-nougat-tests
android-cronet-x86-dbg-oreo-tests
android-cronet-x86-dbg-pie-tests
android-cronet-x86-dbg
android-cronet-x86-rel
gn_args
tools/mb
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 27,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"ffmpeg_branding": "Chrome",
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -7,7 +7,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -7,7 +7,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -7,7 +7,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 27,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -7,7 +7,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -7,7 +7,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -6,7 +6,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -7,7 +7,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 29,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -4,7 +4,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -5,7 +5,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"disable_file_support": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
@ -420,7 +420,6 @@ gn_args.config(
|
||||
# should be empty.
|
||||
# LINT.IfChange(cronet_android)
|
||||
"use_partition_alloc": False,
|
||||
"enable_reporting": True,
|
||||
"use_hashed_jni_names": True,
|
||||
"default_min_sdk_version": 23,
|
||||
"clang_use_default_sample_profile": False,
|
||||
|
||||
@ -827,7 +827,7 @@
|
||||
'cronet_android': {
|
||||
'mixins': ['cronet_common'],
|
||||
# LINT.IfChange(cronet_android)
|
||||
'gn_args': ('use_partition_alloc=false enable_reporting=true '
|
||||
'gn_args': ('use_partition_alloc=false '
|
||||
'use_hashed_jni_names=true '
|
||||
'default_min_sdk_version=23 '
|
||||
'clang_use_default_sample_profile=false '
|
||||
|
||||
@ -35,7 +35,6 @@
|
||||
"debuggable_apks": false,
|
||||
"default_min_sdk_version": 23,
|
||||
"enable_kythe_annotations": true,
|
||||
"enable_reporting": true,
|
||||
"enable_resource_allowlist_generation": false,
|
||||
"enable_websockets": false,
|
||||
"include_transport_security_state_preload_list": false,
|
||||
|
||||
Reference in New Issue
Block a user