chromium/src
0
Fork 0
Code Activity

Make DUMP_WILL_BE_* fatal for non-official builds

Browse Source 
This is a proxy for non-user-facing builds (testing, fuzzing). Any early
detection for will-be-fatal invariant violations seems good at face
value, let's try it out.

Bug: None
Change-Id: I46322b144d8e871bb4a83e9fe45f0958ebe97eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783255
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1341369}
This commit is contained in:
Peter Boström
2024-08-14 00:05:40 +00:00
committed by Chromium LUCI CQ
parent 85a0bef092
commit 029ef5893a
1 changed files with 6 additions and 5 deletions

11
base/check.cc

@ -30,12 +30,13 @@ namespace logging {
namespace {
LogSeverity GetDumpSeverity() {
#if BUILDFLAG(USE_FUZZING_ENGINE)
// Crash in fuzzing builds because non-fatal CHECKs will eventually be
// migrated to fatal CHECKs.
return LOGGING_FATAL;
#else
#if defined(OFFICIAL_BUILD)
return DCHECK_IS_ON() ? LOGGING_DCHECK : LOGGING_ERROR;
#else
// Crash outside official builds (outside user-facing builds) to detect
// invariant violations early in release-build testing like fuzzing, etc.
// These should eventually be migrated to fatal CHECKs.
return LOGGING_FATAL;
#endif
}