chromium/src
0
Fork 0
Code Activity

Be more explicit and clear about OWNERS needing to be committers.

Browse Source 
You could sort of guess at what the actual requirement was before,
but this makes it a bit clearer.

Bug: 376077658
Change-Id: I9fb0646bb4183f79916b44c7cb19ab9f403aa7e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203519
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#1412396}
This commit is contained in:
Dirk Pranke
2025-01-28 10:20:57 -08:00
committed by Chromium LUCI CQ
parent 79b131a588
commit 02c8906fa7
1 changed files with 3 additions and 4 deletions

7
docs/code_reviews.md

@ -85,7 +85,9 @@ committer is sufficient.
The existing owners of a directory approve additions to the list. It is
preferable to have many directories, each with a smaller number of specific
owners rather than large directories with many owners. Owners should:
owners rather than large directories with many owners. Owners must be
[committers](https://www.chromium.org/getting-involved/become-a-committer/)
with at least 3 months' tenure, and in addition should:
* Demonstrate excellent judgment, teamwork and ability to uphold
[Chromium development principles](contributing.md).
@ -93,9 +95,6 @@ owners rather than large directories with many owners. Owners should:
* Be already acting as an owner, providing high-quality reviews and design
feedback.
* Be a Chromium project member with full commit access of at least three
months tenure.
* Have submitted a substantial number of non-trivial changes to the affected
directory.