chromium/src
0
Fork 0
Code Activity

Add file comments to link two notification_helper related tests

Browse Source 
... because they have quite different file locations due to data
dependency restriction.

Bug: 734095
Change-Id: I737e7a9f7edc3fb12ef14ccd025ff0afc6688535
Reviewed-on: https://chromium-review.googlesource.com/1013096
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551595}
This commit is contained in:
Xi Cheng
2018-04-18 06:27:14 +00:00
committed by Commit Bot
parent f2ccd7414b
commit 02df6ab3df
2 changed files with 18 additions and 0 deletions

12
chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc

@ -2,6 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// This test file is an evolution of
// notification_helper/notification_helper_process_unittest.cc. In addition to
// testing launching notification_helper.exe by the OS via registry which is
// what notification_helper_process_unittest is all about, this test also tests
// if chrome.exe can be successfully launched by notification_helper.exe via the
// NotificationActivator::Activate function.
//
// This test is compiled into unit_tests.exe under chrome rather than
// notification_helper_unittests.exe. This is because unit_tests.exe has data
// dependency on chrome.exe which is required by this test, and it's undesired
// to make notification_helper_unittests.exe have data dependency on chrome.exe.
#include <memory>
#include <NotificationActivationCallback.h>

6
notification_helper/notification_helper_process_unittest.cc

@ -2,6 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// This file tests launching notification_helper.exe by the OS via the registry.
// An advanced version of this test is in
// chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc,
// which additionally tests if chrome.exe can be successfully launched by
// notification_helper.exe via the NotificationActivator::Activate function.
#include <wrl/client.h>
#include "base/base_paths.h"