0

Remove the ResolveBareFragmentWithColonOnNonHierarchical url feature

This behavior has been shipping since M114 without any fallout reported.
Remove it.

Bug: 1220361
Change-Id: Ie44e823d09295ce6820dfc41e3036095cbb628ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259304
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255861}
This commit is contained in:
Fredrik Söderquist
2024-02-03 01:19:07 +00:00
committed by Chromium LUCI CQ
parent 3775adf33a
commit 043e85aa48
3 changed files with 1 additions and 13 deletions

@ -163,9 +163,7 @@ bool DoIsRelativeURL(const char* base,
// If the scheme isn't valid, then it's relative.
if (!IsValidScheme(url, scheme)) {
if (url[begin] == '#' &&
base::FeatureList::IsEnabled(
kResolveBareFragmentWithColonOnNonHierarchical)) {
if (url[begin] == '#') {
// |url| is a bare fragment (e.g. "#foo:bar"). This can be resolved
// against any base. Fall-through.
} else if (!is_base_hierarchical) {

@ -16,11 +16,6 @@ BASE_FEATURE(kRecordIDNA2008Metrics,
"RecordIDNA2008Metrics",
base::FEATURE_ENABLED_BY_DEFAULT);
// Kill switch for crbug.com/1220361.
BASE_FEATURE(kResolveBareFragmentWithColonOnNonHierarchical,
"ResolveBareFragmentWithColonOnNonHierarchical",
base::FEATURE_ENABLED_BY_DEFAULT);
// Kill switch for crbug.com/1416006.
BASE_FEATURE(kStandardCompliantNonSpecialSchemeURLParsing,
"StandardCompliantNonSpecialSchemeURLParsing",

@ -27,11 +27,6 @@ COMPONENT_EXPORT(URL) bool IsRecordingIDNA2008Metrics();
// enabled. See url::kStandardCompliantNonSpecialSchemeURLParsing for details.
COMPONENT_EXPORT(URL) bool IsUsingStandardCompliantNonSpecialSchemeURLParsing();
// When enabled, allows resolving of a bare fragment containing a colon against
// a non-hierarchical URL. (For example '#foo:bar' against 'about:blank'.)
COMPONENT_EXPORT(URL)
BASE_DECLARE_FEATURE(kResolveBareFragmentWithColonOnNonHierarchical);
// When enabled, Chrome uses standard-compliant URL parsing for non-special
// scheme URLs. See https://crbug.com/1416006 for details.
COMPONENT_EXPORT(URL)