chromium/src
0
Fork 0
Code Activity

Roll Android Lint from kqQgSDAgfuKTUIT8g... to DjoXGsdMeTwnppye9...

Browse Source 
This includes some manual fixes of more serious and obvious issues, and
a rebaseline for all other new lint errors introduced by this roll.

Change-Id: Ic6b19a0213dd808877765fba6ba713c25ecf3c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4655781
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1164713}
This commit is contained in:
Sam Maier
2023-06-30 16:00:51 +00:00
committed by Chromium LUCI CQ
parent 41c7565ea3
commit 052ca425dd
9 changed files with 78 additions and 149 deletions
DEPS
android_webview/tools/system_webview_shell
lint-baseline.xml
chrome
android
expectations
lint-baseline.xml
browser
ui
android
omnibox
java
src
org
chromium
chrome
browser
omnibox
status
StatusMediator.java
chromecast/android
lint-baseline.xml
components
content_capture
android
java
src
org
chromium
components
content_capture
OnscreenContentProvider.java
cronet
android
lint-baseline.xml
content/public/android/java/src/org/chromium/content/browser/selection
SelectionPopupControllerImpl.java
remoting/android
lint-baseline.xml

2
DEPS

@ -1073,7 +1073,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/android_build_tools/lint',
'version': 'kqQgSDAgfuKTUIT8gpYlhM9gvajbtIDs_ApDbh3wdNIC',
'version': 'DjoXGsdMeTwnppye9Nwe5ozhXIqKyJQDzgb0nTFH8SAC',
},
],
'condition': 'checkout_android',

4
android_webview/tools/system_webview_shell/lint-baseline.xml

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.2.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha08">
<issues format="6" by="lint 8.2.0-alpha10" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha10">
<issue
id="MissingClass"
@ -140,7 +140,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java"
line="221"
line="194"
column="24"/>
</issue>

201
chrome/android/expectations/lint-baseline.xml

File diff suppressed because one or more lines are too long

2
chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/status/StatusMediator.java

@ -77,7 +77,7 @@ public class StatusMediator implements PermissionDialogController.Observer,
private @BrandedColorScheme int mBrandedColorScheme = BrandedColorScheme.APP_DEFAULT;
private @DrawableRes int mSecurityIconRes;
private @DrawableRes int mSecurityIconTintRes;
private @ColorRes int mSecurityIconTintRes;
private @StringRes int mSecurityIconDescriptionRes;
private @ColorRes int mNavigationIconTintRes;

2
chromecast/android/lint-baseline.xml

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.2.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha08">
<issues format="6" by="lint 8.2.0-alpha10" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha10">
<issue
id="UnspecifiedRegisterReceiverFlag"

2
components/content_capture/android/java/src/org/chromium/components/content_capture/OnscreenContentProvider.java

@ -9,6 +9,7 @@ import android.os.Build;
import android.view.View;
import android.view.ViewStructure;
import androidx.annotation.RequiresApi;
import androidx.annotation.VisibleForTesting;
import org.chromium.base.Log;
@ -209,6 +210,7 @@ public class OnscreenContentProvider {
}
@VisibleForTesting(otherwise = VisibleForTesting.NONE)
@RequiresApi(Build.VERSION_CODES.Q)
public void removePlatformConsumerForTesting() {
for (ContentCaptureConsumer consumer : mContentCaptureConsumers) {
if (consumer instanceof PlatformContentCaptureConsumer) {

2
components/cronet/android/lint-baseline.xml

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.2.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha08">
<issues format="6" by="lint 8.2.0-alpha10" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha10">
<issue
id="AssertionSideEffect"

10
content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java

@ -1677,9 +1677,13 @@ public class SelectionPopupControllerImpl extends ActionModeCallbackHelper
@Override
public void setSelectionClient(@Nullable SelectionClient selectionClient) {
mSelectionClient = selectionClient;
mSmartSelectionEventProcessor = mSelectionClient == null
? null
: (SmartSelectionEventProcessor) mSelectionClient.getSelectionEventProcessor();
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
mSmartSelectionEventProcessor = mSelectionClient == null
? null
: (SmartSelectionEventProcessor) mSelectionClient.getSelectionEventProcessor();
} else {
mSmartSelectionEventProcessor = null;
}
mClassificationResult = null;

2
remoting/android/lint-baseline.xml

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.2.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha08">
<issues format="6" by="lint 8.2.0-alpha10" type="baseline" client="" dependencies="true" name="" variant="all" version="8.2.0-alpha10">
<issue
id="WrongConstant"