turn off collecting diagnostics on idevice eg testing

collecting diagnostics seem to cause xcode processes to hang on iOS17.4+, and we don't really need it in most cases as it mainly collects verbose logs archives and sysdiagnoses. Turning it off on all idevice eg testing, and opened a task to add support for turning it on/off using testing configs.

Bug: 340857498
Change-Id: I7fef4e5919c3578565fcb1c04c49e93d0fc7e490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5525311
Reviewed-by: Zhaoyang Li <zhaoyangli@chromium.org>
Commit-Queue: Yue She <yueshe@google.com>
Cr-Commit-Position: refs/heads/main@{#1301508}

ios/build/bots/scripts/xcodebuild_runner.py

@@ -201,6 +201,13 @@ class LaunchCommand(object):
       outdir_attempt = os.path.join(self.out_dir, 'attempt_%d' % attempt)
       cmd_list = self.egtests_app.command(outdir_attempt, 'id=%s' % self.udid,
                                           clones)
+
+      # TODO(crbug.com/340857498): temporarily turning this off on all
+      # device testing due to Xcode hang on iOS17.4+. In the future
+      # we should have a testing config flag to toggle this on/off
+      if not iossim_util.is_device_with_udid_simulator(self.udid):
+        cmd_list.extend(['-collect-test-diagnostics', 'never'])
+
       # TODO(crbug.com/40606422): add heartbeat logging to xcodebuild_runner.
       LOGGER.info('Start test attempt #%d for command [%s]' %
                   (attempt, ' '.join(cmd_list)))