chromium/src
0
Fork 0
Code Activity

Create a flag for using Skia renderer in the PDF viewer

Browse Source 
Add a feature flag "pdf-use-skia-renderer", which will be a
indicator that PDF viewer uses Skia renderer instead of the default
AGG renderer.

Currently this flag is a dummy flag that has not been linked to the
PDFiumEngine yet.

Bug: 1379872
Change-Id: I837a8d69ef326f882addce591139de3013a16186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000204
Commit-Queue: Nigi <nigi@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1067920}
This commit is contained in:
Hui Yingst
2022-11-06 18:59:22 +00:00
committed by Chromium LUCI CQ
parent 44b84f4aa9
commit 058c23702e
7 changed files with 22 additions and 0 deletions

4
chrome/browser/about_flags.cc

@ -6390,6 +6390,10 @@ const FeatureEntry kFeatureEntries[] = {
{"accessible-pdf-form", flag_descriptions::kAccessiblePDFFormName,
flag_descriptions::kAccessiblePDFFormDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kAccessiblePDFForm)},
{"pdf-use-skia-renderer", flag_descriptions::kPdfUseSkiaRendererName,
flag_descriptions::kPdfUseSkiaRendererDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kPdfUseSkiaRenderer)},
#endif // BUILDFLAG(ENABLE_PDF)
#if BUILDFLAG(ENABLE_PRINTING)

5
chrome/browser/flag-metadata.json

@ -5555,6 +5555,11 @@
"owners": [ "//ui/accessibility/OWNERS" ],
"expiry_milestone": 110
},
{
"name": "pdf-use-skia-renderer",
"owners": [ "nigi", "//pdf/OWNERS" ],
"expiry_milestone": 122
},
{
"name": "pdf-xfa-forms",
"owners": [ "thestig", "//pdf/OWNERS" ],

3
chrome/browser/flag_descriptions.cc

@ -36,6 +36,9 @@ const char kAcceleratedVideoEncodeDescription[] =
const char kAccessiblePDFFormName[] = "Accessible PDF Forms";
const char kAccessiblePDFFormDescription[] =
"Enables accessibility support for PDF forms.";
const char kPdfUseSkiaRendererName[] = "Use Skia Renderer";
const char kPdfUseSkiaRendererDescription[] = "Use Skia as the PDF renderer.";
#endif
const char kAccountIdMigrationName[] = "Account ID migration";

3
chrome/browser/flag_descriptions.h

@ -52,6 +52,9 @@ extern const char kAcceleratedVideoEncodeDescription[];
#if BUILDFLAG(ENABLE_PDF)
extern const char kAccessiblePDFFormName[];
extern const char kAccessiblePDFFormDescription[];
extern const char kPdfUseSkiaRendererName[];
extern const char kPdfUseSkiaRendererDescription[];
#endif
extern const char kAccountIdMigrationName[];

4
pdf/pdf_features.cc

@ -23,6 +23,10 @@ BASE_FEATURE(kPdfPartialLoading,
"PdfPartialLoading",
base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kPdfUseSkiaRenderer,
"PdfUseSkiaRenderer",
base::FEATURE_DISABLED_BY_DEFAULT);
// Feature has no effect if Chrome is built with no XFA support.
BASE_FEATURE(kPdfXfaSupport,
"PdfXfaSupport",

1
pdf/pdf_features.h

@ -16,6 +16,7 @@ namespace features {
BASE_DECLARE_FEATURE(kAccessiblePDFForm);
BASE_DECLARE_FEATURE(kPdfIncrementalLoading);
BASE_DECLARE_FEATURE(kPdfPartialLoading);
BASE_DECLARE_FEATURE(kPdfUseSkiaRenderer);
BASE_DECLARE_FEATURE(kPdfXfaSupport);
BASE_DECLARE_FEATURE(kTabAcrossPDFAnnotations);

2
tools/metrics/histograms/enums.xml

@ -63578,6 +63578,7 @@ from previous Chrome versions.
<int value="1526574513" label="HoldingSpaceRefresh:enabled"/>
<int value="1526718531"
label="DarkenWebsitesCheckboxInThemesSetting:enabled"/>
<int value="1527072723" label="PdfUseSkiaRenderer:enabled"/>
<int value="1527172748" label="disable-http2-grease-settings"/>
<int value="1527292264" label="DisplayChangeModal:enabled"/>
<int value="1529979182" label="EnablePasswordSelection:enabled"/>
@ -63603,6 +63604,7 @@ from previous Chrome versions.
<int value="1543027970" label="EnableDisplayZoomSetting:disabled"/>
<int value="1543349770" label="CastUseBlocklistForRemotingQuery:disabled"/>
<int value="1544413751" label="PasswordStrengthIndicator:enabled"/>
<int value="1544561349" label="PdfUseSkiaRenderer:disabled"/>
<int value="1546652609" label="SharingHubDesktopOmnibox:disabled"/>
<int value="1548776701" label="AllBookmarks:disabled"/>
<int value="1548942246" label="PassiveDocumentEventListeners:disabled"/>