chromium/src
0
Fork 0
Code Activity

No need to support old style dasher domains.

Browse Source 
BUG=137118
TEST=See unit tests, not called in any code yet


Review URL: https://chromiumcodereview.appspot.com/11185002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162184 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
rogerta@chromium.org
2012-10-16 18:34:24 +00:00
parent e7837c1c67
commit 06c84e4068
2 changed files with 3 additions and 5 deletions

4
google_apis/gaia/gaia_auth_util.cc

@ -64,9 +64,7 @@ bool IsGaiaSignonRealm(const GURL& url) {
if (!url.SchemeIsSecure())
return false;
// Also check "https://www.google.com" to support old style dasher logins.
return url == GURL(GaiaUrls::GetInstance()->gaia_origin_url()) ||
url == GURL("https://www.google.com/");
return url == GURL(GaiaUrls::GetInstance()->gaia_origin_url());
}
} // namespace gaia

4
google_apis/gaia/gaia_auth_util_unittest.cc

@ -88,11 +88,11 @@ TEST(GaiaAuthUtilTest, SanitizeExistingDomain) {
TEST(GaiaAuthUtilTest, IsGaiaSignonRealm) {
// Only https versions of Gaia URLs should be considered valid.
EXPECT_TRUE(IsGaiaSignonRealm(GURL("https://accounts.google.com/")));
EXPECT_TRUE(IsGaiaSignonRealm(GURL("https://www.google.com/")));
EXPECT_FALSE(IsGaiaSignonRealm(GURL("http://accounts.google.com/")));
EXPECT_FALSE(IsGaiaSignonRealm(GURL("http://www.google.com/")));
// Other Google URLs are not valid.
EXPECT_FALSE(IsGaiaSignonRealm(GURL("https://www.google.com/")));
EXPECT_FALSE(IsGaiaSignonRealm(GURL("http://www.google.com/")));
EXPECT_FALSE(IsGaiaSignonRealm(GURL("https://google.com/")));
EXPECT_FALSE(IsGaiaSignonRealm(GURL("https://mail.google.com/")));