Temporarily disable network service sandboxing for headless
As a drive-by, update the identifier used in docs/mojo_and_services.md to refer to actual predicate. Bug: 364362654, 40052246 Change-Id: I920b1cf07030649d6306c931b0d6f97b9cae1551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874912 Reviewed-by: Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1357466}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
aa98ead63f
commit
0771689adb
docs
headless/lib/browser
@ -445,7 +445,7 @@ out-of-process using `content::ServiceProcessHost::Launch()`.
|
||||
|
||||
As a last resort, dynamic or feature based mapping to an underlying platform
|
||||
sandbox can be achieved but requires plumbing through ContentBrowserClient
|
||||
(e.g. `ShouldEnableNetworkServiceSandbox()`).
|
||||
(e.g. `ShouldSandboxNetworkService()`).
|
||||
|
||||
## Content-Layer Services Overview
|
||||
|
||||
|
@ -453,6 +453,12 @@ HeadlessContentBrowserClient::CreateWindowForVideoPictureInPicture(
|
||||
return std::make_unique<HeadlessVideoOverlayWindow>();
|
||||
}
|
||||
|
||||
// TODO(364362654, 40052246): force-disable network service sandboxing
|
||||
// until it's stable in headful.
|
||||
bool HeadlessContentBrowserClient::ShouldSandboxNetworkService() {
|
||||
return false;
|
||||
}
|
||||
|
||||
void HeadlessContentBrowserClient::HandleExplicitlyAllowedPorts(
|
||||
::network::mojom::NetworkService* network_service) {
|
||||
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
|
||||
|
@ -136,6 +136,8 @@ class HeadlessContentBrowserClient : public content::ContentBrowserClient {
|
||||
CreateWindowForVideoPictureInPicture(
|
||||
content::VideoPictureInPictureWindowController* controller) override;
|
||||
|
||||
bool ShouldSandboxNetworkService() override;
|
||||
|
||||
private:
|
||||
class StubBadgeService;
|
||||
|
||||
|
Reference in New Issue
Block a user