0

[gin] Add flag for V8 Error.stack change

This CL adds a kill switch for https://crrev.com/c/5378709.

R=syg@chromium.org

Bug: 327467399
Change-Id: Ia4d0486d402df8f9cb82a814959c12d84d8a7b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5382165
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276214}
This commit is contained in:
Simon Zünd
2024-03-21 14:53:37 +00:00
committed by Chromium LUCI CQ
parent 4b1c288aef
commit 09d366b822
3 changed files with 9 additions and 0 deletions

@ -202,6 +202,10 @@ BASE_FEATURE(kV8UseLibmTrigFunctions,
"V8UseLibmTrigFunctions",
base::FEATURE_ENABLED_BY_DEFAULT);
BASE_FEATURE(kV8UseOriginalMessageForStackTrace,
"V8UseOriginalMessageForStackTrace",
base::FEATURE_ENABLED_BY_DEFAULT);
// Elide redundant TDZ hole checks in bytecode. This only sets the V8 flag when
// manually overridden.
BASE_FEATURE(kV8IgnitionElideRedundantTdzChecks,

@ -62,6 +62,7 @@ GIN_EXPORT BASE_DECLARE_FEATURE(kV8Turboshaft);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8TurboshaftInstructionSelection);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8TurboFastApiCalls);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8UseLibmTrigFunctions);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8UseOriginalMessageForStackTrace);
GIN_EXPORT extern const base::FeatureParam<base::TimeDelta>
kV8MemoryReducerStartDelay;
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptRabGsab);

@ -428,6 +428,10 @@ void SetFlags(IsolateHolder::ScriptMode mode,
"--use-libm-trig-functions",
"--no-use-libm-trig-functions");
SetV8FlagsIfOverridden(features::kV8UseOriginalMessageForStackTrace,
"--use-original-message-for-stack-trace",
"--no-use-original-message-for-stack-trace");
SetV8FlagsIfOverridden(features::kJavaScriptCompileHintsMagic,
"--compile-hints-magic", "--no-compile-hints-magic");