chromium/src
0
Fork 0
Code Activity

Remove temporary metrics for DeskBarWindowOcclusionOptimization.

Browse Source 
These metrics were added solely to debug the experiment:
Ash.Overview.WindowOcclusionCalculator.EnterLatency
Ash.Overview.WindowOcclusionCalculator.ExitLatency
Ash.Overview.DeskBarNumLayersMirrored

They do not serve much general use, so they're being removed now
that the finch experiment is launching.

OBSOLETE_HISTOGRAMS=Metric was only to debug DeskBarWindowOcclusionOptimization experiment. Experiment is now launched.

Bug: b:294094124
Change-Id: I67fcdeef70eb903531f585aa35b3499fba87454f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019425
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michele Fan <michelefan@chromium.org>
Commit-Queue: Eric Sum <esum@google.com>
Cr-Commit-Position: refs/heads/main@{#1382623}
This commit is contained in:
Eric Sum
2024-11-13 22:28:44 +00:00
committed by Chromium LUCI CQ
parent 523ff3fbb0
commit 0aba0f1149
5 changed files with 0 additions and 77 deletions

14
ash/wm/desks/desk_bar_view_base.cc

@ -1632,20 +1632,6 @@ void DeskBarViewBase::UpdateNewMiniViews(bool initializing_bar_view,
++mini_view_index;
}
// Only record for `initializing_bar_view` since that's what impacts the
// presentation time and animation smoothness when entering overview.
if (initializing_bar_view && type_ == Type::kOverview) {
size_t total_layers_mirrored = 0;
for (const auto& mini_view : mini_views_) {
total_layers_mirrored +=
mini_view->desk_preview()->GetNumLayersMirrored();
}
// From local testing, 16 chrome browser windows (which metrics show is
// likely much more than what most users have) resulted in ~1000 layers.
base::UmaHistogramCounts1000("Ash.Overview.DeskBarNumLayersMirrored",
total_layers_mirrored);
}
if (expanding_bar_view) {
SwitchToExpandedState();
return;

13
ash/wm/desks/desk_preview_view.cc

@ -159,15 +159,6 @@ std::optional<size_t> GetWindowZOrderForDeskAndRoot(const aura::Window* window,
return std::nullopt;
}
// Returns the total number of layers that are descendants of `root`.
size_t GetNumDescendants(ui::Layer* root) {
size_t num_descendants = root->children().size();
for (const auto& child : root->children()) {
num_descendants += GetNumDescendants(child);
}
return num_descendants;
}
// Recursively mirrors `source_layer` and its children and adds them as children
// of `parent`, taking into account the given |layers_data|. If the layer data
// of `source_layer` has `should_clear_transform` set to true, the transforms of
@ -604,10 +595,6 @@ void DeskPreviewView::AcceptSelection() {
: DesksSwitchSource::kMiniViewButton);
}
size_t DeskPreviewView::GetNumLayersMirrored() const {
return GetNumDescendants(desk_mirrored_contents_layer_tree_owner_->root());
}
void DeskPreviewView::Layout(PassKey) {
const gfx::Rect bounds = GetContentsBounds();
wallpaper_preview_->SetBoundsRect(bounds);

4
ash/wm/desks/desk_preview_view.h

@ -114,10 +114,6 @@ class ASH_EXPORT DeskPreviewView : public views::Button,
// swipes.
void AcceptSelection();
// For metrics purposes only. Returns the total number of layers mirrored
// to preview the desk's windows.
size_t GetNumLayersMirrored() const;
// views::Button:
void Layout(PassKey) override;
bool OnMousePressed(const ui::MouseEvent& event) override;

5
ash/wm/overview/overview_window_occlusion_calculator.cc

@ -9,7 +9,6 @@
#include "ash/wm/desks/desks_controller.h"
#include "ash/wm/desks/desks_util.h"
#include "ash/wm/overview/overview_controller.h"
#include "base/metrics/histogram_functions.h"
#include "base/trace_event/trace_event.h"
namespace ash {
@ -33,8 +32,6 @@ void OverviewWindowOcclusionCalculator::OnOverviewModeStarting() {
}
TRACE_EVENT0("ui",
"OverviewWindowOcclusionCalculator::OnOverviewModeWillStart");
base::ScopedUmaHistogramTimer timer(
"Ash.Overview.WindowOcclusionCalculator.EnterLatency");
calculator_.emplace();
// Compute initial occlusion state of all desk's windows before occlusion
// calculations are paused at the end of this method. Without this, the
@ -78,8 +75,6 @@ void OverviewWindowOcclusionCalculator::OnOverviewModeEnding(
if (calculator_) {
TRACE_EVENT0("ui",
"OverviewWindowOcclusionCalculator::OnOverviewModeEnding");
base::ScopedUmaHistogramTimer timer(
"Ash.Overview.WindowOcclusionCalculator.ExitLatency");
calculator_->RemoveObserver(this);
calculator_.reset();
}

41
tools/metrics/histograms/metadata/ash/histograms.xml

@ -6842,21 +6842,6 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Ash.Overview.DeskBarNumLayersMirrored" units="units"
expires_after="2025-04-20">
<owner>esum@google.com</owner>
<owner>cros-sw-perf@google.com</owner>
<summary>
Records the number of ui/compositor layers that were mirrored when rendering
the desk bar as part of overview mode. More specifically, these are the
layers mirrored to create the &quot;mini views&quot; of each desk within the
desk bar. Recorded once per overview mode session in which the desk bar was
present; if the mirrored layers are rebuilt after the first rendering, this
is not counted. Not recorded for overview mode sessions without the desk
bar.
</summary>
</histogram>
<histogram name="Ash.Overview.DeskBarVisibility" enum="DeskBarVisibility"
expires_after="2025-04-13">
<owner>esum@google.com</owner>
@ -7087,32 +7072,6 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Ash.Overview.WindowOcclusionCalculator.EnterLatency"
units="ms" expires_after="2025-04-13">
<owner>esum@google.com</owner>
<owner>chromeos-wm@google.com</owner>
<summary>
Records the amount of time window occlusion calculations take when entering
overview mode. The window occlusion calculations are used to optimize the
desk bar that appears as part of overview mode. Recorded every time overview
mode is opened and the DeskBarWindowOcclusionOptimizationEnabled experiment
flag is enabled.
</summary>
</histogram>
<histogram name="Ash.Overview.WindowOcclusionCalculator.ExitLatency" units="ms"
expires_after="2025-04-13">
<owner>esum@google.com</owner>
<owner>chromeos-wm@google.com</owner>
<summary>
Records the amount of time window occlusion calculations take when exiting
overview mode. The window occlusion calculations are used to optimize the
desk bar that appears as part of overview mode. Recorded every time overview
mode is closed and the DeskBarWindowOcclusionOptimizationEnabled experiment
flag is enabled.
</summary>
</histogram>
<histogram name="Ash.Peripheral.ConnectivityResults"
enum="PeripheralConnectivityResult" expires_after="2025-04-27">
<owner>jimmyxgong@chromium.org</owner>