0

Revert "Enable the tessellation atlas for general path rendering"

This reverts commit a1179182c6.

Reason for revert: 

webgl_conformance_gles_passthrough_tests on Android device Pixel 4 failed. This CL is suspected to be the culprit. 

https://bugs.chromium.org/p/chromium/issues/detail?id=1235232#c3

Original change's description:
> Enable the tessellation atlas for general path rendering
>
> This is a drastic change to how non-MSAA paths are rendered in Chrome.
> After this CL, and as long as multisample support is enabled, non-convex
> paths with 256^2 pixels or fewer will be rendered by tessellation in a
> 2048x2048 multisampled alpha8 atlas. This will give tremendous
> improvements in path rendering times and overall CPU usge. This change
> will also cause Skia to quit caching path bitmaps in many cases, so we
> can expect to see some memory savings. Dropping the path cache is not
> expected to impact performance much because the tiles themselves are
> their own bitmap cache.
>
> Bug: chromium:928984
> Bug: skia:12258
> Change-Id: I1a4e2dba65d2db4a74f766aa944e4a64782df271
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3062518
> Auto-Submit: Chris Dalton <csmartdalton@chromium.org>
> Commit-Queue: Chris Dalton <csmartdalton@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Justin Novosad <junov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#907388}

Bug: chromium:928984
Bug: skia:12258
Change-Id: Ia31b52c278ac7b34a90e665fc7e864d513e254fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3064607
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Matthias Körber <koerber@google.com>
Commit-Queue: Matthias Körber <koerber@google.com>
Auto-Submit: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#907512}
This commit is contained in:
Matthias Körber
2021-08-02 12:23:38 +00:00
committed by Chromium LUCI CQ
parent 917594a9b9
commit 0ac42a48dc
21 changed files with 2 additions and 0 deletions

Binary file not shown.

Before

(image error) Size: 818 B

After

(image error) Size: 1.0 KiB

Binary file not shown.

Before

(image error) Size: 5.4 KiB

After

(image error) Size: 5.6 KiB

Binary file not shown.

Before

(image error) Size: 2.6 KiB

After

(image error) Size: 3.0 KiB

@ -207,6 +207,8 @@ SK_API void SkDebugf_FileLine(const char* file,
#define SK_SUPPORT_LEGACY_AAA_CHOICE
#define SK_DISABLE_ATLAS_PATH_RENDERER_WITH_COVERAGE_AA
#define SK_SUPPORT_LEGACY_DRAWLOOPER
#define SK_SUPPORT_LEGACY_RUNTIME_EFFECTS

Binary file not shown.

Before

(image error) Size: 16 KiB

After

(image error) Size: 17 KiB

Binary file not shown.

Before

(image error) Size: 17 KiB

After

(image error) Size: 18 KiB

Binary file not shown.

Before

(image error) Size: 59 KiB

After

(image error) Size: 70 KiB

Binary file not shown.

Before

(image error) Size: 30 KiB

After

(image error) Size: 33 KiB

Binary file not shown.

Before

(image error) Size: 14 KiB

After

(image error) Size: 14 KiB

Binary file not shown.

Before

(image error) Size: 8.6 KiB

After

(image error) Size: 8.7 KiB

Binary file not shown.

Before

(image error) Size: 49 KiB

After

(image error) Size: 49 KiB

Binary file not shown.

Before

(image error) Size: 18 KiB

After

(image error) Size: 21 KiB

Binary file not shown.

Before

(image error) Size: 14 KiB

After

(image error) Size: 14 KiB

Binary file not shown.

Before

(image error) Size: 7.4 KiB

After

(image error) Size: 12 KiB

Binary file not shown.

Before

(image error) Size: 5.9 KiB

After

(image error) Size: 6.6 KiB

Binary file not shown.

Before

(image error) Size: 8.5 KiB

After

(image error) Size: 12 KiB

Binary file not shown.

Before

(image error) Size: 6.1 KiB

After

(image error) Size: 6.5 KiB