Delete chrome_pdf::kTabAcrossPDFAnnotations feature flag.

The flag has been on by default for quite some time.

Bug: 994500
Change-Id: Id28d80740cef7ef83d463b56a8d02d88bd431d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237817
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1103613}

pdf/pdf_features.cc

@@ -32,9 +32,5 @@ BASE_FEATURE(kPdfXfaSupport,
              "PdfXfaSupport",
              base::FEATURE_DISABLED_BY_DEFAULT);
 
-BASE_FEATURE(kTabAcrossPDFAnnotations,
-             "TabAcrossPDFAnnotations",
-             base::FEATURE_ENABLED_BY_DEFAULT);
-
 }  // namespace features
 }  // namespace chrome_pdf

pdf/pdf_features.h

@@ -18,7 +18,6 @@ BASE_DECLARE_FEATURE(kPdfIncrementalLoading);
 BASE_DECLARE_FEATURE(kPdfPartialLoading);
 BASE_DECLARE_FEATURE(kPdfUseSkiaRenderer);
 BASE_DECLARE_FEATURE(kPdfXfaSupport);
-BASE_DECLARE_FEATURE(kTabAcrossPDFAnnotations);
 
 }  // namespace features
 }  // namespace chrome_pdf

pdf/pdfium/pdfium_engine.cc

@@ -2959,8 +2959,7 @@ void PDFiumEngine::LoadForm() {
                                     kFormHighlightColor);
     FPDF_SetFormFieldHighlightAlpha(form(), kFormHighlightAlpha);
 
-    if (base::FeatureList::IsEnabled(features::kTabAcrossPDFAnnotations) &&
-        !client_->IsPrintPreview()) {
+    if (!client_->IsPrintPreview()) {
       static constexpr FPDF_ANNOTATION_SUBTYPE kFocusableAnnotSubtypes[] = {
           FPDF_ANNOT_LINK, FPDF_ANNOT_HIGHLIGHT, FPDF_ANNOT_WIDGET};
       FPDF_BOOL ret = FPDFAnnot_SetFocusableSubtypes(

pdf/pdfium/pdfium_engine_unittest.cc

@@ -1004,11 +1004,6 @@ TEST_P(PDFiumEngineTabbingTest, LinkUnderCursor) {
    * ++++ Highlight annotation
    * ++++ Link annotation
    */
-  // Enable feature flag.
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndEnableFeature(
-      chrome_pdf::features::kTabAcrossPDFAnnotations);
-
   NiceMock<MockTestClient> client;
   std::unique_ptr<PDFiumEngine> engine =
       InitializeEngine(&client, FILE_PATH_LITERAL("annots.pdf"));
@@ -1093,12 +1088,6 @@ TEST_P(PDFiumEngineTabbingTest, TabbingSupportedAnnots) {
    * ++++ Highlight annotation
    * ++++ Link annotation
    */
-
-  // Enable feature flag.
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndEnableFeature(
-      chrome_pdf::features::kTabAcrossPDFAnnotations);
-
   TestClient client;
   std::unique_ptr<PDFiumEngine> engine =
       InitializeEngine(&client, FILE_PATH_LITERAL("annots.pdf"));