0

Fix PDFiumPageThumbnail tests on Win Arm64

This CL makes the PDFiumPageThumbnail tests use the same test files
on Win Arm64 as it does on Mac Arm64, which makes the tests pass. I've
also renamed the test files to remove "mac_" since we're also using
them on Windows.

Bug: 1426656
Change-Id: I5b2bae08d326e1ea0c07fe56f824b5861e3d1511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4358198
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1120293}
This commit is contained in:
David Bienvenu
2023-03-22 00:15:52 +00:00
committed by Chromium LUCI CQ
parent 4ab7a64dc0
commit 0c73db3c9a
16 changed files with 3 additions and 3 deletions

@ -913,9 +913,9 @@ TEST_P(PDFiumPageThumbnailTest, GenerateThumbnail) {
{6, 2, {46, 1399}}, // Super tall
};
#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM64)
#if defined(ARCH_CPU_ARM64)
std::string file_name =
GetParam() ? "variable_page_sizes_mac_arm64" : "variable_page_sizes";
GetParam() ? "variable_page_sizes_arm64" : "variable_page_sizes";
#else
std::string file_name = "variable_page_sizes";
#endif

@ -12,7 +12,7 @@ the thumbnail rendering of the fourth page of `variable_page_sizes.pdf` with a
device to pixel ratio of 2.0.
Also some PNG file names contain extra renderer type and device information.
For example, the file "variable_page_sizes_mac_arm64_expected_skia.pdf.3.png"
For example, the file "variable_page_sizes_arm64_expected_skia.pdf.3.png"
is generated with Skia renderer on a macOS device with ARM64 CPU. If the
renderer type and the device information are not included, by default the PNG
files are generated with AGG renderer using a device with non-ARM64 CPU.