chromium/src
0
Fork 0
Code Activity

[CodeHealth] Fix gn check for //remoting/host/file_transfer:*

Browse Source 
Bug: 1159006
Change-Id: If570aeeff0a311f6faacd6355320335197467a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972667
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Vidhan Jain <vidhanj@google.com>
Cr-Commit-Position: refs/heads/master@{#894033}
This commit is contained in:
Vidhan
2021-06-19 00:12:32 +00:00
committed by Chromium LUCI CQ
parent 030ee94985
commit 0cc2ddb670
2 changed files with 18 additions and 5 deletions
.gn
remoting/host/file_transfer
BUILD.gn

2
.gn

@ -73,7 +73,7 @@ no_check_targets = [
"//ppapi/proxy:*", # 31 errors
"//ppapi/thunk:*", # 1071 errors
"//ppapi:*", # 3 errors
"//remoting/host/file_transfer:*", # 43 errors
"//remoting/host/file_transfer:*", # 2 errors
"//remoting/host/installer/mac:*", # 1 error
"//remoting/host/mac:*", # 49 errors
"//remoting/host/security_key:*", # 68 errors

21
remoting/host/file_transfer/BUILD.gn

@ -44,12 +44,18 @@ source_set("file_transfer") {
sources += [ "file_chooser_chromeos.cc" ]
} else if (is_linux) {
sources += [ "file_chooser_linux.cc" ]
deps += [ "//build/config/linux/gtk" ]
deps += [
"//build/config/linux/gtk",
"//ui/base:base",
]
}
}
source_set("common") {
public = [
"buffered_file_writer.h",
"ensure_user.h",
"file_chooser.h",
"file_operations.h",
"file_transfer_message_handler.h",
"ipc_file_operations.h",
@ -60,9 +66,6 @@ source_set("common") {
sources = [
"buffered_file_writer.cc",
"buffered_file_writer.h",
"ensure_user.h",
"file_chooser.h",
"file_transfer_message_handler.cc",
"ipc_file_operations.cc",
"local_file_operations.cc",
@ -72,7 +75,11 @@ source_set("common") {
deps = [
"//base",
"//net:net",
"//remoting/base:base",
"//remoting/protocol",
"//ui/base:base",
"//url:url",
]
}
@ -90,6 +97,7 @@ source_set("test_support") {
]
deps = [
":common",
"//base:base",
"//remoting/protocol",
]
}
@ -108,7 +116,12 @@ source_set("unit_tests") {
deps = [
":common",
":test_support",
"//base:base",
"//base/test:test_support",
"//net:net",
"//remoting/base:base",
"//remoting/protocol",
"//remoting/protocol:test_support",
"//testing/gtest",
]
}