0

[Extensions] Remove Hangouts allowlist hashes and rtcPrivate permission

This CL removes the last reminants of the extension API allowlist
entries for the old Hangouts Extension 🫡

Since this was also the last entry in the rtcPrivate feature allowlist,
this also removes the entries for it and marks it as deleted. This CL
would have also removed the rtcPrivate API code, but it turns out that
was already removed back in 2013 with:
https://chromiumcodereview.appspot.com/23731011

Bug: 391414840
Change-Id: Ib19b6d03c566a23b98c827ea069479626cef604c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249484
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Tim <tjudkins@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418763}
This commit is contained in:
Tim Judkins
2025-02-11 10:22:15 -08:00
committed by Chromium LUCI CQ
parent ca61757372
commit 0d03e9e2ca
12 changed files with 2 additions and 83 deletions
chrome
common
test
data
extensions
api_test
ext_auto
auto_provider
extensions
tools/metrics/histograms/metadata/extensions

@ -841,10 +841,6 @@
"chrome://print/*"
]
}],
"rtcPrivate": {
"dependencies": ["permission:rtcPrivate"],
"contexts": ["privileged_extension"]
},
"safeBrowsingPrivate": {
"dependencies": ["permission:safeBrowsingPrivate"],
"contexts": ["privileged_extension"]

@ -845,16 +845,6 @@
],
"location": "component"
},
"rtcPrivate": {
"channel": "stable",
"extension_types": ["extension", "legacy_packaged_app"],
"allowlist": [
"53041A2FA309EECED01FFC751E7399186E860B2C", // Google Talk prod
"A74A4D44C7CFCD8844830E6140C8D763E12DD8F3", // Google Talk beta
"E7E2461CE072DF036CF9592740196159E2D7C089", // Google Talk alpha
"312745D9BF916161191143F6490085EEA0434997" // Google Talk debug
]
},
"safeBrowsingPrivate": {
"channel": "stable",
"extension_types": ["extension"],

@ -176,8 +176,6 @@ constexpr APIPermissionInfo::InitInfo permissions_to_register[] = {
{APIPermissionID::kPdfViewerPrivate, "pdfViewerPrivate"},
{APIPermissionID::kResourcesPrivate, "resourcesPrivate",
APIPermissionInfo::kFlagCannotBeOptional},
{APIPermissionID::kRtcPrivate, "rtcPrivate",
APIPermissionInfo::kFlagCannotBeOptional},
{APIPermissionID::kSafeBrowsingPrivate, "safeBrowsingPrivate"},
{APIPermissionID::kSettingsPrivate, "settingsPrivate",
APIPermissionInfo::kFlagCannotBeOptional},

@ -860,7 +860,6 @@ TEST(PermissionsTest, PermissionMessages) {
skip.insert(APIPermissionID::kPdfViewerPrivate);
skip.insert(APIPermissionID::kImageWriterPrivate);
skip.insert(APIPermissionID::kResourcesPrivate);
skip.insert(APIPermissionID::kRtcPrivate);
skip.insert(APIPermissionID::kSafeBrowsingPrivate);
skip.insert(APIPermissionID::kSmartCardProviderPrivate);
skip.insert(APIPermissionID::kSystemPrivate);

@ -1,39 +0,0 @@
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
var action_counter = 0;
chrome.rtcPrivate.onLaunch.addListener(function(launchData) {
if(!launchData) {
console.log('HANDLER: got default action');
action_counter++;
return;
}
var action = launchData.intent.action;
if (action == 'chat' || action == 'video' || action == 'voice') {
console.log('HANDLER: Received ' + action +
', data = ' + launchData.intent.data);
var data = launchData.intent.data;
var type = launchData.intent.type;
if (type != 'application/vnd.chromium.contact' ||
data.name != 'Test Contact' ||
data.phone.length != 2 ||
data.phone[0] != '(555) 111-2222' ||
data.phone[1] != '(555) 333-4444' ||
data.email.length != 2 ||
data.email[0] != 'test_1@something.com' ||
data.email[1] != 'test_2@something.com') {
chrome.test.fail('HANDLER: Invalid data!');
return;
}
action_counter++;
if (action_counter == 4)
chrome.test.sendMessage('received_all');
} else {
console.log('HANDLER: unknown action - ' + action);
chrome.test.fail('HANDLER: No content changed!');
return;
}
});

@ -1,9 +0,0 @@
{
"key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCefVITdQJ4vgVKTcldCJNWOqOLH+HMnUIV8fYkO0yaFzhO467toPQ2XZZIszU0KO41ZRE7p8D0dDnIB8D9a0/btKE3QhQ/eJmcPLcGj1t0oyeaNDU/LwmeP1q85Xt9PGCkFYASyynfGhVibxGoAYOIcpZka+/nH/HO1yukGrIK4wIDAQAB",
"name": "rtc_private_api_event_handler",
"version": "1.0",
"manifest_version": 2,
"description": "Test that makes sure RTC-related events are properly raised.",
"background": { "scripts": ["background.js"] },
"permissions": [ "rtcPrivate" ]
}

@ -51,7 +51,6 @@
"plugin",
"privacy",
"proxy",
"rtcPrivate",
"runtime",
"serial",
"syncFileSystem",

@ -276,10 +276,6 @@ ExtensionFunction::ResponseAction AppWindowCreateFunction::Run() {
#endif
"0F42756099D914A026DADFA182871C015735DD95", // http://crbug.com/323773
"2D22CDB6583FD0A13758AEBE8B15E45208B4E9A7",
"E7E2461CE072DF036CF9592740196159E2D7C089", // http://crbug.com/356200
"A74A4D44C7CFCD8844830E6140C8D763E12DD8F3",
"312745D9BF916161191143F6490085EEA0434997",
"53041A2FA309EECED01FFC751E7399186E860B2C",
"A07A5B743CD82A1C2579DB77D353C98A23201EEF", // http://crbug.com/413748
"F16F23C83C5F6DAD9B65A120448B34056DD80691",
"0F585FB1D0FDFBEBCE1FEB5E9DFFB6DA476B8C9B"};

@ -29,13 +29,6 @@
"channel": "stable",
"extension_types": ["platform_app"],
"allowlist": [
// Keep this list in sync with extensions_misc::kHangoutsExtensionIds but
// omit the Packaged App ids.
"53041A2FA309EECED01FFC751E7399186E860B2C", // Hangouts Production.
"312745D9BF916161191143F6490085EEA0434997", // Hangouts Debug.
"E7E2461CE072DF036CF9592740196159E2D7C089", // Hangouts Alpha.
"A74A4D44C7CFCD8844830E6140C8D763E12DD8F3", // Hangouts Beta.
"5107DE9024C329EEA9C9A72D94C16723790C6422" // Apps Debugger
]
},

@ -42,10 +42,6 @@
"allowlist": [
"0F42756099D914A026DADFA182871C015735DD95", // http://crbug.com/323773
"2D22CDB6583FD0A13758AEBE8B15E45208B4E9A7",
"E7E2461CE072DF036CF9592740196159E2D7C089", // http://crbug.com/356200
"A74A4D44C7CFCD8844830E6140C8D763E12DD8F3",
"312745D9BF916161191143F6490085EEA0434997",
"53041A2FA309EECED01FFC751E7399186E860B2C",
"A07A5B743CD82A1C2579DB77D353C98A23201EEF", // http://crbug.com/413748
"F16F23C83C5F6DAD9B65A120448B34056DD80691",
"0F585FB1D0FDFBEBCE1FEB5E9DFFB6DA476B8C9B"

@ -148,7 +148,7 @@ enum APIPermissionID {
kProxy = 121,
kImageWriterPrivate = 122,
kDeleted_ReadingListPrivate = 123,
kRtcPrivate = 124,
kDeleted_RtcPrivate = 124,
kSearchProvider = 125,
kSearchEnginesPrivate = 126,
kSerial = 127,

@ -3039,7 +3039,7 @@ Called by update_extension_permission.py.-->
<int value="121" label="kProxy"/>
<int value="122" label="kImageWriterPrivate"/>
<int value="123" label="kDeleted_ReadingListPrivate"/>
<int value="124" label="kRtcPrivate"/>
<int value="124" label="kDeleted_RtcPrivate"/>
<int value="125" label="kSearchProvider"/>
<int value="126" label="kSearchEnginesPrivate"/>
<int value="127" label="kSerial"/>