0

Clean up includes in content/public/common/child_process_host.h.

Remove unnecessary includes and replace them with missing includes if
necessary. Fix the build by adding missing includes in various files
that depended on child_process_host.h's includes.

Also uninline ~ChildProcessHost().

Bug: 242216
Change-Id: I387ac9782910af2eedeed82de5355707dd63de48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309695
Reviewed-by: Alexander Timin <altimin@chromium.org>
Owners-Override: Alexander Timin <altimin@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#947045}
This commit is contained in:
Lei Zhang
2021-12-01 16:43:34 +00:00
committed by Chromium LUCI CQ
parent 8d1152d618
commit 0e004cbe4c
11 changed files with 16 additions and 4 deletions
chrome/browser
ash
policy
ui
android
profile_picker.h
tab_contents
webui
chromeos
in_session_password_change
chromecast/browser/webui
components/paint_preview/player/android/javatests
content

@ -8,6 +8,7 @@
#include <memory>
#include "base/bind.h"
#include "base/callback_list.h"
#include "base/cancelable_callback.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"

@ -12,6 +12,7 @@
#include "content/public/browser/context_menu_params.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents_user_data.h"
#include "mojo/public/cpp/bindings/associated_remote.h"
namespace content {
class WebContents;

@ -15,6 +15,7 @@
#include "url/gurl.h"
class GURL;
class Profile;
namespace base {
class FilePath;

@ -15,6 +15,7 @@
#include "components/search_engines/template_url.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
#include "mojo/public/cpp/bindings/associated_remote.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/image/image.h"
#include "url/gurl.h"

@ -5,8 +5,11 @@
#ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_IN_SESSION_PASSWORD_CHANGE_LOCK_SCREEN_NETWORK_DIALOG_H_
#define CHROME_BROWSER_UI_WEBUI_CHROMEOS_IN_SESSION_PASSWORD_CHANGE_LOCK_SCREEN_NETWORK_DIALOG_H_
#include "base/callback_forward.h"
#include "chrome/browser/ui/webui/chromeos/in_session_password_change/base_lock_dialog.h"
class Profile;
namespace chromeos {
class LockScreenNetworkDialog : public BaseLockDialog {

@ -9,6 +9,8 @@
#include "chromecast/browser/webui/mojom/webui.mojom.h"
#include "content/public/browser/url_data_source.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/remote.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
namespace chromecast {

@ -14,6 +14,7 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/strings/strcat.h"
#include "base/threading/thread_restrictions.h"
#include "components/paint_preview/browser/paint_preview_base_service.h"
#include "components/paint_preview/browser/test_paint_preview_policy.h"
#include "components/paint_preview/common/file_stream.h"

@ -59,6 +59,8 @@ base::AtomicSequenceNumber g_unique_id;
namespace content {
ChildProcessHost::~ChildProcessHost() = default;
// static
std::unique_ptr<ChildProcessHost> ChildProcessHost::Create(
ChildProcessHostDelegate* delegate,

@ -25,6 +25,7 @@
#include "third_party/abseil-cpp/absl/types/optional.h"
namespace IPC {
class Channel;
class MessageFilter;
}

@ -11,12 +11,10 @@
#include <string>
#include "base/clang_profiling_buildflags.h"
#include "base/files/scoped_file.h"
#include "build/build_config.h"
#include "content/common/content_export.h"
#include "ipc/ipc_channel_proxy.h"
#include "ipc/ipc_sender.h"
#include "mojo/public/cpp/bindings/generic_pending_receiver.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/system/message_pipe.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
@ -41,7 +39,7 @@ class ChildProcessHostDelegate;
// processes that run independent of the browser process.
class CONTENT_EXPORT ChildProcessHost : public IPC::Sender {
public:
~ChildProcessHost() override {}
~ChildProcessHost() override;
// This is a value never returned as the unique id of any child processes of
// any kind, including the values returned by RenderProcessHost::GetID().

@ -17,6 +17,7 @@
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
#include "content/web_test/common/web_test_switches.h"
#include "ipc/ipc_channel.h"
#if !defined(OS_ANDROID)
#include "content/public/browser/devtools_frontend_host.h"