0

Rewrite most Foo* field_ pointer fields to raw_ptr<Foo> field_.

DO NOT REVERT (unless absolutely necessary)! Report build breaks to keishi@(APAC)/glazunov@(EMEA)/sebmarchand@(NA) as soon as you see them. Fixes are expected to be trivial.

This commit was generated automatically, by running the following script: tools/clang/rewrite_raw_ptr_fields/rewrite-multiple-platforms.sh on commit fe74bc434e

For more information, see MiraclePtr One Pager [1], the PSA at chromium-dev@ [2], and the raw_ptr documentation in //base/memory/raw_ptr.md.

FYI This CL does not enable MiraclePtr protection and we expect no behavior change from this.

[1] https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg/edit?usp=sharing
[2] https://groups.google.com/a/chromium.org/g/chromium-dev/c/vAEeVifyf78/m/SkBUc6PhBAAJ

Binary-Size: Increase of around 500kb was approved for MiraclePtr
Include-Ci-Only-Tests: true
No-Tree-Checks: true
No-Presubmit: true
Bug: 1272324, 1073933
Change-Id: I05c86a83bbb4b3f4b017f361dd7f4e7437697f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Owners-Override: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#945735}
This commit is contained in:
Keishi Hattori
2021-11-27 09:25:52 +00:00
committed by Chromium LUCI CQ
parent 75157d1dd0
commit 0e45c020c4
8125 changed files with 23727 additions and 15551 deletions
android_webview
browser
aw_autofill_client.haw_browser_context_unittest.ccaw_browser_main_parts.haw_browser_process.haw_content_browser_client.haw_contents.ccaw_contents_client_bridge.ccaw_contents_client_bridge_unittest.ccaw_form_database_service_unittest.ccaw_pac_processor.ccaw_pac_processor_unittest.ccaw_pdf_exporter.haw_permission_manager_unittest.ccaw_quota_manager_bridge.haw_render_process.haw_settings.ccfind_helper.h
gfx
icon_helper.h
js_java_interaction
lifecycle
metrics
network_service
permission
renderer_host
safe_browsing
scoped_add_feature_flags.h
nonembedded
test
apps
base
android
barrier_callback_unittest.ccbarrier_closure_unittest.ccbig_endian.hbind_unittest.cccallback_list_unittest.cccallback_unittest.cc
containers
debug
feature_list.hfile_version_info_win.h
files
i18n
json
lazy_instance_unittest.cc
memory
message_loop
metrics
observer_list_threadsafe.hobserver_list_threadsafe_unittest.ccobserver_list_unittest.ccone_shot_event_unittest.ccpath_service.ccpickle.h
process
profiler
sampling_heap_profiler
scoped_generic.hscoped_multi_source_observation.h
strings
supports_user_data_unittest.ccsync_socket_unittest.cc
synchronization
task
test
threading
timer
tools_sanity_unittest.cc
trace_event
tracing
vlog.h
win
cc
animation
base
benchmarks
input
layers
metrics
mojo_embedder
paint
raster
resources
scheduler
test
tiles
trees
chrome
android
features
cablev2_authenticator
browser
accessibility
accuracy_tips
android
accessibility
autocomplete
autofill_assistant
background_tab_manager.h
bookmarks
chrome_backup_agent_unittest.cc
compositor
context_menu
contextualsearch
customtabs
devtools_manager_delegate_android.cc
dom_distiller
explore_sites
favicon_helper.ccfavicon_helper_unittest.ccforeign_session_helper.h
history
history_report
hung_renderer_infobar_delegate.h
locale
logo_bridge.h
ntp
omnibox
oom_intervention
preferences
recently_closed_tabs_bridge.h
search_permissions
send_tab_to_self
signin
tab_android.cctab_favicon.h
usage_stats
vr
webapk
apps
ash
autocomplete
autofill
availability
background
background_fetch
background_sync
badging
banners
bitmap_fetcher
bluetooth
bookmarks
breadcrumbs
browser_process_impl.h
browser_switcher
browsing_data
captive_portal
cart
chrome_browser_field_trials.hchrome_browser_main.hchrome_content_browser_client.ccchrome_content_browser_client_browsertest.ccchrome_content_browser_client_unittest.ccchrome_security_exploit_browsertest.cc
chromeos
command_updater_impl.h
commerce
complex_tasks
component_updater
content_index
content_settings
custom_handlers
data_reduction_proxy
data_saver
data_use_measurement
device_api
device_identity
device_reauth
diagnostics
dom_distiller
download
endpoint_fetcher
engagement
enterprise
browser_management
connectors
remote_commands
reporting
signals
util
extensions
active_tab_unittest.cc
activity_log
api
activity_log_private
autofill_private
bookmark_manager_private
bookmarks
braille_display_private
browsing_data
commands
content_settings
context_menus
cookies
cryptotoken_private
debugger
declarative_content
declarative_net_request
developer_private
device_permissions_manager_unittest.cc
downloads
extension_action
feedback_private
font_settings
gcm
history
identity
image_writer_private
input_ime
language_settings_private
management
mdns
messaging
notifications
omnibox
passwords_private
preference
processes
runtime
safe_browsing_private
sessions
settings_overrides
settings_private
signed_in_devices
storage
system_indicator
tab_capture
tab_groups
tabs
web_authentication_proxy
web_navigation
web_request
webrtc_audio_private
webrtc_logging_private
webstore_private
app_background_page_apitest.ccblocklist.hblocklist_check.hblocklist_extension_prefs_unittest.ccblocklist_states_interaction_unittest.ccbrowser_extension_window_controller.hchrome_app_icon.hchrome_app_icon_service.hchrome_app_sorting.hchrome_app_sorting_unittest.ccchrome_content_verifier_delegate.hchrome_content_verifier_unittest.ccchrome_extension_chooser_dialog.hchrome_extension_cookies.hchrome_extension_function_details.hchrome_extension_test_notification_observer.hchrome_test_extension_loader.ccchrome_test_extension_loader.hcomponent_loader.hcomponent_loader_unittest.cccontext_menu_matcher.hcontext_menu_matcher_unittest.cccorb_and_cors_extension_browsertest.cccorrupted_extension_reinstaller.hcrx_installer.hcrx_installer_browsertest.ccdev_mode_bubble_delegate.h
error_console
event_router_forwarder_unittest.ccextension_action_icon_factory.hextension_action_icon_factory_unittest.ccextension_action_runner.hextension_action_runner_browsertest.ccextension_action_runner_unittest.ccextension_action_storage_manager.hextension_allowlist.hextension_allowlist_unittest.ccextension_browser_window_helper.hextension_browsertest.hextension_commands_global_registry.hextension_context_menu_browsertest.ccextension_context_menu_model.hextension_context_menu_model_unittest.ccextension_cookies_browsertest.ccextension_disabled_ui.ccextension_error_controller.hextension_error_controller_unittest.ccextension_error_ui_default.ccextension_error_ui_default.hextension_error_ui_default_unittest.ccextension_function_test_utils.ccextension_garbage_collector.hextension_gcm_app_handler.hextension_gcm_app_handler_unittest.ccextension_icon_manager.hextension_install_prompt.hextension_install_prompt_show_params.ccextension_install_prompt_show_params.hextension_keybinding_registry.hextension_management.hextension_management_test_util.hextension_management_unittest.ccextension_message_bubble_controller.hextension_message_bubble_controller_unittest.ccextension_migrator.hextension_navigation_throttle_unittest.ccextension_security_exploit_browsertest.ccextension_service.hextension_service_sync_unittest.ccextension_service_test_base.hextension_service_test_with_install.hextension_special_storage_policy.ccextension_sync_service.hextension_system_impl.hextension_uninstall_dialog.ccextension_uninstall_dialog.hextension_unload_browsertest.ccextension_url_loader_throttle_browsertest.ccextension_view_host.hextension_web_ui_unittest.ccextension_webui_apitest.ccexternal_component_loader.hexternal_install_error.ccexternal_install_error.hexternal_install_manager.hexternal_loader.hexternal_policy_loader.hexternal_pref_loader.hexternal_provider_impl.h
forced_extensions
install_verifier.hinstalled_loader.hlazy_background_page_apitest.ccmenu_manager.hmenu_manager_test_observer.ccmenu_manager_test_observer.hnavigation_observer.hnavigation_observer_browsertest.ccomaha_attributes_handler.hpack_extension_job.hpending_extension_manager.hpermissions_based_management_policy_provider.hpermissions_based_management_policy_provider_unittest.ccpermissions_updater.hpermissions_updater_unittest.ccplugin_manager.hpreinstalled_apps.hpreinstalled_apps_browsertest.ccproxy_overridden_bubble_delegate.hsafe_browsing_verdict_handler.ccsafe_browsing_verdict_handler.hscoped_active_install.ccscoped_active_install.hscripting_permissions_modifier.hservice_worker_apitest.ccsettings_api_bubble_delegate.hshared_module_service.hstandard_management_policy_provider.hsubscribe_page_action_browsertest.ccsuspicious_extension_bubble_delegate.htab_helper.htest_blocklist.htest_blocklist_state_fetcher.htest_extension_environment.htest_extension_system.htheme_installed_infobar_delegate.hunpacked_installer.hupdate_install_gate.hupdate_install_gate_unittest.cc
updater
user_script_listener_unittest.ccwarning_badge_service.ccwarning_badge_service.hwarning_badge_service_unittest.ccwebstore_data_fetcher.hwebstore_install_helper.hwebstore_installer.hwebstore_standalone_installer.hwindow_controller.hzipfile_installer_unittest.cc
favicon
federated_learning
feed
feedback
file_select_helper.hfile_select_helper_unittest.cc
file_system_access
font_family_cache.hfont_pref_change_notifier.h
gcm
geolocation
google
guest_view
history
history_clusters
image_decoder
image_editor
image_fetcher
importer
infobars
installable
lens
lifetime
lite_video
local_discovery
login_detection
lookalikes
media
android
cast_mirroring_performance_browsertest.cccast_mirroring_service_host_browsertest.cccast_remoting_connector.cccast_remoting_connector.hcdm_document_service_impl.h
history
media_engagement_browsertest.ccmedia_engagement_contents_observer.hmedia_engagement_contents_observer_unittest.ccmedia_engagement_score.hmedia_engagement_score_unittest.ccmedia_engagement_service.hmedia_engagement_service_unittest.ccmedia_engagement_session.hoffscreen_tab.ccoffscreen_tab.hprotected_media_identifier_permission_context_unittest.cc
router
webrtc
media_galleries
memory
metrics
nacl_host
native_window_notification_source.h
navigation_predictor
net
new_tab_page
notifications
ntp_tiles
offline_pages
optimization_guide
page_info
page_load_metrics
password_check
password_entry_edit
password_manager
payments
pdf
performance_hints
performance_manager
permissions
persisted_state_db
picture_in_picture
plugins
policy
power_bookmarks
predictors
prefetch
prefs
printing
privacy
privacy_budget
privacy_sandbox
profile_resetter
profiles
push_messaging
reading_list
recovery
renderer_context_menu
renderer_host
reputation
resource_coordinator
safe_browsing
advanced_protection_status_manager.h
android
certificate_reporting_service.hcertificate_reporting_service_factory.h
chrome_cleaner
chrome_client_side_detection_host_delegate.hchrome_client_side_detection_host_delegate_unittest.ccchrome_client_side_detection_service_delegate.hchrome_enterprise_url_lookup_service.hchrome_password_protection_service.hchrome_password_protection_service_unittest.ccclient_side_detection_host_unittest.ccclient_side_detection_service_unittest.cc
cloud_content_scanning
download_protection
extension_telemetry
generated_safe_browsing_pref.h
incident_reporting
safe_browsing_blocking_page_test.ccsafe_browsing_navigation_observer_browsertest.ccsafe_browsing_service_browsertest.ccservices_delegate.h
settings_reset_prompt
tailored_security
telemetry
test_safe_browsing_database_helper.cctest_safe_browsing_database_helper.htest_safe_browsing_service.hthreat_details_unittest.ccuser_interaction_observer.hv4_embedded_test_server_browsertest.cc
search
search_engines
security_events
segmentation_platform
send_tab_to_self
serial
sessions
share
sharesheet
sharing
sharing_hub
signin
site_isolation
speech
spellchecker
ssl
status_icons
subresource_filter
subresource_redirect
supervised_user
sync
sync_file_system
tab_contents
task_manager
themes
thumbnail
touch_to_fill
tracing
ui
android
app_icon_loader.h
app_list
search
apps
ash
aura
autofill
bluetooth
bookmarks
browser.ccbrowser.hbrowser_browsertest.ccbrowser_command_controller.hbrowser_command_controller_unittest.ccbrowser_content_setting_bubble_model_delegate.hbrowser_instant_controller.hbrowser_instant_controller_unittest.ccbrowser_live_tab_context.hbrowser_location_bar_model_delegate.hbrowser_navigator.ccbrowser_navigator_params.hbrowser_tab_menu_model_delegate.hbrowser_tab_restorer.ccbrowser_tab_strip_model_delegate.hbrowser_unittest.ccchrome_select_file_policy.h
commander
content_settings
cookie_controls
exclusive_access
extensions
find_bar
global_error
global_media_controls
hats
hung_plugin_tab_helper.ccintent_picker_tab_helper.ccintent_picker_tab_helper.h
interventions
javascript_dialogs
login
media_router
omnibox
page_info
passwords
popup_browsertest.cc
prefs
qrcode_generator
read_later
recently_audible_helper.hrecently_audible_helper_unittest.ccsad_tab.hscoped_tabbed_browser_displayer.h
search
search_engines
send_tab_to_self
shared_highlighting
sharing_hub
signin
signin_reauth_view_controller.ccsignin_reauth_view_controller.hsignin_reauth_view_controller_browsertest.ccsignin_view_controller.ccsignin_view_controller.hsignin_view_controller_interactive_uitest.cc
startup
sync
tab_contents
tab_modal_confirm_dialog_browsertest.htab_modal_confirm_dialog_delegate.h
tab_sharing
tabs
task_manager
test
thumbnails
toolbar
translate
unload_controller.h
user_education
views
accessibility
apps
autofill
bluetooth_device_credentials_view.h
bookmarks
bubble
bubble_anchor_util_views.hcertificate_selector.hcertificate_selector_browsertest.ccchrome_cleaner_dialog_win.ccchrome_cleaner_dialog_win.hclose_bubble_on_tab_activation_helper.hcollected_cookies_views.cccollected_cookies_views.hcollected_cookies_views_browsertest.cccommander_frontend_views.cccommander_frontend_views.hcommander_frontend_views_browsertest.ccconfirm_bubble_views.hconstrained_web_dialog_delegate_views.cccontent_setting_bubble_contents.cccontent_setting_bubble_contents.hcontent_setting_bubble_contents_interactive_uitest.cccookie_info_view.cccreate_application_shortcut_view.h
desktop_capture
device_chooser_content_view.hdevice_chooser_content_view_unittest.ccdevtools_process_observer.h
download
drag_and_drop_interactive_uitest.ccdropdown_bar_host.helevation_icon_setter.hexclusive_access_bubble_views.ccexclusive_access_bubble_views.h
extensions
external_protocol_dialog.hexternal_protocol_dialog_browsertest.cc
eye_dropper
file_system_access
find_bar_host.hfind_bar_view.hflying_indicator.ccflying_indicator.hfolder_upload_confirmation_view_browsertest.cc
frame
fullscreen_control
global_media_controls
hats
hover_button.cchover_button.hhung_renderer_view.cchung_renderer_view.hincognito_clear_browsing_data_dialog.hincognito_clear_browsing_data_dialog_browsertest.cc
infobars
intent_picker_bubble_view.hintent_picker_bubble_view_unittest.ccjavascript_app_modal_event_blocker_aura.hjavascript_tab_modal_dialog_view_views.ccjavascript_tab_modal_dialog_view_views.hkeyboard_access_browsertest.cc
layout
lens
location_bar
login_handler_views.cclogin_view.cclogin_view.h
media_router
menu_interactive_uitest.ccmenu_item_view_interactive_uitest.ccmenu_model_adapter_test.ccmenu_test_base.hmenu_view_drag_and_drop_test.ccmessage_box_dialog.hnetwork_profile_bubble_view.cc
omnibox
overlay
page_action
page_info
passwords
payments
permission_bubble
policy
profiles
qrcode_generator
read_later
reader_mode
relaunch_notification
renderer_context_menu
sad_tab_view.h
safe_browsing
screen_capture_notification_ui_views.cc
send_tab_to_self
session_crashed_bubble_view.ccsession_crashed_bubble_view_browsertest.ccsettings_reset_prompt_dialog.hsettings_reset_prompt_dialog_browsertest.cc
sharing
sharing_hub
side_panel
ssl_client_certificate_selector_browsertest.ccstatus_bubble_views.ccstatus_bubble_views.h
status_icons
storage
sync
tab_contents
tab_dialogs_views.htab_icon_view.htab_modal_confirm_dialog_views.htab_search_bubble_host.h
tab_sharing
tabs
task_manager_view.htask_manager_view_browsertest.cc
test
theme_copying_widget.htheme_profile_key.cc
toolbar
tooltip
touch_events_interactive_uitest_win.cc
translate
try_chrome_dialog_win
update_recommended_message_box.h
user_education
web_apps
web_dialog_view_browsertest.cc
webauthn
webid
web_applications
webauthn
webid
webui
about_ui.h
access_code_cast
app_management
app_service_internals
autofill_and_password_manager_internals
browser_command
commander
components
connectors_internals
constrained_web_dialog_ui.cc
cr_components
customize_themes
discards
download_internals
download_shelf
downloads
engagement
explore_sites_internals
extensions
favicon_source.hfavicon_source_unittest.cc
federated_learning
feed_internals
feedback
history
history_clusters
identity_internals_ui.cc
image_editor
inspect_ui.cc
internals
invalidations
managed_ui_handler.h
management
media
media_router
memory_internals_ui.ccnet_export_ui.cc
net_internals
new_tab_page
ntp
offline
omnibox
policy
predictors
prefs_internals_source.h
print_preview
profile_helper_browsertest.ccprofile_info_watcher.h
quota_internals
read_later
realbox
reset_password
sanitized_image_source_unittest.cc
settings
signin
sync_file_system_internals
sync_internals
tab_search
tab_strip
theme_source.h
web_app_internals
welcome
whats_new
window_sizer
zoom
updates
upgrade_detector
usb
video_tutorials
vr
web_applications
app_service
extensions
externally_installed_web_app_prefs.hexternally_managed_app_install_task.hexternally_managed_app_manager.hexternally_managed_app_manager_impl.hexternally_managed_app_manager_impl_unittest.ccexternally_managed_app_registration_task.hfile_handlers_permission_helper.hmanifest_update_manager.ccmanifest_update_manager.hmanifest_update_manager_browsertest.ccmanifest_update_task.hos_integration_manager.ccos_integration_manager.h
policy
preinstalled_web_app_manager.h
system_web_apps
test
url_handler_manager.hurl_handler_manager_impl_unittest.ccweb_app_database.hweb_app_database_factory.hweb_app_file_handler_manager.hweb_app_file_handler_registration_win_unittest.ccweb_app_handler_registration_utils_win_unittest.ccweb_app_install_finalizer.hweb_app_install_manager.hweb_app_install_manager_unittest.ccweb_app_install_task.hweb_app_install_task_unittest.ccweb_app_mover.ccweb_app_mover.hweb_app_notifications_interactive_uitest.ccweb_app_protocol_handler_manager.hweb_app_protocol_handler_registration_win_unittest.ccweb_app_provider.hweb_app_registrar.hweb_app_registry_update.hweb_app_shortcut_manager.hweb_app_sync_bridge.hweb_app_tab_helper.hweb_app_uninstall_job.h
webauth_interactive_uitest.cc
webauthn
webid
webshare
win
common
credential_provider
elevation_service
installer
service
services
test
base
chromedriver
data
media_router
payments
permissions
pixel
updater
utility
cloud_print/virtual_driver/win/port_monitor
components
accuracy_tips
android_autofill
autofill
content
core
browser
address_normalization_manager.ccaddress_normalization_manager.haddress_profile_save_manager.hautocomplete_history_manager.hautofill_address_util_unittest.ccautofill_download_manager.hautofill_external_delegate.ccautofill_external_delegate.hautofill_ie_toolbar_import_win.ccautofill_manager.hautofill_profile_import_process.hautofill_profile_validator.hautofill_suggestion_generator.hbrowser_autofill_manager.hbrowser_autofill_manager_unittest.cc
data_model
field_filler.hform_data_importer.hform_data_importer_unittest.cc
form_parsing
geo
logging
metrics
payments
personal_data_manager.ccpersonal_data_manager.hpersonal_data_manager_cleaner.hpersonal_data_manager_unittest.ccrandomized_encoder.htest_autofill_client.htest_browser_autofill_manager.h
ui
webdata
common
autofill_assistant
background_fetch
background_sync
blocked_content
blocklist
bookmarks
breadcrumbs
browser_sync
browser_ui
site_settings
sms
browser_watcher
browsing_data
captive_portal
cast
cast_channel
cast_streaming
cbor
cdm
certificate_transparency
client_hints
component_updater
consent_auditor
constrained_window
content_capture
content_creation
content_settings
contextual_search
crash
cronet
data_reduction_proxy
data_use_measurement
discardable_memory
dom_distiller
domain_reliability
download
drive
embedder_support
enterprise
error_page
favicon
feature_engagement
feed
feedback
find_in_page
flags_ui
fullscreen_control
gcm_driver
global_media_controls
grpc_support
guest_view
gwp_asan
history
image_fetcher
infobars
invalidation
javascript_dialogs
js_injection
keep_alive_registry
keyed_service
language
leveldb_proto
live_caption
media_message_center
media_router
memory_pressure
metrics
mirroring
nacl
network_time
no_state_prefetch
ntp_snippets
ntp_tiles
offline_items_collection
offline_pages
content
core
background
background_snapshot_controller.h
downloads
model
offline_event_logger.hoffline_page_metadata_store_test_util.hoffline_page_test_archive_publisher.hoffline_page_test_archiver.h
prefetch
snapshot_controller.h
task
omnibox
open_from_clipboard
openscreen_platform
optimization_guide
page_info
page_load_metrics
paint_preview
password_manager
content
core
browser
android_affiliation
browser_save_password_progress_logger.hbuilt_in_backend_to_android_backend_migrator.ccbuilt_in_backend_to_android_backend_migrator.hbulk_leak_check_service.hbulk_leak_check_service_unittest.cccredential_manager_impl.hcredential_manager_impl_unittest.cccredential_manager_logger.hcredential_manager_password_form_manager.hcredential_manager_pending_prevent_silent_access_task.hcredential_manager_pending_request_task.hcredential_manager_pending_request_task_unittest.cc
export
form_fetcher_impl.hform_fetcher_impl_unittest.cc
form_parsing
form_saver_impl.h
generation
get_logins_with_affiliations_request_handler.hhash_password_manager.hhsts_query_unittest.cchttp_auth_manager_impl.hhttp_credentials_cleaner.hhttp_password_store_migrator.h
import
insecure_credentials_helper.cc
leak_detection
leak_detection_delegate.hleak_detection_delegate_helper.hleak_detection_delegate_unittest.cclogin_database.ccmove_password_to_account_store_helper.hold_google_credentials_cleaner.hpassword_account_storage_settings_watcher.hpassword_autofill_manager.ccpassword_autofill_manager.hpassword_feature_manager_impl.hpassword_form_manager.hpassword_form_manager_unittest.ccpassword_form_metrics_recorder.hpassword_generation_frame_helper.hpassword_generation_manager.hpassword_manager.hpassword_manager_client_helper.hpassword_manager_features_util.ccpassword_requirements_service_unittest.ccpassword_reuse_detection_manager.hpassword_reuse_manager_impl.ccpassword_reuse_manager_impl.hpassword_save_manager_impl.hpassword_save_manager_impl_unittest.ccpassword_session_durations_metrics_recorder.ccpassword_session_durations_metrics_recorder.hpassword_store.hpassword_store_backend_migration_decorator.hpassword_store_backend_migration_decorator_unittest.ccpassword_store_proxy_backend.hpassword_store_signin_notifier_impl.hpassword_sync_util_unittest.cc
site_affiliation
statistics_table.h
sync
sync_credentials_filter.hsync_credentials_filter_unittest.cc
ui
votes_uploader.hwell_known_change_password_state.h
payments
pdf
performance_manager
decorators
execution_context
execution_context_priority
freezing
graph
metrics
performance_manager_tab_helper.h
persistence
public
render_process_user_data.hservice_worker_context_adapter.cc
test_support
v8_memory
worker_watcher.h
permissions
policy
content
core
test_support
power_scheduler
prefs
printing
proxy_config
qr_code_generator
query_tiles
reading_list
renderer_context_menu
reporting
rlz
safe_browsing
safe_search_api
scheduling_metrics
search
search_engines
search_provider_logos
security_interstitials
segmentation_platform
send_tab_to_self
services
sessions
signin
core
internal
public
site_engagement
site_isolation
speech
spellcheck
sqlite_proto
storage_monitor
subresource_filter
sync
base
driver
engine
invalidations
model
nigori
protocol
test
trusted_vault
sync_bookmarks
sync_device_info
sync_preferences
sync_sessions
sync_user_events
thin_webview
translate
ukm
undo
unified_consent
update_client
url_formatter
url_matcher
url_pattern_index
user_manager
user_prefs
value_store
variations
visitedlink
viz
client
common
host
service
display
display_embedder
frame_sinks
gl
hit_test
main
surfaces
transitions
test
web_modal
web_resource
webapps
webdata
webrtc
webxr
zoom
zucchini
content
app
browser
accessibility
aggregation_service
android
attribution_reporting
back_forward_cache_browsertest.ccback_forward_cache_internal_browsertest.cc
background_fetch
background_sync
bluetooth
broadcast_channel
browser_child_process_host_impl.hbrowser_context_impl.hbrowser_interface_broker_impl.h
browser_plugin
browser_thread_unittest.cc
browsing_data
browsing_instance.ccbrowsing_instance.h
buckets
byte_stream.cc
cache_storage
child_process_launcher.hchild_process_launcher_browsertest.ccchild_process_security_policy_impl.ccchild_process_security_policy_impl.hchild_process_security_policy_unittest.cc
client_hints
code_cache
compositor
content_index
cookie_store
direct_sockets
display_cutout
do_not_track_browsertest.cc
dom_storage
download
feature_observer.h
fenced_frame
file_system
file_system_access
find_in_page_client.hfind_request_manager.ccfind_request_manager.hfind_request_manager_browsertest.cc
font_access
generic_sensor
geolocation
gpu
hid
host_zoom_map_impl.h
idle
indexed_db
interest_group
isolated_origin_browsertest.cc
keyboard_lock
loader
locks
manifest
media
android
audible_metrics.haudio_input_stream_broker.haudio_input_stream_broker_unittest.ccaudio_loopback_stream_broker.haudio_loopback_stream_broker_unittest.ccaudio_output_stream_broker_unittest.ccaudio_stream_monitor.haudio_stream_monitor_unittest.cc
capture
flinging_renderer.hflinging_renderer_unittest.ccforwarding_audio_stream_factory.hforwarding_audio_stream_factory_unittest.ccmedia_interface_proxy.ccmedia_internals.ccmedia_keys_listener_manager_impl_browsertest.ccmedia_web_contents_observer.ccmedia_web_contents_observer.hmidi_host.h
session
system_media_controls_notifier.h
webaudio
metrics
native_io
navigation_browsertest.cc
net
notifications
payments
permissions
picture_in_picture
plugin_private_storage_helper.ccplugin_service_impl.hpointer_lock_browsertest.cc
portal
ppapi_plugin_process_host.cc
prerender
presentation
process_internals
push_messaging
quota
renderer_host
accessibility_object_lifetime_win_browsertest.ccaccessibility_tree_linkage_win_browsertest.ccblocked_scheme_navigation_browsertest.ccclipboard_host_impl_unittest.cccode_cache_host_impl.hcompositor_impl_android.cccompositor_impl_android.hcompositor_impl_android_browsertest.cccross_origin_opener_policy_status.cccross_origin_opener_policy_status.hcross_process_frame_connector.hcursor_manager.hcursor_manager_unittest.ccdelegated_frame_host.hdelegated_frame_host_client_android.hdelegated_frame_host_client_aura.hdirect_manipulation_event_handler_win.hdirect_manipulation_helper_win.hdocument_service_unittest.ccdwrite_font_lookup_table_builder_win_unittest.ccembedded_frame_sink_impl.hembedded_frame_sink_provider_impl.hframe_token_message_queue.hframe_tree.hframe_tree_node.ccframe_tree_node.hhit_test_debug_key_event_observer.h
input
isolated_app_throttle_browsertest.ccisolated_app_throttle_unittest.cclegacy_render_widget_host_win.h
media
navigation_controller_android.hnavigation_controller_impl.ccnavigation_controller_impl.hnavigation_controller_impl_browsertest.ccnavigation_entry_impl.hnavigation_request.hnavigation_request_browsertest.ccnavigation_throttle_runner.hnavigator.horigin_policy_throttle_unittest.ccpage_lifecycle_state_manager.h
pepper
private_network_access_browsertest.ccrecently_destroyed_hosts_unittest.ccrender_frame_host_android.hrender_frame_host_impl.ccrender_frame_host_impl.hrender_frame_host_impl_browsertest.ccrender_frame_host_manager.ccrender_frame_host_manager.hrender_frame_host_manager_browsertest.ccrender_frame_host_manager_unittest.ccrender_frame_metadata_provider_impl.hrender_frame_proxy_host.hrender_message_filter.hrender_process_host_browsertest.ccrender_process_host_impl.ccrender_process_host_impl.hrender_view_host_impl.hrender_view_host_unittest.ccrender_widget_host_browsertest.ccrender_widget_host_impl.hrender_widget_host_input_event_router.ccrender_widget_host_input_event_router.hrender_widget_host_input_event_router_unittest.ccrender_widget_host_unittest.ccrender_widget_host_view_android.hrender_widget_host_view_android_unittest.ccrender_widget_host_view_aura.ccrender_widget_host_view_aura.hrender_widget_host_view_aura_unittest.ccrender_widget_host_view_base.hrender_widget_host_view_browsertest.ccrender_widget_host_view_child_frame.hrender_widget_host_view_child_frame_unittest.ccrender_widget_host_view_event_handler.ccrender_widget_host_view_event_handler.hrender_widget_targeter.htext_input_manager.hvirtual_keyboard_controller_win.h
scheduler
screen_enumeration
screen_orientation
screenlock_monitor
security_exploit_browsertest.cc
serial
service_worker
shared_storage
site_instance_group_manager.hsite_instance_impl.hsite_instance_impl_unittest.ccsite_per_process_browsertest.ccsite_per_process_hit_test_browsertest.cc
sms
speculation_rules
speech
ssl
startup_task_runner_unittest.ccstorage_partition_impl.ccstorage_partition_impl.hstorage_partition_impl_map.hstorage_partition_impl_unittest.cc
tracing
ukm_internals_ui.ccurl_loader_factory_getter.h
wake_lock
web_contents
web_package
webauth
webid
webrtc
webui
worker_host
xr
zoom_browsertest.cc
child
common
gpu
public
renderer
services
shell
test
web_test
courgette
crypto
device
base
bluetooth
fido
gamepad
vr
extensions
browser
api
alarms
app_current_window_internal
audio
automation_internal
bluetooth
bluetooth_low_energy
bluetooth_socket
clipboard
declarative
declarative_net_request
declarative_webrequest
device_permissions_manager.hdevice_permissions_prompt.h
feedback_private
file_handlers
guest_view
hid
idle
management
messaging
networking_private
power
printer_provider
runtime
serial
socket
sockets_tcp
sockets_tcp_server
sockets_udp
storage
system_info
system_storage
test
usb
virtual_keyboard_private
web_request
app_window
blob_holder.hcontent_script_matching_browsertest.cccontent_script_tracker.cccontent_verifier.cccontent_verifier.hcontent_verifier_unittest.cccontent_verify_job.cccontent_verify_job_unittest.ccevent_listener_map.hevent_router.h
events
extension_action_manager.hextension_action_manager_unittest.ccextension_frame_host.hextension_function.ccextension_function.hextension_function_dispatcher.ccextension_function_dispatcher.hextension_host.hextension_host_test_helper.hextension_icon_image.ccextension_icon_image.hextension_message_filter.hextension_pref_store.hextension_prefs.hextension_protocols.ccextension_registry.hextension_service_worker_message_filter.hextension_user_script_loader.hextension_web_contents_observer.h
guest_view
lazy_background_task_queue.hlazy_background_task_queue_unittest.cclazy_context_id.hlazy_context_task_queue.hmock_extension_system.hmock_external_provider.h
mojo
policy_check.hpolicy_check_unittest.ccprocess_manager.hrenderer_startup_helper.hrenderer_startup_helper_unittest.ccsandboxed_unpacker_unittest.ccscript_executor.h
service_worker
service_worker_manager.hservice_worker_task_queue.htest_event_router_observer.htest_extensions_browser_client.h
updater
user_script_loader.huser_script_manager.hwarning_service.h
common
components
native_app_window
shell
test
gin
google_apis
gpu
command_buffer
client
common
service
abstract_texture_impl.hbuffer_manager.hcommand_buffer_direct.hcommand_buffer_service.hcommon_decoder.hcontext_group.cccontext_group.hcontext_state.hdawn_service_memory_transfer_service.ccdawn_service_memory_transfer_service.herror_state.ccexternal_semaphore.hexternal_semaphore_pool.hexternal_vk_image_backing.hexternal_vk_image_gl_representation.hexternal_vk_image_overlay_representation.hframebuffer_manager.hframebuffer_manager_unittest.ccgles2_cmd_decoder.ccgles2_cmd_decoder.hgles2_cmd_decoder_passthrough.ccgles2_cmd_decoder_passthrough.hgles2_cmd_decoder_passthrough_doers.ccgles2_cmd_decoder_unittest_base.ccgles2_cmd_decoder_unittest_base.hgles2_cmd_decoder_unittest_textures.ccgles2_query_manager.hgpu_command_buffer_memory_tracker.hgpu_state_tracer.ccgpu_state_tracer.hgpu_tracer.himage_reader_gl_owner.ccimage_reader_gl_owner.hlogger.hmemory_program_cache.hmemory_program_cache_unittest.ccmemory_tracking.hmock_texture_owner.hmocks.hnative_image_buffer.ccpassthrough_abstract_texture_impl.hprogram_manager.hprogram_manager_unittest.ccquery_manager.hraster_decoder.ccraster_decoder.hraster_decoder_unittest.ccraster_decoder_unittest_base.hrenderbuffer_manager.hsampler_manager.hscheduler.hservice_discardable_manager_unittest.ccservice_font_manager.hshader_manager.hshared_context_state.ccshared_context_state.hshared_image_backing.hshared_image_backing_d3d.ccshared_image_backing_egl_image.ccshared_image_backing_egl_image.hshared_image_backing_factory_ahardwarebuffer.ccshared_image_backing_factory_ahardwarebuffer_unittest.ccshared_image_backing_factory_egl.hshared_image_backing_factory_egl_unittest.ccshared_image_backing_factory_gl_common.hshared_image_backing_factory_gl_image.hshared_image_backing_gl_common.hshared_image_backing_gl_image.hshared_image_backing_scoped_hardware_buffer_fence_sync.ccshared_image_factory.hshared_image_representation.hshared_image_representation_d3d.hshared_image_representation_gl_texture_android.hshared_image_representation_skia_gl.hsync_point_manager.htest_shared_image_backing.cctest_shared_image_backing.htexture_base.htexture_manager.cctexture_manager.htransfer_buffer_manager.htransform_feedback_manager.hvalidating_abstract_texture_impl.hvertex_attrib_manager.hwebgpu_decoder_impl.ccwrapped_sk_image.cc
tests
config
gles2_conform_support
ipc
skia_bindings
vulkan
headless
ipc
jingle
media
audio
base
capabilities
capture
cast
cdm
ffmpeg
filters
formats
gpu
learning
midi
mojo
remoting
renderers
test
video
mojo
net
android
base
cert
cert_net
cookies
disk_cache
dns
extras
filter
http
log
network_error_logging
nqe
proxy_resolution
quic
reporting
server
socket
spdy
ssl
test
url_request
websockets
pdf
printing
remoting
base
client
codec
host
chromoting_host.hchromoting_host_unittest.ccclient_session.hclient_session_unittest.ccconfig_file_watcher.ccdesktop_and_cursor_composer_notifier.hdesktop_capturer_proxy.hdesktop_session.hdesktop_session_win.hfake_desktop_environment.hfake_host_extension.ccfake_mouse_cursor_monitor.h
file_transfer
ftl_echo_message_listener.hftl_host_change_notification_listener.hftl_signaling_connector.hheartbeat_sender.hheartbeat_sender_unittest.cchost_extension_session_manager.hhost_status_logger.hipc_desktop_environment.hipc_desktop_environment_unittest.ccipc_host_event_logger.hipc_mouse_cursor_monitor.hipc_video_frame_capturer.h
it2me
mojo_ipc
mouse_cursor_monitor_proxy.hmouse_cursor_monitor_proxy_unittest.ccmouse_shape_pump.hmouse_shape_pump_unittest.cc
native_messaging
policy_watcher.hpolicy_watcher_unittest.ccremote_input_filter.h
remote_open_url
remoting_me2me_host.ccremoting_register_support_host_request.hremoting_register_support_host_request_unittest.ccresizing_host_observer.hresizing_host_observer_unittest.cc
security_key
setup
token_validator_base_unittest.cc
webauthn
win
xmpp_register_support_host_request.h
protocol
signaling
test
rlz/lib
sandbox
services
audio
cert_verifier
data_decoder
device
battery
device_posture
device_service.h
generic_sensor
geolocation
hid
public
serial
test
usb
wake_lock
media_session
metrics
network
conditional_cache_deletion_helper.ccconditional_cache_deletion_helper.hcookie_access_delegate_impl.hcookie_manager.hcookie_manager_unittest.cc
cors
expect_ct_reporter.hhost_resolver.hhost_resolver_unittest.cchttp_cache_data_remover_unittest.cchttp_server_properties_pref_delegate.hignore_errors_cert_verifier_unittest.ccmdns_responder.ccmdns_responder.hmojo_host_resolver_impl.ccmojo_host_resolver_impl.hnet_log_exporter.hnetwork_context.hnetwork_context_unittest.ccnetwork_qualities_pref_delegate.ccnetwork_qualities_pref_delegate.hnetwork_quality_estimator_manager_unittest.ccnetwork_service.ccnetwork_service.hnetwork_service_network_delegate.hnetwork_service_proxy_delegate.hnetwork_service_proxy_delegate_unittest.cc
origin_policy
p2p
proxy_auto_config_library.ccproxy_config_service_mojo_unittest.ccproxy_lookup_request.hproxy_resolver_factory_mojo.ccproxy_resolver_factory_mojo.hproxy_resolver_factory_mojo_unittest.ccproxy_resolving_client_socket.hproxy_resolving_client_socket_factory.hproxy_resolving_socket_mojo.hproxy_service_mojo_unittest.cc
public
resource_scheduler
restricted_cookie_manager.ccrestricted_cookie_manager.hrestricted_cookie_manager_unittest.ccsocket_data_pump.hsocket_factory.hssl_config_service_mojo.hssl_config_service_mojo_unittest.cctcp_bound_socket.htcp_connected_socket.htcp_server_socket.htcp_socket_unittest.cc
test
throttling
tls_socket_factory.h
trust_tokens
udp_socket.hupload_progress_tracker.hurl_loader.ccurl_loader.hurl_loader_factory.hurl_loader_unittest.cc
web_bundle
web_transport.ccweb_transport.hwebsocket.ccwebsocket.hwebsocket_factory.h
preferences
proxy_resolver
proxy_resolver_win
resource_coordinator
service_manager
tracing
video_capture
viz
skia/ext
sql
storage/browser
third_party/blink
ui
accessibility
android
aura
aura_extra
base
color
compositor
compositor_extra
display
events
gfx
gl
lottie
message_center
native_theme
platform_window
shell_dialogs
snapshot
touch_selection
views
accessibility
accessible_pane_view.ccaccessible_pane_view.haccessible_pane_view_unittest.cc
animation
border_unittest.cc
bubble
button_drag_utils.cc
controls
animated_image_view.h
button
combobox
editable_combobox
image_view.himage_view_unittest.cclabel_unittest.cclink_unittest.cc
menu
message_box_view.ccmessage_box_view.hmessage_box_view_unittest.cc
native
prefix_selector.hprogress_bar_unittest.ccresize_area.hresize_area_unittest.ccscroll_view.ccscroll_view.hscroll_view_unittest.cc
scrollbar
separator_unittest.ccslider.hslider_unittest.ccstyled_label.hstyled_label_unittest.cc
tabbed_pane
table
textarea
textfield
tree
views_text_services_context_menu_base.h
webview
corewm
event_monitor_aura.ccevent_monitor_aura.hevent_monitor_unittest.cc
examples
focus
interaction
layout
metadata
mouse_watcher.ccmouse_watcher.hmouse_watcher_view_host.hpaint_info.hselection_controller.hselection_controller_unittest.cc
test
touchui
view.ccview.hview_targeter.hview_test_api.hview_tracker.ccview_tracker.hview_unittest.ccview_utils.ccview_utils.hviews_test_suite.h
widget
win
window
views_content_client
web_dialogs
webui
wm
url
weblayer
browser
background_download_service_factory.cc
background_fetch
background_sync
browser_context_impl.ccbrowser_context_impl.hbrowser_controls_container_view.hbrowser_controls_navigation_state_handler.hbrowser_impl.hbrowser_main_parts_impl.hbrowsing_data_remover_delegate.hcontent_browser_client_impl.hcontent_view_render_view.hcookie_manager_impl.hdownload_callback_proxy.hdownload_manager_delegate_impl.herror_page_callback_proxy.herrorpage_browsertest.cc
favicon
feature_list_creator.hfullscreen_callback_proxy.hgoogle_account_access_token_fetcher_proxy.hgoogle_accounts_callback_proxy.hinsecure_form_controller_client.hjavascript_tab_modal_dialog_manager_delegate_android.h
js_communication
navigation_browsertest.ccnavigation_controller_impl.ccnavigation_impl.hnew_tab_callback_proxy.h
no_state_prefetch
page_specific_content_settings_delegate.hpassword_manager_driver_factory.cc
persistence
persistent_download.hpopup_blocker_browsertest.ccpopup_navigation_delegate_impl.hprofile_impl.ccprofile_impl.h
safe_browsing
signin_url_loader_throttle.hsite_isolation_browsertest.cctab_callback_proxy.htab_impl.h
url_bar
web_contents_view_delegate_impl.hweblayer_variations_service_client.h
webui
public
shell
test

@ -11,6 +11,7 @@
#include "base/android/jni_weak_ref.h"
#include "base/compiler_specific.h"
#include "base/memory/raw_ptr.h"
#include "components/autofill/core/browser/autofill_client.h"
#include "components/autofill/core/browser/payments/legal_message_line.h"
#include "content/public/browser/web_contents_user_data.h"
@ -152,7 +153,7 @@ class AwAutofillClient : public autofill::AutofillClient,
const std::vector<autofill::Suggestion>& suggestions);
// The web_contents associated with this delegate.
content::WebContents* web_contents_;
raw_ptr<content::WebContents> web_contents_;
bool save_form_data_ = false;
JavaObjectWeakGlobalRef java_ref_;

@ -7,6 +7,7 @@
#include "android_webview/browser/aw_feature_list_creator.h"
#include "android_webview/browser/network_service/aw_network_change_notifier_factory.h"
#include "android_webview/common/aw_features.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/scoped_feature_list.h"
#include "content/public/browser/browser_context.h"
@ -49,8 +50,9 @@ class AwBrowserContextTest : public testing::Test {
// Create the TestBrowserThreads.
content::BrowserTaskEnvironment task_environment_;
content::TestContentClientInitializer* test_content_client_initializer_;
AwBrowserProcess* browser_process_;
raw_ptr<content::TestContentClientInitializer>
test_content_client_initializer_;
raw_ptr<AwBrowserProcess> browser_process_;
};
// Tests that constraints on trust for Symantec-issued certificates are not

@ -9,6 +9,7 @@
#include "android_webview/browser/aw_browser_process.h"
#include "base/compiler_specific.h"
#include "base/memory/raw_ptr.h"
#include "base/task/single_thread_task_executor.h"
#include "content/public/browser/browser_main_parts.h"
@ -44,7 +45,7 @@ class AwBrowserMainParts : public content::BrowserMainParts {
// Android specific UI SingleThreadTaskExecutor.
std::unique_ptr<base::SingleThreadTaskExecutor> main_task_executor_;
AwContentBrowserClient* browser_client_;
raw_ptr<AwContentBrowserClient> browser_client_;
std::unique_ptr<metrics::MemoryMetricsLogger> metrics_logger_;

@ -14,6 +14,7 @@
#include "android_webview/browser/safe_browsing/aw_safe_browsing_allowlist_manager.h"
#include "android_webview/browser/safe_browsing/aw_safe_browsing_ui_manager.h"
#include "base/feature_list.h"
#include "base/memory/raw_ptr.h"
#include "components/prefs/pref_change_registrar.h"
#include "components/prefs/pref_service.h"
#include "components/safe_browsing/android/remote_database_manager.h"
@ -93,7 +94,7 @@ class AwBrowserProcess {
// If non-null, this object holds a pref store that will be taken by
// AwBrowserProcess to create the |local_state_|.
// The AwFeatureListCreator is owned by AwMainDelegate.
AwFeatureListCreator* aw_feature_list_creator_;
raw_ptr<AwFeatureListCreator> aw_feature_list_creator_;
std::unique_ptr<PrefService> local_state_;

@ -11,6 +11,7 @@
#include <string>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/web_contents.h"
@ -261,7 +262,7 @@ class AwContentBrowserClient : public content::ContentBrowserClient {
const bool sniff_file_urls_;
// The AwFeatureListCreator is owned by AwMainDelegate.
AwFeatureListCreator* const aw_feature_list_creator_;
const raw_ptr<AwFeatureListCreator> aw_feature_list_creator_;
};
} // namespace android_webview

@ -54,6 +54,7 @@
#include "base/json/json_writer.h"
#include "base/location.h"
#include "base/memory/memory_pressure_listener.h"
#include "base/memory/raw_ptr.h"
#include "base/no_destructor.h"
#include "base/pickle.h"
#include "base/supports_user_data.h"
@ -145,11 +146,11 @@ class AwContentsUserData : public base::SupportsUserData::Data {
return NULL;
AwContentsUserData* data = static_cast<AwContentsUserData*>(
web_contents->GetUserData(kAwContentsUserDataKey));
return data ? data->contents_ : NULL;
return data ? data->contents_.get() : NULL;
}
private:
AwContents* contents_;
raw_ptr<AwContents> contents_;
};
base::subtle::Atomic32 g_instance_count = 0;

@ -13,6 +13,7 @@
#include "base/android/jni_android.h"
#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/task/current_thread.h"
#include "content/public/browser/browser_thread.h"
@ -58,7 +59,7 @@ class UserData : public base::SupportsUserData::Data {
return NULL;
UserData* data = static_cast<UserData*>(
web_contents->GetUserData(kAwContentsClientBridge));
return data ? data->contents_ : NULL;
return data ? data->contents_.get() : NULL;
}
explicit UserData(AwContentsClientBridge* ptr) : contents_(ptr) {}
@ -67,7 +68,7 @@ class UserData : public base::SupportsUserData::Data {
UserData& operator=(const UserData&) = delete;
private:
AwContentsClientBridge* contents_;
raw_ptr<AwContentsClientBridge> contents_;
};
} // namespace

@ -12,6 +12,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/bind.h"
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "content/public/browser/client_certificate_delegate.h"
#include "content/public/test/browser_task_environment.h"
@ -54,7 +55,7 @@ class AwContentsClientBridgeTest : public Test {
scoped_refptr<X509Certificate> selected_cert_;
scoped_refptr<SSLPrivateKey> selected_key_;
int cert_selected_callbacks_;
JNIEnv* env_;
raw_ptr<JNIEnv> env_;
};
class TestClientCertificateDelegate
@ -75,7 +76,7 @@ class TestClientCertificateDelegate
}
private:
AwContentsClientBridgeTest* test_;
raw_ptr<AwContentsClientBridgeTest> test_;
};
} // namespace

@ -9,6 +9,7 @@
#include "base/android/jni_android.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/task_environment.h"
#include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
@ -43,7 +44,7 @@ class AwFormDatabaseServiceTest : public Test {
// The path to the temporary directory used for the test operations.
base::test::TaskEnvironment task_environment_;
base::ScopedTempDir temp_dir_;
JNIEnv* env_;
raw_ptr<JNIEnv> env_;
std::unique_ptr<AwFormDatabaseService> service_;
};

@ -19,6 +19,7 @@
#include "base/android/jni_string.h"
#include "base/bind.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
#include "base/no_destructor.h"
#include "base/task/post_task.h"
#include "base/task/thread_pool/thread_pool_instance.h"
@ -267,7 +268,7 @@ class Bindings : public proxy_resolver::ProxyResolverV8Tracing::Bindings {
}
private:
HostResolver* host_resolver_;
raw_ptr<HostResolver> host_resolver_;
};
@ -325,7 +326,7 @@ class Job {
base::OnceClosure task_;
int net_error_ = net::ERR_ABORTED;
base::WaitableEvent event_;
AwPacProcessor* processor_;
raw_ptr<AwPacProcessor> processor_;
};
class SetProxyScriptJob : public Job {

@ -5,8 +5,9 @@
#include <string>
#include "android_webview/browser/aw_pac_processor.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "base/memory/raw_ptr.h"
#include "base/test/task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace android_webview {
@ -33,7 +34,7 @@ class AwPacProcessorTest : public testing::Test {
protected:
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
AwPacProcessor* pac_processor_ = new AwPacProcessor();
raw_ptr<AwPacProcessor> pac_processor_ = new AwPacProcessor();
};
TEST_F(AwPacProcessorTest, MakeProxyRequest) {

@ -7,6 +7,7 @@
#include "base/android/jni_weak_ref.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/raw_ptr.h"
#include "printing/page_range.h"
@ -45,7 +46,7 @@ class AwPdfExporter {
void DidExportPdf(int page_count);
JavaObjectWeakGlobalRef java_ref_;
content::WebContents* web_contents_;
raw_ptr<content::WebContents> web_contents_;
};
} // namespace android_webview

@ -11,6 +11,7 @@
#include "android_webview/browser/permission/permission_callback.h"
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "content/public/browser/permission_controller.h"
#include "content/public/browser/permission_type.h"
#include "testing/gtest/include/gtest/gtest.h"
@ -207,7 +208,7 @@ class AwPermissionManagerTest : public testing::Test {
// Use nullptr for testing. AwPermissionManagerForTesting override all methods
// that touch RenderFrameHost to work with nullptr.
content::RenderFrameHost* render_frame_host;
raw_ptr<content::RenderFrameHost> render_frame_host;
std::vector<PermissionStatus> resolved_permission_status;
std::vector<int> resolved_permission_request_id;

@ -12,6 +12,7 @@
#include "base/android/jni_weak_ref.h"
#include "base/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
@ -87,7 +88,7 @@ class AwQuotaManagerBridge
int64_t usage,
int64_t quota);
AwBrowserContext* browser_context_;
raw_ptr<AwBrowserContext> browser_context_;
JavaObjectWeakGlobalRef java_ref_;
base::WeakPtrFactory<AwQuotaManagerBridge> weak_factory_{this};

@ -7,6 +7,7 @@
#include "android_webview/common/mojom/renderer.mojom.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/supports_user_data.h"
#include "content/public/browser/render_process_host_observer.h"
@ -56,7 +57,7 @@ class AwRenderProcess : public content::RenderProcessHostObserver,
base::android::ScopedJavaGlobalRef<jobject> java_obj_;
content::RenderProcessHost* render_process_host_;
raw_ptr<content::RenderProcessHost> render_process_host_;
mojo::AssociatedRemote<mojom::Renderer> renderer_remote_;

@ -15,6 +15,7 @@
#include "android_webview/common/aw_content_client.h"
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
#include "base/memory/raw_ptr.h"
#include "base/supports_user_data.h"
#include "components/viz/common/features.h"
#include "content/public/browser/navigation_controller.h"
@ -61,11 +62,11 @@ class AwSettingsUserData : public base::SupportsUserData::Data {
return NULL;
AwSettingsUserData* data = static_cast<AwSettingsUserData*>(
web_contents->GetUserData(kAwSettingsUserDataKey));
return data ? data->settings_ : NULL;
return data ? data->settings_.get() : NULL;
}
private:
AwSettings* settings_;
raw_ptr<AwSettings> settings_;
};
AwSettings::AwSettings(JNIEnv* env,

@ -7,6 +7,8 @@
#include <string>
#include "base/memory/raw_ptr.h"
namespace content {
class WebContents;
} // namespace content
@ -54,10 +56,10 @@ class FindHelper {
bool MaybeHandleEmptySearch(const std::u16string& search_string);
void NotifyResults(int active_ordinal, int match_count, bool finished);
content::WebContents* const web_contents_;
const raw_ptr<content::WebContents> web_contents_;
// Listener results are reported to.
Listener* listener_ = nullptr;
raw_ptr<Listener> listener_ = nullptr;
// Used to check the validity of FindNext operations.
bool async_find_started_ = false;

@ -6,6 +6,7 @@
#include "android_webview/browser_jni_headers/RootBeginFrameSourceWebView_jni.h"
#include "base/auto_reset.h"
#include "base/memory/raw_ptr.h"
#include "base/no_destructor.h"
#include "base/trace_event/trace_event.h"
#include "components/power_scheduler/power_mode.h"
@ -35,7 +36,7 @@ class BeginFrameSourceWebView::BeginFrameObserver
bool WantsAnimateOnlyBeginFrames() const override { return true; }
private:
BeginFrameSourceWebView* const owner_;
const raw_ptr<BeginFrameSourceWebView> owner_;
viz::BeginFrameArgs last_used_begin_frame_args_;
};

@ -10,6 +10,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/callback.h"
#include "base/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/no_destructor.h"
#include "components/power_scheduler/power_mode_voter.h"
#include "components/viz/common/frame_sinks/begin_frame_source.h"
@ -51,15 +52,15 @@ class BeginFrameSourceWebView : public viz::ExternalBeginFrameSource {
void OnNeedsBeginFrames(bool needs_begin_frames) override;
private:
BeginFrameSourceWebView* const owner_;
const raw_ptr<BeginFrameSourceWebView> owner_;
};
void SendBeginFrame(const viz::BeginFrameArgs& args);
void OnNeedsBeginFrames(bool needs_begin_frames);
BeginFrameSourceClient bfs_client_;
viz::BeginFrameSource* observed_begin_frame_source_ = nullptr;
BeginFrameSourceWebView* parent_ = nullptr;
raw_ptr<viz::BeginFrameSource> observed_begin_frame_source_ = nullptr;
raw_ptr<BeginFrameSourceWebView> parent_ = nullptr;
std::unique_ptr<BeginFrameObserver> parent_observer_;
bool inside_begin_frame_ = false;

@ -15,6 +15,7 @@
#include "base/auto_reset.h"
#include "base/check_op.h"
#include "base/command_line.h"
#include "base/memory/raw_ptr.h"
#include "base/numerics/safe_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
@ -66,11 +67,11 @@ class BrowserViewRendererUserData : public base::SupportsUserData::Data {
BrowserViewRendererUserData* data =
static_cast<BrowserViewRendererUserData*>(
web_contents->GetUserData(kBrowserViewRendererUserDataKey));
return data ? data->bvr_ : NULL;
return data ? data->bvr_.get() : NULL;
}
private:
BrowserViewRenderer* bvr_;
raw_ptr<BrowserViewRenderer> bvr_;
};
} // namespace

@ -17,6 +17,7 @@
#include "android_webview/browser/gfx/root_frame_sink_proxy.h"
#include "base/callback.h"
#include "base/cancelable_callback.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/trace_event/trace_event.h"
#include "components/viz/common/surfaces/frame_sink_id.h"
@ -214,13 +215,13 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient,
// view renderer's state.
std::string ToString() const;
BrowserViewRendererClient* const client_;
const raw_ptr<BrowserViewRendererClient> client_;
const scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
CompositorFrameConsumer* current_compositor_frame_consumer_;
raw_ptr<CompositorFrameConsumer> current_compositor_frame_consumer_;
std::unique_ptr<RootFrameSinkProxy> root_frame_sink_proxy_;
// The current compositor that's owned by the current RVH.
content::SynchronousCompositor* compositor_;
raw_ptr<content::SynchronousCompositor> compositor_;
// The id of the most recent RVH according to RVHChanged.
viz::FrameSinkId frame_sink_id_;
// A map from compositor's per-WebView unique ID to the compositor's raw

@ -5,6 +5,7 @@
#ifndef ANDROID_WEBVIEW_BROWSER_GFX_DEFERRED_GPU_COMMAND_SERVICE_H_
#define ANDROID_WEBVIEW_BROWSER_GFX_DEFERRED_GPU_COMMAND_SERVICE_H_
#include "base/memory/raw_ptr.h"
#include "gpu/ipc/command_buffer_task_executor.h"
namespace gl {
@ -46,8 +47,8 @@ class DeferredGpuCommandService : public gpu::CommandBufferTaskExecutor {
static DeferredGpuCommandService* CreateDeferredGpuCommandService();
TaskQueueWebView* task_queue_;
GpuServiceWebView* gpu_service_;
raw_ptr<TaskQueueWebView> task_queue_;
raw_ptr<GpuServiceWebView> gpu_service_;
scoped_refptr<gl::GLShareGroup> share_group_;
};

@ -7,6 +7,7 @@
#include <map>
#include "base/memory/raw_ptr.h"
#include "base/synchronization/waitable_event.h"
#include "base/threading/thread_checker.h"
#include "components/viz/service/display/display_scheduler.h"
@ -41,7 +42,7 @@ class DisplaySchedulerWebView : public viz::DisplaySchedulerBase {
private:
bool IsFrameSinkOverlayed(viz::FrameSinkId frame_sink_id);
RootFrameSink* const root_frame_sink_;
const raw_ptr<RootFrameSink> root_frame_sink_;
// This count how many times specific sink damaged display. It's incremented
// in OnDisplayDamaged and decremented in DidSwapBuffers.
@ -49,7 +50,7 @@ class DisplaySchedulerWebView : public viz::DisplaySchedulerBase {
// Due to destruction order in viz::Display this might be not safe to use in
// destructor of this class.
OverlaysInfoProvider* const overlays_info_provider_;
const raw_ptr<OverlaysInfoProvider> overlays_info_provider_;
THREAD_CHECKER(thread_checker_);
};

@ -5,6 +5,7 @@
#ifndef ANDROID_WEBVIEW_BROWSER_GFX_DISPLAY_WEBVIEW_H_
#define ANDROID_WEBVIEW_BROWSER_GFX_DISPLAY_WEBVIEW_H_
#include "base/memory/raw_ptr.h"
#include "base/scoped_observation.h"
#include "components/viz/service/display/display.h"
#include "components/viz/service/frame_sinks/frame_sink_manager_impl.h"
@ -65,7 +66,7 @@ class DisplayWebView : public viz::Display, public viz::FrameSinkObserver {
OverlayProcessorWebView* overlay_processor_webview,
viz::FrameSinkManagerImpl* frame_sink_manager);
OverlayProcessorWebView* const overlay_processor_webview_;
const raw_ptr<OverlayProcessorWebView> overlay_processor_webview_;
base::ScopedObservation<viz::FrameSinkManagerImpl, viz::FrameSinkObserver>
frame_sink_manager_observation_{this};
};

@ -9,6 +9,7 @@
#include "android_webview/browser/gfx/child_frame.h"
#include "android_webview/browser/gfx/output_surface_provider_webview.h"
#include "base/memory/raw_ptr.h"
#include "ui/gfx/android/android_surface_control_compat.h"
#include "ui/gfx/color_space.h"
@ -87,7 +88,7 @@ class HardwareRenderer {
virtual void DrawAndSwap(const HardwareRendererDrawParams& params,
const OverlaysParams& overlays_params) = 0;
RenderThreadManager* const render_thread_manager_;
const raw_ptr<RenderThreadManager> render_thread_manager_;
typedef void* EGLContext;
EGLContext last_egl_context_;

@ -23,6 +23,7 @@
#include "android_webview/common/aw_switches.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
#include "base/notreached.h"
#include "base/trace_event/trace_event.h"
#include "components/viz/common/display/renderer_settings.h"
@ -57,7 +58,7 @@ class ContextReleaser {
~ContextReleaser() { state_->ReleaseCurrent(nullptr); }
private:
gpu::SharedContextState* const state_;
const raw_ptr<gpu::SharedContextState> state_;
};
} // namespace
@ -120,7 +121,7 @@ class HardwareRendererViz::OnViz : public viz::DisplayClient {
// Initialized in ctor and never changes, so it's safe to access from both
// threads. Can be null, if overlays are disabled.
OverlayProcessorWebView* overlay_processor_webview_ = nullptr;
raw_ptr<OverlayProcessorWebView> overlay_processor_webview_ = nullptr;
THREAD_CHECKER(viz_thread_checker_);
};

@ -10,6 +10,7 @@
#include "android_webview/browser_jni_headers/JavaBrowserViewRendererHelper_jni.h"
#include "android_webview/public/browser/draw_sw.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/raw_ptr.h"
#include "base/trace_event/trace_event.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkRefCnt.h"
@ -39,7 +40,7 @@ class JavaCanvasHolder : public SoftwareCanvasHolder {
SkCanvas* GetCanvas() override;
private:
AwPixelInfo* pixels_;
raw_ptr<AwPixelInfo> pixels_;
std::unique_ptr<SkCanvas> canvas_;
};

@ -8,6 +8,7 @@
#include <memory>
#include "android_webview/browser/gfx/aw_gl_surface.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "components/viz/common/display/renderer_settings.h"
#include "gpu/command_buffer/service/shared_context_state.h"
@ -53,7 +54,7 @@ class OutputSurfaceProviderWebView {
private:
void InitializeContext();
AwVulkanContextProvider* const vulkan_context_provider_;
const raw_ptr<AwVulkanContextProvider> vulkan_context_provider_;
// The member variables are effectively const after constructor, so it's safe
// to call accessors on different threads.
viz::RendererSettings renderer_settings_;
@ -61,7 +62,7 @@ class OutputSurfaceProviderWebView {
scoped_refptr<AwGLSurface> gl_surface_;
scoped_refptr<gpu::SharedContextState> shared_context_state_;
bool enable_vulkan_;
bool* expect_context_loss_ = nullptr;
raw_ptr<bool> expect_context_loss_ = nullptr;
};
} // namespace android_webview

@ -9,6 +9,7 @@
#include "base/android/android_hardware_buffer_compat.h"
#include "base/android/scoped_hardware_buffer_fence_sync.h"
#include "base/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/task/bind_post_task.h"
#include "base/threading/thread_checker.h"
@ -579,7 +580,7 @@ class OverlayProcessorWebView::Manager
base::Lock lock_;
// These can be accessed on any thread, but only initialized in ctor.
gpu::SharedImageManager* const shared_image_manager_;
const raw_ptr<gpu::SharedImageManager> shared_image_manager_;
std::unique_ptr<gpu::MemoryTypeTracker> memory_tracker_;
// GPU Main Thread task runner.

@ -6,6 +6,7 @@
#define ANDROID_WEBVIEW_BROWSER_GFX_OVERLAY_PROCESSOR_WEBVIEW_H_
#include "android_webview/browser/gfx/display_scheduler_webview.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/synchronization/waitable_event.h"
#include "base/threading/thread_checker.h"
@ -115,11 +116,11 @@ class OverlayProcessorWebView : public viz::OverlayProcessorSurfaceControl,
const gpu::CommandBufferId command_buffer_id_;
uint64_t sync_fence_release_ = 0;
gpu::GpuTaskSchedulerHelper* render_thread_sequence_;
raw_ptr<gpu::GpuTaskSchedulerHelper> render_thread_sequence_;
std::unique_ptr<gpu::SingleTaskSequence> gpu_thread_sequence_;
viz::DisplayResourceProvider* resource_provider_ = nullptr;
viz::FrameSinkManagerImpl* const frame_sink_manager_;
raw_ptr<viz::DisplayResourceProvider> resource_provider_ = nullptr;
const raw_ptr<viz::FrameSinkManagerImpl> frame_sink_manager_;
scoped_refptr<Manager> manager_;

@ -12,6 +12,7 @@
#include "android_webview/browser/gfx/parent_compositor_draw_constraints.h"
#include "android_webview/browser/gfx/root_frame_sink.h"
#include "base/check.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/synchronization/lock.h"
#include "base/task/single_thread_task_runner.h"
@ -79,7 +80,7 @@ class RenderThreadManager : public CompositorFrameConsumer {
~InsideHardwareReleaseReset();
private:
RenderThreadManager* render_thread_manager_;
raw_ptr<RenderThreadManager> render_thread_manager_;
};
private:
@ -115,7 +116,7 @@ class RenderThreadManager : public CompositorFrameConsumer {
// Accessed by RT thread.
std::unique_ptr<HardwareRenderer> hardware_renderer_;
bool view_tree_force_dark_state_ = false;
AwVulkanContextProvider* vulkan_context_provider_ = nullptr;
raw_ptr<AwVulkanContextProvider> vulkan_context_provider_ = nullptr;
// Accessed by both UI and RT thread.
mutable base::Lock lock_;

@ -7,6 +7,7 @@
#include "android_webview/browser/gfx/child_frame.h"
#include "android_webview/browser/gfx/display_scheduler_webview.h"
#include "android_webview/browser/gfx/viz_compositor_thread_runner_webview.h"
#include "base/memory/raw_ptr.h"
#include "base/trace_event/trace_event.h"
#include "components/viz/common/surfaces/frame_sink_id_allocator.h"
#include "components/viz/service/frame_sinks/compositor_frame_sink_support.h"
@ -76,7 +77,7 @@ class RootFrameSink::ChildCompositorFrameSink
}
private:
RootFrameSink* const owner_;
const raw_ptr<RootFrameSink> owner_;
const uint32_t layer_tree_frame_sink_id_;
const viz::FrameSinkId frame_sink_id_;
std::unique_ptr<viz::CompositorFrameSinkSupport> support_;

@ -8,6 +8,7 @@
#include <memory>
#include "base/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/threading/thread_checker.h"
#include "components/viz/common/frame_sinks/begin_frame_source.h"
#include "components/viz/common/frame_timing_details_map.h"
@ -108,7 +109,7 @@ class RootFrameSink : public base::RefCounted<RootFrameSink>,
bool needs_begin_frames_ = false;
bool needs_draw_ = false;
RootFrameSinkClient* client_;
raw_ptr<RootFrameSinkClient> client_;
THREAD_CHECKER(thread_checker_);
};

@ -8,6 +8,7 @@
#include "android_webview/browser/gfx/root_frame_sink.h"
#include "android_webview/browser/gfx/viz_compositor_thread_runner_webview.h"
#include "base/memory/raw_ptr.h"
namespace android_webview {
@ -29,7 +30,7 @@ class RootFrameSinkProxy::RootFrameSinkClientImpl : public RootFrameSinkClient {
}
private:
RootFrameSinkProxy* const owner_;
const raw_ptr<RootFrameSinkProxy> owner_;
};
// static

@ -6,6 +6,7 @@
#define ANDROID_WEBVIEW_BROWSER_GFX_ROOT_FRAME_SINK_PROXY_H_
#include "android_webview/browser/gfx/root_frame_sink.h"
#include "base/memory/raw_ptr.h"
#include "base/task/single_thread_task_runner.h"
#include "base/threading/thread_checker.h"
@ -77,10 +78,10 @@ class RootFrameSinkProxy : public viz::BeginFrameObserverBase {
const scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
const scoped_refptr<base::SingleThreadTaskRunner> viz_task_runner_;
RootFrameSinkProxyClient* const client_;
const raw_ptr<RootFrameSinkProxyClient> client_;
std::unique_ptr<RootFrameSinkClient> root_frame_sink_client_;
scoped_refptr<RootFrameSink> without_gpu_;
viz::BeginFrameSource* const begin_frame_source_;
const raw_ptr<viz::BeginFrameSource> begin_frame_source_;
bool had_input_event_ = false;
bool observing_bfs_ = false;

@ -59,7 +59,7 @@ SkiaOutputSurfaceDependencyWebView::GetGpuDriverBugWorkarounds() {
scoped_refptr<gpu::SharedContextState>
SkiaOutputSurfaceDependencyWebView::GetSharedContextState() {
return shared_context_state_;
return shared_context_state_.get();
}
gpu::raster::GrShaderCache*
@ -116,7 +116,7 @@ scoped_refptr<gl::GLSurface>
SkiaOutputSurfaceDependencyWebView::CreateGLSurface(
base::WeakPtr<gpu::ImageTransportSurfaceDelegate> stub,
gl::GLSurfaceFormat format) {
return gl_surface_;
return gl_surface_.get();
}
base::ScopedClosureRunner SkiaOutputSurfaceDependencyWebView::CacheGLSurface(

@ -6,6 +6,7 @@
#define ANDROID_WEBVIEW_BROWSER_GFX_SKIA_OUTPUT_SURFACE_DEPENDENCY_WEBVIEW_H_
#include "base/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "components/viz/service/display_embedder/skia_output_surface_dependency.h"
#include "gpu/command_buffer/service/shared_context_state.h"
#include "gpu/config/gpu_driver_bug_workarounds.h"
@ -64,12 +65,12 @@ class SkiaOutputSurfaceDependencyWebView
bool NeedsSupportForExternalStencil() override;
private:
gl::GLSurface* const gl_surface_;
AwVulkanContextProvider* vulkan_context_provider_;
TaskQueueWebView* task_queue_;
GpuServiceWebView* gpu_service_;
const raw_ptr<gl::GLSurface> gl_surface_;
raw_ptr<AwVulkanContextProvider> vulkan_context_provider_;
raw_ptr<TaskQueueWebView> task_queue_;
raw_ptr<GpuServiceWebView> gpu_service_;
gpu::GpuDriverBugWorkarounds workarounds_;
gpu::SharedContextState* const shared_context_state_;
const raw_ptr<gpu::SharedContextState> shared_context_state_;
};
} // namespace android_webview

@ -10,6 +10,7 @@
#include <memory>
#include <utility>
#include "base/memory/raw_ptr.h"
#include "gpu/ipc/single_task_sequence.h"
namespace gpu {
@ -63,8 +64,8 @@ class TaskForwardingSequence : public gpu::SingleTaskSequence {
scoped_refptr<gpu::SyncPointOrderData> sync_point_order_data);
// Raw pointer refer to the global instance.
TaskQueueWebView* const task_queue_;
gpu::SyncPointManager* const sync_point_manager_;
const raw_ptr<TaskQueueWebView> task_queue_;
const raw_ptr<gpu::SyncPointManager> sync_point_manager_;
scoped_refptr<gpu::SyncPointOrderData> sync_point_order_data_;
};

@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "android_webview/browser/gfx/test/fake_window.h"
#include "base/memory/raw_ptr.h"
#include "android_webview/browser/gfx/browser_view_renderer.h"
#include "android_webview/browser/gfx/child_frame.h"
@ -42,7 +43,7 @@ class FakeWindow::ScopedMakeCurrent {
}
private:
FakeWindow* view_root_;
raw_ptr<FakeWindow> view_root_;
};
FakeWindow::FakeWindow(BrowserViewRenderer* view,

@ -8,6 +8,7 @@
#include <map>
#include "android_webview/browser/gfx/hardware_renderer.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/sequence_checker.h"
#include "base/task/single_thread_task_runner.h"
@ -80,8 +81,8 @@ class FakeWindow {
void CheckCurrentlyOnRT();
// const so can be used on both threads.
BrowserViewRenderer* const view_;
WindowHooks* const hooks_;
const raw_ptr<BrowserViewRenderer> view_;
const raw_ptr<WindowHooks> hooks_;
const gfx::Size surface_size_;
// UI thread members.
@ -119,7 +120,7 @@ class FakeFunctor {
bool RequestInvokeGL(bool wait_for_completion);
void ReleaseOnRT(base::OnceClosure callback);
FakeWindow* window_;
raw_ptr<FakeWindow> window_;
std::unique_ptr<RenderThreadManager> render_thread_manager_;
gfx::Rect committed_location_;
};

@ -14,6 +14,7 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "base/location.h"
#include "base/memory/raw_ptr.h"
#include "base/test/task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/viz/common/quads/compositor_frame.h"
@ -44,7 +45,7 @@ class TestBrowserViewRenderer : public BrowserViewRenderer {
}
private:
RenderingTest* const rendering_test_;
const raw_ptr<RenderingTest> rendering_test_;
};
} // namespace

@ -6,6 +6,7 @@
#define ANDROID_WEBVIEW_BROWSER_GFX_VIZ_COMPOSITOR_THREAD_RUNNER_WEBVIEW_H_
#include "base/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/scoped_refptr.h"
#include "base/no_destructor.h"
#include "base/threading/thread.h"
@ -83,7 +84,7 @@ class VizCompositorThreadRunnerWebView : public viz::VizCompositorThreadRunner {
THREAD_CHECKER(viz_thread_checker_);
std::unique_ptr<viz::ServerSharedBitmapManager> server_shared_bitmap_manager_;
std::unique_ptr<viz::FrameSinkManagerImpl> frame_sink_manager_;
viz::GpuServiceImpl* gpu_service_impl_ = nullptr;
raw_ptr<viz::GpuServiceImpl> gpu_service_impl_ = nullptr;
};
} // namespace android_webview

@ -11,6 +11,7 @@
#include "android_webview/public/browser/draw_fn.h"
#include "base/containers/queue.h"
#include "base/files/scoped_file.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/scoped_refptr.h"
#include "third_party/skia/include/core/SkRefCnt.h"
#include "third_party/skia/include/gpu/vk/GrVkTypes.h"
@ -70,7 +71,7 @@ class VulkanGLInterop {
GrVkImageInfo image_info;
// Used to clean up Vulkan objects.
AwVulkanContextProvider* vk_context_provider;
raw_ptr<AwVulkanContextProvider> vk_context_provider;
};
RenderThreadManager* const render_thread_manager_;

@ -10,6 +10,7 @@
#include <string>
#include <unordered_set>
#include "base/memory/raw_ptr.h"
#include "content/public/browser/reload_type.h"
#include "content/public/browser/web_contents_observer.h"
#include "third_party/blink/public/mojom/favicon/favicon_url.mojom-forward.h"
@ -64,7 +65,7 @@ class IconHelper : public content::WebContentsObserver {
bool WasUnableToDownloadFavicon(const GURL& icon_url) const;
void ClearUnableToDownloadFavicons();
Listener* listener_;
raw_ptr<Listener> listener_;
using MissingFaviconURLHash = size_t;
std::unordered_set<MissingFaviconURLHash> missing_favicon_urls_;

@ -7,6 +7,7 @@
#include "base/android/jni_weak_ref.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/raw_ptr.h"
namespace js_injection {
class WebMessageReplyProxy;
@ -29,7 +30,7 @@ class JsReplyProxy {
const base::android::JavaParamRef<jstring>& message);
private:
js_injection::WebMessageReplyProxy* reply_proxy_;
raw_ptr<js_injection::WebMessageReplyProxy> reply_proxy_;
base::android::ScopedJavaGlobalRef<jobject> java_ref_;
};

@ -4,6 +4,7 @@
#include "android_webview/browser/lifecycle/aw_contents_lifecycle_notifier.h"
#include "base/memory/raw_ptr.h"
#include "base/task/post_task.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/test/browser_task_environment.h"
@ -41,7 +42,7 @@ class TestOnLoseForegroundCallback {
private:
bool called_ = false;
const TestWebViewAppObserver* other_;
raw_ptr<const TestWebViewAppObserver> other_;
};
class TestAwContentsLifecycleNotifier : public AwContentsLifecycleNotifier {

@ -5,6 +5,7 @@
#ifndef ANDROID_WEBVIEW_BROWSER_METRICS_AW_COMPONENT_METRICS_PROVIDER_DELEGATE_H_
#define ANDROID_WEBVIEW_BROWSER_METRICS_AW_COMPONENT_METRICS_PROVIDER_DELEGATE_H_
#include "base/memory/raw_ptr.h"
#include "components/metrics/component_metrics_provider.h"
namespace component_updater {
@ -29,7 +30,7 @@ class AwComponentMetricsProviderDelegate
std::vector<component_updater::ComponentInfo> GetComponents() override;
private:
AwMetricsServiceClient* client_;
raw_ptr<AwMetricsServiceClient> client_;
};
} // namespace android_webview

@ -5,6 +5,7 @@
#include "android_webview/browser/metrics/visibility_metrics_logger.h"
#include "android_webview/common/aw_features.h"
#include "base/memory/raw_ptr.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
@ -50,7 +51,7 @@ class TestClient : public VisibilityMetricsLogger::Client {
}
private:
VisibilityMetricsLogger* logger_;
raw_ptr<VisibilityMetricsLogger> logger_;
VisibilityMetricsLogger::VisibilityInfo visibility_info_;
};

@ -5,6 +5,7 @@
#ifndef ANDROID_WEBVIEW_BROWSER_METRICS_VISIBILITY_METRICS_PROVIDER_H_
#define ANDROID_WEBVIEW_BROWSER_METRICS_VISIBILITY_METRICS_PROVIDER_H_
#include "base/memory/raw_ptr.h"
#include "components/metrics/metrics_provider.h"
namespace android_webview {
@ -24,7 +25,7 @@ class VisibilityMetricsProvider : public metrics::MetricsProvider {
metrics::ChromeUserMetricsExtension* uma_proto) override;
private:
VisibilityMetricsLogger* logger_;
raw_ptr<VisibilityMetricsLogger> logger_;
};
} // namespace android_webview

@ -5,6 +5,7 @@
#ifndef ANDROID_WEBVIEW_BROWSER_NETWORK_SERVICE_AW_NETWORK_CHANGE_NOTIFIER_H_
#define ANDROID_WEBVIEW_BROWSER_NETWORK_SERVICE_AW_NETWORK_CHANGE_NOTIFIER_H_
#include "base/memory/raw_ptr.h"
#include "net/android/network_change_notifier_delegate_android.h"
#include "net/base/network_change_notifier.h"
@ -58,7 +59,7 @@ class AwNetworkChangeNotifier
static NetworkChangeCalculatorParams DefaultNetworkChangeCalculatorParams();
net::NetworkChangeNotifierDelegateAndroid* const delegate_;
const raw_ptr<net::NetworkChangeNotifierDelegateAndroid> delegate_;
};
} // namespace android_webview

@ -8,6 +8,7 @@
#include <string>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "third_party/blink/public/common/loader/url_loader_throttle.h"
#include "url/origin.h"
@ -44,7 +45,7 @@ class AwURLLoaderThrottle : public blink::URLLoaderThrottle {
void AddExtraHeadersIfNeeded(const GURL& url,
net::HttpRequestHeaders* headers);
AwResourceContext* aw_resource_context_;
raw_ptr<AwResourceContext> aw_resource_context_;
std::vector<std::string> added_headers_;
url::Origin original_origin_;
};

@ -11,6 +11,7 @@
#include <memory>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "content/public/browser/web_contents_observer.h"
#include "url/gurl.h"
@ -68,7 +69,7 @@ class PermissionRequestHandler : public content::WebContentsObserver {
// Return true if |origin| were preauthorized to access |resources|.
bool Preauthorized(const GURL& origin, int64_t resources);
PermissionRequestHandlerClient* client_;
raw_ptr<PermissionRequestHandlerClient> client_;
// A list of ongoing requests.
std::vector<base::WeakPtr<AwPermissionRequest>> requests_;

@ -12,6 +12,7 @@
#include "android_webview/browser/permission/permission_request_handler_client.h"
#include "base/bind.h"
#include "base/callback.h"
#include "base/memory/raw_ptr.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace android_webview {
@ -93,7 +94,7 @@ class TestPermissionRequestHandlerClient
private:
base::android::ScopedJavaLocalRef<jobject> java_request_;
AwPermissionRequest* request_;
raw_ptr<AwPermissionRequest> request_;
Permission requested_permission_;
Permission canceled_permission_;
};

@ -5,6 +5,7 @@
#ifndef ANDROID_WEBVIEW_BROWSER_RENDERER_HOST_AW_RENDER_VIEW_HOST_EXT_H_
#define ANDROID_WEBVIEW_BROWSER_RENDERER_HOST_AW_RENDER_VIEW_HOST_EXT_H_
#include "base/memory/raw_ptr.h"
#include "content/public/browser/web_contents_observer.h"
#include "android_webview/common/mojom/frame.mojom.h"
@ -105,7 +106,7 @@ class AwRenderViewHostExt : public content::WebContentsObserver,
mojom::LocalMainFrame* GetLocalMainFrameRemote();
AwRenderViewHostExtClient* client_;
raw_ptr<AwRenderViewHostExtClient> client_;
// Authoritative copy of hit test data on the browser side. This is updated
// as a result of DoHitTest called explicitly or when the FocusedNodeChanged

@ -7,6 +7,7 @@
#include <string>
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "components/safe_browsing/core/browser/url_checker_delegate.h"
#include "content/public/browser/web_contents.h"
@ -88,7 +89,7 @@ class AwUrlCheckerDelegateImpl : public safe_browsing::UrlCheckerDelegate {
scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager> database_manager_;
scoped_refptr<AwSafeBrowsingUIManager> ui_manager_;
safe_browsing::SBThreatTypeSet threat_types_;
AwSafeBrowsingAllowlistManager* allowlist_manager_;
raw_ptr<AwSafeBrowsingAllowlistManager> allowlist_manager_;
};
} // namespace android_webview

@ -9,6 +9,7 @@
#include <vector>
#include "base/feature_list.h"
#include "base/memory/raw_ptr.h"
namespace base {
class CommandLine;
@ -34,7 +35,7 @@ class ScopedAddFeatureFlags {
private:
void AddFeatureIfNotSet(const base::Feature& feature, bool enable);
base::CommandLine* const cl_;
const raw_ptr<base::CommandLine> cl_;
std::vector<std::string> enabled_features_;
std::vector<std::string> disabled_features_;
};

@ -19,6 +19,7 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/json/json_reader.h"
#include "base/memory/raw_ptr.h"
#include "base/test/android/url_utils.h"
#include "base/test/task_environment.h"
#include "base/values.h"
@ -333,7 +334,7 @@ class TestAwComponentUpdateService : public AwComponentUpdateService {
}
private:
MockInstallerPolicy* mock_policy_;
raw_ptr<MockInstallerPolicy> mock_policy_;
};
class AwComponentUpdateServiceTest : public testing::Test {

@ -5,6 +5,7 @@
#ifndef ANDROID_WEBVIEW_NONEMBEDDED_COMPONENT_UPDATER_AW_COMPONENT_UPDATER_CONFIGURATOR_H_
#define ANDROID_WEBVIEW_NONEMBEDDED_COMPONENT_UPDATER_AW_COMPONENT_UPDATER_CONFIGURATOR_H_
#include "base/memory/raw_ptr.h"
#include "base/memory/scoped_refptr.h"
#include "base/version.h"
#include "components/component_updater/configurator_impl.h"
@ -66,7 +67,8 @@ class AwComponentUpdaterConfigurator : public update_client::Configurator {
private:
component_updater::ConfiguratorImpl configurator_impl_;
PrefService* pref_service_; // This member is not owned by this class.
raw_ptr<PrefService>
pref_service_; // This member is not owned by this class.
scoped_refptr<update_client::NetworkFetcherFactory> network_fetcher_factory_;
scoped_refptr<update_client::CrxDownloaderFactory> crx_downloader_factory_;
scoped_refptr<update_client::UnzipperFactory> unzip_factory_;

@ -7,6 +7,7 @@
#include "android_webview/public/browser/draw_fn.h"
#include "base/containers/flat_map.h"
#include "base/memory/raw_ptr.h"
#include "base/no_destructor.h"
#include "base/synchronization/lock.h"
#include "ui/gfx/android/android_surface_control_compat.h"
@ -30,8 +31,8 @@ struct FunctorData {
FunctorData& operator=(const FunctorData&) = delete;
int functor = 0;
void* data = nullptr;
AwDrawFnFunctorCallbacks* functor_callbacks = nullptr;
raw_ptr<void> data = nullptr;
raw_ptr<AwDrawFnFunctorCallbacks> functor_callbacks = nullptr;
bool released_by_functor = false;
bool released_by_manager = false;
scoped_refptr<gfx::SurfaceControl::Surface> overlay_surface;

@ -13,6 +13,7 @@
#include "android_webview/test/shell/src/draw_fn/allocator.h"
#include "base/android/jni_array.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
#include "base/native_library.h"
#include "base/threading/thread_restrictions.h"
#include "gpu/vulkan/init/gr_vk_memory_allocator_impl.h"
@ -416,7 +417,7 @@ class VkFunctorDrawHandler : public SkDrawable::GpuDrawHandler {
}
private:
OverlaysManager* overlays_manager_;
raw_ptr<OverlaysManager> overlays_manager_;
int functor_;
int scroll_x_;
int scroll_y_;
@ -456,7 +457,7 @@ class FunctorDrawable : public SkDrawable {
}
private:
OverlaysManager* overlays_manager_;
raw_ptr<OverlaysManager> overlays_manager_;
int functor_;
int scroll_x_;
int scroll_y_;

@ -10,6 +10,7 @@
#include "android_webview/test/shell/src/draw_fn/overlays_manager.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/raw_ptr.h"
namespace draw_fn {
@ -44,7 +45,7 @@ class ContextManager {
virtual void CurrentFunctorChanged() = 0;
base::android::ScopedJavaGlobalRef<jobject> java_surface_;
ANativeWindow* native_window_ = nullptr;
raw_ptr<ANativeWindow> native_window_ = nullptr;
int current_functor_ = 0;

@ -10,6 +10,7 @@
#include "android_webview/test/shell/src/draw_fn/allocator.h"
#include "base/android/jni_array.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
namespace draw_fn {
namespace {
@ -65,7 +66,7 @@ class OverlaysManager::ScopedCurrentFunctorCall {
}
FunctorData& functor_;
ANativeWindow* native_window_;
raw_ptr<ANativeWindow> native_window_;
};
template <typename T>

@ -9,6 +9,7 @@
#include <jni.h>
#include "base/android/scoped_java_ref.h"
#include "base/memory/raw_ptr.h"
#include "ui/gfx/android/android_surface_control_compat.h"
struct AwDrawFn_DrawGLParams;
@ -45,7 +46,7 @@ class OverlaysManager {
private:
base::android::ScopedJavaGlobalRef<jobject> java_surface_;
ANativeWindow* native_window_ = nullptr;
raw_ptr<ANativeWindow> native_window_ = nullptr;
};
} // namespace draw_fn

@ -8,6 +8,7 @@
#include <string>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "base/observer_list.h"
#include "base/scoped_observation.h"
#include "components/keyed_service/core/keyed_service.h"
@ -79,7 +80,7 @@ class AppLifetimeMonitor : public KeyedService,
void NotifyAppDeactivated(const std::string& app_id);
void NotifyAppStop(const std::string& app_id);
content::BrowserContext* context_;
raw_ptr<content::BrowserContext> context_;
base::ObserverList<Observer>::Unchecked observers_;
base::ScopedObservation<extensions::ExtensionHostRegistry,
extensions::ExtensionHostRegistry::Observer>

@ -9,6 +9,7 @@
#include <vector>
#include "apps/app_lifetime_monitor.h"
#include "base/memory/raw_ptr.h"
#include "components/keyed_service/core/keyed_service.h"
#include "extensions/browser/app_window/app_window_registry.h"
@ -70,7 +71,7 @@ class AppRestoreService : public KeyedService,
void StartObservingAppLifetime();
void StopObservingAppLifetime();
content::BrowserContext* context_;
raw_ptr<content::BrowserContext> context_;
};
} // namespace apps

@ -13,6 +13,7 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@ -346,7 +347,7 @@ class PlatformAppPathLauncher
}
// The browser context the app should be run in.
content::BrowserContext* context_;
raw_ptr<content::BrowserContext> context_;
// The id of the extension providing the app. A pointer to the extension is
// not kept as the extension may be unloaded and deleted during the course of
// the launch.

@ -14,6 +14,7 @@
#include "apps/saved_files_service_factory.h"
#include "base/json/values_util.h"
#include "base/memory/raw_ptr.h"
#include "build/chromeos_buildflags.h"
#include "content/public/browser/browser_context.h"
#include "extensions/browser/api/file_system/saved_file_entry.h"
@ -166,7 +167,7 @@ class SavedFilesService::SavedFiles {
void LoadSavedFileEntriesFromPreferences();
content::BrowserContext* context_;
raw_ptr<content::BrowserContext> context_;
const std::string extension_id_;
// Contains all file entries that have been registered, keyed by ID.

@ -13,6 +13,7 @@
#include "base/files/file_path.h"
#include "base/gtest_prod_util.h"
#include "base/memory/raw_ptr.h"
#include "base/scoped_observation.h"
#include "components/keyed_service/core/keyed_service.h"
#include "extensions/browser/api/file_system/saved_files_service_interface.h"
@ -104,7 +105,7 @@ class SavedFilesService : public extensions::SavedFilesServiceInterface,
std::map<std::string, std::unique_ptr<SavedFiles>>
extension_id_to_saved_files_;
content::BrowserContext* context_;
raw_ptr<content::BrowserContext> context_;
base::ScopedObservation<extensions::ExtensionHostRegistry,
extensions::ExtensionHostRegistry::Observer>

@ -6,6 +6,7 @@
#include "apps/saved_files_service.h"
#include "base/files/file_path.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/test/values_test_util.h"
#include "base/values.h"
@ -82,8 +83,8 @@ class SavedFilesServiceUnitTest : public testing::Test {
}
extensions::TestExtensionEnvironment env_;
const extensions::Extension* extension_;
SavedFilesService* service_;
raw_ptr<const extensions::Extension> extension_;
raw_ptr<SavedFilesService> service_;
base::FilePath path_;
};

@ -9,6 +9,7 @@
#include <string>
#include "base/compiler_specific.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "extensions/browser/app_window/app_window_registry.h"
@ -56,11 +57,11 @@ class AppWindowWaiter : public extensions::AppWindowRegistry::Observer {
WAIT_FOR_ACTIVATED,
};
extensions::AppWindowRegistry* const registry_;
const raw_ptr<extensions::AppWindowRegistry> registry_;
const std::string app_id_;
std::unique_ptr<base::RunLoop> run_loop_;
WaitType wait_type_ = WAIT_FOR_NONE;
extensions::AppWindow* window_ = nullptr;
raw_ptr<extensions::AppWindow> window_ = nullptr;
};
} // namespace apps

@ -5,6 +5,7 @@
#ifndef APPS_UI_VIEWS_APP_WINDOW_FRAME_VIEW_H_
#define APPS_UI_VIEWS_APP_WINDOW_FRAME_VIEW_H_
#include "base/memory/raw_ptr.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/base/metadata/metadata_header_macros.h"
#include "ui/gfx/geometry/rect.h"
@ -83,15 +84,15 @@ class AppWindowFrameView : public views::NonClientFrameView {
// Return the current frame color based on the active state of the window.
SkColor CurrentFrameColor();
views::Widget* widget_;
extensions::NativeAppWindow* window_;
raw_ptr<views::Widget> widget_;
raw_ptr<extensions::NativeAppWindow> window_;
bool draw_frame_;
SkColor active_frame_color_;
SkColor inactive_frame_color_;
views::ImageButton* close_button_ = nullptr;
views::ImageButton* maximize_button_ = nullptr;
views::ImageButton* restore_button_ = nullptr;
views::ImageButton* minimize_button_ = nullptr;
raw_ptr<views::ImageButton> close_button_ = nullptr;
raw_ptr<views::ImageButton> maximize_button_ = nullptr;
raw_ptr<views::ImageButton> restore_button_ = nullptr;
raw_ptr<views::ImageButton> minimize_button_ = nullptr;
// Allow resize for clicks this many pixels inside the bounds.
int resize_inside_bounds_size_ = 5;

@ -11,6 +11,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/dcheck_is_on.h"
#include "base/memory/raw_ptr.h"
#include "base/task/sequence_manager/sequence_manager.h"
#include "base/task/sequence_manager/task_queue.h"
#include "base/task/single_thread_task_runner.h"
@ -81,7 +82,7 @@ class BASE_EXPORT JavaHandlerThread {
std::unique_ptr<sequence_manager::SequenceManager> sequence_manager;
scoped_refptr<sequence_manager::TaskQueue> default_task_queue;
MessagePumpForUI* pump = nullptr;
raw_ptr<MessagePumpForUI> pump = nullptr;
};
State* state() const { return state_.get(); }

@ -13,6 +13,7 @@
#include "base/base_export.h"
#include "base/compiler_specific.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
#include "build/build_config.h"
// Project-specific macros used by the header files generated by
@ -95,7 +96,7 @@ struct BASE_EXPORT JniJavaCallContextUnchecked {
uintptr_t sp;
uintptr_t pc;
JNIEnv* env1;
raw_ptr<JNIEnv> env1;
jmethodID method_id;
};

@ -7,6 +7,7 @@
#include "base/base_export.h"
#include "base/files/scoped_file.h"
#include "base/memory/raw_ptr.h"
extern "C" typedef struct AHardwareBuffer AHardwareBuffer;
@ -82,7 +83,7 @@ class BASE_EXPORT ScopedHardwareBufferHandle {
// acquire a new reference.
explicit ScopedHardwareBufferHandle(AHardwareBuffer* buffer);
AHardwareBuffer* buffer_ = nullptr;
raw_ptr<AHardwareBuffer> buffer_ = nullptr;
};
} // namespace android

@ -13,6 +13,7 @@
#include "base/base_export.h"
#include "base/check_op.h"
#include "base/memory/raw_ptr.h"
namespace base {
namespace android {
@ -33,7 +34,7 @@ class BASE_EXPORT ScopedJavaLocalFrame {
private:
// This class is only good for use on the thread it was created on so
// it's safe to cache the non-threadsafe JNIEnv* inside this object.
JNIEnv* env_;
raw_ptr<JNIEnv> env_;
};
// Forward declare the generic java reference template class.
@ -281,7 +282,7 @@ class ScopedJavaLocalRef : public JavaRef<T> {
private:
// This class is only good for use on the thread it was created on so
// it's safe to cache the non-threadsafe JNIEnv* inside this object.
JNIEnv* env_ = nullptr;
raw_ptr<JNIEnv> env_ = nullptr;
// Prevent ScopedJavaLocalRef(JNIEnv*, T obj) from being used to take
// ownership of a JavaParamRef's underlying object - parameters are not
@ -494,7 +495,7 @@ class JavaObjectArrayReader {
private:
iterator(const JavaObjectArrayReader* reader, jsize i)
: reader_(reader), i_(i) {}
const JavaObjectArrayReader* reader_;
raw_ptr<const JavaObjectArrayReader<T>> reader_;
jsize i_;
friend JavaObjectArrayReader;

@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/test/bind.h"
#include "base/test/gtest_util.h"
#include "testing/gmock/include/gmock/gmock.h"
@ -63,7 +64,7 @@ class DestructionIndicator {
void DoNothing(Args...) {}
private:
bool* destructed_;
raw_ptr<bool> destructed_;
};
TEST(BarrierCallbackTest, ReleasesDoneCallbackWhenDone) {

@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/test/bind.h"
#include "base/test/gtest_util.h"
#include "testing/gtest/include/gtest/gtest.h"
@ -52,7 +53,7 @@ class DestructionIndicator {
void DoNothing() {}
private:
bool* destructed_;
raw_ptr<bool> destructed_;
};
TEST(BarrierClosureTest, ReleasesDoneClosureWhenDone) {

@ -11,6 +11,7 @@
#include "base/base_export.h"
#include "base/containers/span.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_piece.h"
namespace base {
@ -136,8 +137,8 @@ class BASE_EXPORT BigEndianWriter {
template<typename T>
bool Write(T v);
char* ptr_;
char* end_;
raw_ptr<char> ptr_;
raw_ptr<char> end_;
};
} // namespace base

@ -110,10 +110,10 @@ struct DerivedCopyMoveCounter {
assigns_(assigns),
move_constructs_(move_constructs),
move_assigns_(move_assigns) {}
int* copies_;
int* assigns_;
int* move_constructs_;
int* move_assigns_;
raw_ptr<int> copies_;
raw_ptr<int> assigns_;
raw_ptr<int> move_constructs_;
raw_ptr<int> move_assigns_;
};
// Used for probing the number of copies and moves in an argument.
@ -189,10 +189,10 @@ class CopyMoveCounter {
}
private:
int* copies_;
int* assigns_;
int* move_constructs_;
int* move_assigns_;
raw_ptr<int> copies_;
raw_ptr<int> assigns_;
raw_ptr<int> move_constructs_;
raw_ptr<int> move_assigns_;
};
// Used for probing the number of copies in an argument. The instance is a
@ -244,7 +244,7 @@ class DeleteCounter {
void VoidMethod0() {}
private:
int* deletes_;
raw_ptr<int> deletes_;
};
template <typename T>
@ -341,8 +341,8 @@ class BindTest : public ::testing::Test {
protected:
StrictMock<NoRef> no_ref_;
StrictMock<HasRef> has_ref_;
const HasRef* const_has_ref_ptr_;
const NoRef* const_no_ref_ptr_;
raw_ptr<const HasRef> const_has_ref_ptr_;
raw_ptr<const NoRef> const_no_ref_ptr_;
StrictMock<NoRef> static_func_mock_;
// Used by the static functions to perform expectations.
@ -464,7 +464,7 @@ TEST_F(BindTest, IgnoreResultForRepeating) {
non_void_const_method_cb.Run();
WeakPtrFactory<NoRef> weak_factory(&no_ref_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_.get());
RepeatingClosure non_void_weak_method_cb =
BindRepeating(IgnoreResult(&NoRef::IntMethod0),
@ -501,7 +501,7 @@ TEST_F(BindTest, IgnoreResultForOnce) {
std::move(non_void_const_method_cb).Run();
WeakPtrFactory<NoRef> weak_factory(&no_ref_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_.get());
OnceClosure non_void_weak_method_cb =
BindOnce(IgnoreResult(&NoRef::IntMethod0),
@ -707,7 +707,7 @@ TEST_F(BindTest, WeakPtrForRepeating) {
EXPECT_CALL(no_ref_, VoidConstMethod0()).Times(2);
WeakPtrFactory<NoRef> weak_factory(&no_ref_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_.get());
RepeatingClosure method_cb =
BindRepeating(&NoRef::VoidMethod0, weak_factory.GetWeakPtr());
@ -738,7 +738,7 @@ TEST_F(BindTest, WeakPtrForRepeating) {
TEST_F(BindTest, WeakPtrForOnce) {
WeakPtrFactory<NoRef> weak_factory(&no_ref_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_);
WeakPtrFactory<const NoRef> const_weak_factory(const_no_ref_ptr_.get());
OnceClosure method_cb =
BindOnce(&NoRef::VoidMethod0, weak_factory.GetWeakPtr());

@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
@ -79,7 +80,7 @@ class Adder {
private:
bool added_ = false;
int total_ = 0;
RepeatingClosureList* cb_reg_;
raw_ptr<RepeatingClosureList> cb_reg_;
CallbackListSubscription subscription_;
};

@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/callback_internal.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/notreached.h"
#include "base/strings/string_number_conversions.h"
@ -749,7 +750,7 @@ class CallbackOwner : public base::RefCounted<CallbackOwner> {
}
RepeatingClosure callback_;
bool* deleted_;
raw_ptr<bool> deleted_;
};
TEST_F(CallbackTest, CallbackHasLastRefOnContainingObject) {

@ -11,6 +11,7 @@
#include <utility>
#include "base/check_op.h"
#include "base/memory/raw_ptr.h"
namespace base {
@ -142,7 +143,7 @@ class EnumSet {
return i;
}
const EnumBitSet* enums_;
raw_ptr<const EnumBitSet> enums_;
size_t i_;
};

@ -16,6 +16,7 @@
#include "base/check_op.h"
#include "base/containers/flat_set.h"
#include "base/memory/raw_ptr.h"
#include "base/notreached.h"
#include "base/sequence_checker.h"
@ -205,7 +206,7 @@ class IDMap final {
++iter_;
}
IDMap<V, K>* map_;
raw_ptr<IDMap<V, K>> map_;
typename HashTable::const_iterator iter_;
};

@ -14,6 +14,7 @@
#include <utility>
#include "base/check_op.h"
#include "base/memory/raw_ptr.h"
namespace {
constexpr size_t kUsingFullMapSentinel = std::numeric_limits<size_t>::max();
@ -224,7 +225,7 @@ class small_map {
}
inline value_type* operator->() const {
return array_iter_ ? array_iter_ : map_iter_.operator->();
return array_iter_ ? array_iter_.get() : map_iter_.operator->();
}
inline value_type& operator*() const {
@ -253,7 +254,7 @@ class small_map {
inline explicit iterator(const typename NormalMap::iterator& init)
: array_iter_(nullptr), map_iter_(init) {}
value_type* array_iter_;
raw_ptr<value_type> array_iter_;
typename NormalMap::iterator map_iter_;
};
@ -304,7 +305,7 @@ class small_map {
}
inline const value_type* operator->() const {
return array_iter_ ? array_iter_ : map_iter_.operator->();
return array_iter_ ? array_iter_.get() : map_iter_.operator->();
}
inline const value_type& operator*() const {
@ -330,7 +331,7 @@ class small_map {
const typename NormalMap::const_iterator& init)
: array_iter_(nullptr), map_iter_(init) {}
const value_type* array_iter_;
raw_ptr<const value_type> array_iter_;
typename NormalMap::const_iterator map_iter_;
};

@ -9,6 +9,7 @@
#include <algorithm>
#include "base/memory/aligned_memory.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
@ -30,7 +31,7 @@ class Dummy : public RefCounted<Dummy> {
--*alive_;
}
int* const alive_;
const raw_ptr<int> alive_;
};
} // namespace

@ -7,6 +7,8 @@
#include <memory>
#include "base/memory/raw_ptr.h"
namespace base {
// This transparent comparator allows to lookup by raw pointer in
@ -65,7 +67,7 @@ struct UniquePtrMatcher {
}
private:
T* const t_;
const raw_ptr<T> t_;
};
template <class T, class Deleter = std::default_delete<T>>

@ -16,6 +16,7 @@
#include "base/files/memory_mapped_file.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/read_only_shared_memory_region.h"
#include "base/pending_task.h"
#include "base/process/process.h"
@ -153,7 +154,7 @@ class SimpleActivityThread : public SimpleThread {
}
private:
const void* source_;
raw_ptr<const void> source_;
Activity::Type activity_;
ActivityData data_;

@ -380,13 +380,13 @@ bool ActivityUserData::CreateSnapshot(Snapshot* output_snapshot) const {
switch (entry.second.type) {
case RAW_VALUE:
case STRING_VALUE:
value.long_value_ =
std::string(reinterpret_cast<char*>(entry.second.memory), size);
value.long_value_ = std::string(
reinterpret_cast<char*>(entry.second.memory.get()), size);
break;
case RAW_VALUE_REFERENCE:
case STRING_VALUE_REFERENCE: {
ReferenceRecord* ref =
reinterpret_cast<ReferenceRecord*>(entry.second.memory);
reinterpret_cast<ReferenceRecord*>(entry.second.memory.get());
value.ref_value_ = StringPiece(
reinterpret_cast<char*>(static_cast<uintptr_t>(ref->address)),
static_cast<size_t>(ref->size));
@ -394,13 +394,13 @@ bool ActivityUserData::CreateSnapshot(Snapshot* output_snapshot) const {
case BOOL_VALUE:
case CHAR_VALUE:
value.short_value_ =
reinterpret_cast<std::atomic<char>*>(entry.second.memory)
reinterpret_cast<std::atomic<char>*>(entry.second.memory.get())
->load(std::memory_order_relaxed);
break;
case SIGNED_VALUE:
case UNSIGNED_VALUE:
value.short_value_ =
reinterpret_cast<std::atomic<uint64_t>*>(entry.second.memory)
reinterpret_cast<std::atomic<uint64_t>*>(entry.second.memory.get())
->load(std::memory_order_relaxed);
break;
case END_OF_VALUES: // Included for completeness purposes.
@ -503,7 +503,7 @@ void* ActivityUserData::Set(StringPiece name,
}
// Allocate a chunk of memory.
FieldHeader* header = reinterpret_cast<FieldHeader*>(memory_);
FieldHeader* header = reinterpret_cast<FieldHeader*>(memory_.get());
memory_ += full_size;
available_ -= full_size;
@ -563,7 +563,7 @@ void ActivityUserData::ImportExistingData() const {
return;
while (available_ > sizeof(FieldHeader)) {
FieldHeader* header = reinterpret_cast<FieldHeader*>(memory_);
FieldHeader* header = reinterpret_cast<FieldHeader*>(memory_.get());
ValueType type =
static_cast<ValueType>(header->type.load(std::memory_order_acquire));
if (type == END_OF_VALUES)

@ -22,6 +22,7 @@
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
#include "base/location.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/shared_memory_mapping.h"
#include "base/metrics/persistent_memory_allocator.h"
#include "base/process/process_handle.h"
@ -224,7 +225,7 @@ class BASE_EXPORT ActivityTrackerMemoryAllocator {
size_t cache_used() const { return cache_used_; }
private:
PersistentMemoryAllocator* const allocator_;
const raw_ptr<PersistentMemoryAllocator> allocator_;
const uint32_t object_type_;
const uint32_t object_free_type_;
const size_t object_size_;
@ -536,8 +537,9 @@ class BASE_EXPORT ActivityUserData {
StringPiece name; // The "key" of the record.
ValueType type; // The type of the value.
void* memory; // Where the "value" is held.
std::atomic<uint16_t>* size_ptr; // Address of the actual size of value.
raw_ptr<void> memory; // Where the "value" is held.
raw_ptr<std::atomic<uint16_t>>
size_ptr; // Address of the actual size of value.
size_t extent; // The total storage of the value,
}; // typically rounded up for alignment.
@ -561,11 +563,11 @@ class BASE_EXPORT ActivityUserData {
// Information about the memory block in which new data can be stored. These
// are "mutable" because they change even on "const" objects that are just
// skipping already set values.
mutable char* memory_;
mutable raw_ptr<char> memory_;
mutable size_t available_;
// A pointer to the memory header for this instance.
MemoryHeader* const header_;
const raw_ptr<MemoryHeader> header_;
// These hold values used when initially creating the object. They are
// compared against current header values to check for outside changes.
@ -655,7 +657,7 @@ class BASE_EXPORT ThreadActivityTracker {
protected:
// The thread tracker to which this object reports. It can be null if
// activity tracking is not (yet) enabled.
ThreadActivityTracker* const tracker_;
const raw_ptr<ThreadActivityTracker> tracker_;
// An identifier that indicates a specific activity on the stack.
ActivityId activity_id_;
@ -766,8 +768,8 @@ class BASE_EXPORT ThreadActivityTracker {
Activity* activity,
ActivityTrackerMemoryAllocator* allocator);
Header* const header_; // Pointer to the Header structure.
Activity* const stack_; // The stack of activities.
const raw_ptr<Header> header_; // Pointer to the Header structure.
const raw_ptr<Activity> stack_; // The stack of activities.
#if DCHECK_IS_ON()
// The ActivityTracker is thread bound, and will be invoked across all the
@ -1170,7 +1172,7 @@ class BASE_EXPORT GlobalActivityTracker {
const PersistentMemoryAllocator::Reference mem_reference_;
// The physical address used for the thread-tracker's memory.
void* const mem_base_;
const raw_ptr<void> mem_base_;
};
// Creates a global tracker using a given persistent-memory |allocator| and

@ -14,6 +14,7 @@
#include "base/files/memory_mapped_file.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/pending_task.h"
#include "base/rand_util.h"
#include "base/synchronization/condition_variable.h"
@ -284,7 +285,7 @@ class SimpleLockThread : public SimpleThread {
bool WasDataChanged() { return data_changed_; }
private:
Lock* lock_;
raw_ptr<Lock> lock_;
bool data_changed_;
std::atomic<bool> is_running_;
};
@ -437,7 +438,7 @@ class SimpleActivityThread : public SimpleThread {
}
private:
const void* origin_;
raw_ptr<const void> origin_;
Activity::Type activity_;
ActivityData data_;

@ -12,6 +12,7 @@
#include <memory>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "base/win/iat_patch_function.h"
#include "base/win/pe_image.h"
#include "base/win/scoped_handle.h"
@ -85,7 +86,7 @@ class AutoProtectMemory {
private:
bool changed_;
void* address_;
raw_ptr<void> address_;
size_t bytes_;
DWORD old_protect_;
};

@ -13,6 +13,7 @@
#include "base/base_export.h"
#include "base/cxx17_backports.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
@ -114,7 +115,7 @@ class BASE_EXPORT ScopedCrashKeyString {
ScopedCrashKeyString& operator=(ScopedCrashKeyString&&) = delete;
private:
CrashKeyString* crash_key_;
raw_ptr<CrashKeyString> crash_key_;
};
// Internal helpers for the SCOPED_CRASH_KEY_... helper macros defined below.

@ -12,6 +12,7 @@
#include <ostream>
#include "base/debug/proc_maps_linux.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/stringprintf.h"
#include "base/threading/thread_restrictions.h"
@ -30,7 +31,7 @@ struct StackCrawlState {
max_depth(max_depth),
have_skipped_self(false) {}
uintptr_t* frames;
raw_ptr<uintptr_t> frames;
size_t frame_count;
size_t max_depth;
bool have_skipped_self;

@ -6,6 +6,7 @@
#include <ostream>
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
@ -65,8 +66,8 @@ class ThreeTasksTest {
base::SingleThreadTaskRunner& task_runner =
*task_environment.GetMainThreadTaskRunner();
const void* task_a_address = nullptr;
const void* task_b_address = nullptr;
raw_ptr<const void> task_a_address = nullptr;
raw_ptr<const void> task_b_address = nullptr;
};
TEST(TaskTraceTest, ThreeTasks) {

@ -12,6 +12,7 @@
#include <vector>
#include "base/containers/span.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_piece.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
@ -49,7 +50,7 @@ class TestElfImage {
private:
std::vector<uint8_t> buffer_;
const void* elf_start_;
raw_ptr<const void> elf_start_;
};
// Builds an in-memory image of an ELF file for testing.

@ -15,6 +15,7 @@
#include "base/base_export.h"
#include "base/containers/flat_map.h"
#include "base/gtest_prod_util.h"
#include "base/memory/raw_ptr.h"
#include "base/metrics/field_trial_params.h"
#include "base/strings/string_piece.h"
#include "base/synchronization/lock.h"
@ -150,7 +151,7 @@ class BASE_EXPORT FeatureList {
// Unowned pointer to the FeatureList object we use to look up feature
// enablement.
FeatureList* feature_list_;
raw_ptr<FeatureList> feature_list_;
};
// Describes a feature override. The first member is a Feature that will be
@ -445,7 +446,7 @@ class BASE_EXPORT FeatureList {
// the scenario where multiple FieldTrialList are used with the same
// FeatureList - which can lead to overrides pointing to invalid FieldTrial
// objects.
base::FieldTrialList* field_trial_list_ = nullptr;
raw_ptr<base::FieldTrialList> field_trial_list_ = nullptr;
// Whether this object has been fully initialized. This gets set to true as a
// result of FinalizeInitialization().

@ -15,6 +15,7 @@
#include "base/base_export.h"
#include "base/file_version_info.h"
#include "base/memory/raw_ptr.h"
#include "base/version.h"
struct tagVS_FIXEDFILEINFO;
@ -65,7 +66,7 @@ class BASE_EXPORT FileVersionInfoWin : public FileVersionInfo {
FileVersionInfoWin(void* data, WORD language, WORD code_page);
const std::vector<uint8_t> owned_data_;
const void* const data_;
const raw_ptr<const void> data_;
const WORD language_;
const WORD code_page_;

@ -10,6 +10,7 @@
#include "base/base_export.h"
#include "base/callback.h"
#include "base/check_op.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_pump_for_io.h"
@ -75,7 +76,7 @@ class BASE_EXPORT FileDescriptorWatcher {
// Controller is deleted, ownership of |watcher_| is transfered to a delete
// task posted to the MessageLoopForIO. This ensures that |watcher_| isn't
// deleted while it is being used by the MessageLoopForIO.
Watcher* watcher_;
raw_ptr<Watcher> watcher_;
// An event for the watcher to notify controller that it's destroyed.
// As the |watcher_| is owned by Controller, always outlives the Watcher.

@ -12,6 +12,7 @@
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_util.h"
#include "base/threading/scoped_blocking_call.h"
#include "base/threading/sequenced_task_runner_handle.h"
@ -61,7 +62,7 @@ class FilePathWatcherImpl : public FilePathWatcher::PlatformDelegate,
FilePath target_;
// Set to true in the destructor.
bool* was_deleted_ptr_ = nullptr;
raw_ptr<bool> was_deleted_ptr_ = nullptr;
// Handle for FindFirstChangeNotification.
HANDLE handle_ = INVALID_HANDLE_VALUE;

@ -8,6 +8,7 @@
#include <stdint.h>
#include "base/base_export.h"
#include "base/memory/raw_ptr.h"
#define FILE_TRACING_PREFIX "File"
@ -79,7 +80,7 @@ class BASE_EXPORT FileTracing {
private:
// The ID of this trace. Based on the |file| passed to |Initialize()|. Must
// outlive this class.
const void* id_ = nullptr;
raw_ptr<const void> id_ = nullptr;
// The name of the event to trace (e.g. "Read", "Write"). Prefixed with
// "File".

Some files were not shown because too many files have changed in this diff Show More