chromium/src
0
Fork 0
Code Activity

blinkpy: Add pywin32 wheel.

Browse Source 
Eexecuting tests with vpython on Windows fails like

E:\chromium\src\out\debug_x64>git cl upload
Running presubmit upload checks ...
 checking owners took a long time: 505ms** Presubmit ERRORS **ImportError raised: No module named win32pipe
Traceback (most recent call last):
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 196, in main
   exit_status = run_checks(host, options)
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 154, in run_checks
   failures.extend(lint(host, options))
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 44, in lint
   ports_to_lint = [host.port_factory.get(name) for name in host.port_factory.all_port_names(options.platform)]
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\factory.py, line 84, in get
   module = __import__(module_name, globals(), locals(), [], -1)
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\android.py, line 46, in <module>
   from blinkpy.web_tests.port import base
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\base.py, line 55, in <module>
   from blinkpy.web_tests.port import server_process
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\server_process.py, line 45, in <module>
   import win32pipe
ImportError: No module named win32pipe

Add pywin32 wheel to fix it.

Bug: 1017410
Change-Id: Ic64fb6631fa113dfd5cce30a636daaa3be978d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876985
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709638}
This commit is contained in:
ehmaldonado
2019-10-25 21:14:30 +00:00
committed by Commit Bot
parent 19f0444f56
commit 0fbaadc41d
1 changed files with 13 additions and 0 deletions

13
.vpython

@ -381,3 +381,16 @@ wheel: <
platform: "macosx_10_6_intel"
>
>
# Used by:
# //third_party/blink/tools/blinkpy/web_tests/port/server_process.py
wheel: <
name: "infra/python/wheels/pywin32/${vpython_platform}"
version: "version:224"
match_tag: <
platform: "win32"
>
match_tag: <
platform: "win_amd64"
>
>