chromium/src
0
Fork 0
Code Activity

Refine expectations in NavigationBrowserTest.Bug1210234

Browse Source 
The test NavigationBrowserTest.Bug1210234 is flaky on android. This CL
refines a bit the expectations in the test to help understand why that
is the case.

Bug: 1222320
Change-Id: I714808eccbb7a496833d35aa30ed3476d14d1fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978631
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894651}
This commit is contained in:
Antonio Sartori
2021-06-22 13:04:19 +00:00
committed by Chromium LUCI CQ
parent fcae548355
commit 1139a79f65
1 changed files with 4 additions and 4 deletions

8
content/browser/navigation_browsertest.cc

@ -5580,10 +5580,10 @@ IN_PROC_BROWSER_TEST_F(NavigationBrowserTest, Bug1210234) {
// Since we committed a navigation, the next cross-origin navigation will
// create a speculative RenderFrameHost.
// We use ASSERT_FALSE here since this will be redirected to "c.com".
ASSERT_FALSE(NavigateToURL(
shell(), embedded_test_server()->GetURL("b.com", "/title1.html")));
NavigateToURLBlockUntilNavigationsComplete(
web_contents(), initial_url, /*number_of_navigations=*/1,
/*ignore_uncommitted_navigations=*/true);
EXPECT_TRUE(IsLastCommittedEntryOfPageType(web_contents(), PAGE_TYPE_NORMAL));
EXPECT_EQ(redirection_url, web_contents()->GetLastCommittedURL());
}