chromium/src
0
Fork 0
Code Activity

[CodeHealth] Remove uses of ListValue::Append in /components/safe_search_api.

Browse Source 
This CL removes uses of the overload that accepts a
std::unique_ptr<base::Value>. It attempts to modernize code where
feasible and uses base::Value::FromUniquePtrValue where it's not.

This CL was uploaded by git cl split.

R=treib@chromium.org

Bug: 1187097
Change-Id: I736fd7195ab7e1e5a3c3c590d309db0a41f7fd30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3626350
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999260}
This commit is contained in:
David Bertoni
2022-05-04 07:21:16 +00:00
committed by Chromium LUCI CQ
parent 087cca830c
commit 11dd6ca002
2 changed files with 12 additions and 16 deletions

14
components/safe_search_api/safe_search/safe_search_url_checker_client_unittest.cc

@ -30,15 +30,13 @@ constexpr char kSafeSearchApiUrl[] =
"https://safesearch.googleapis.com/v1:classify";
std::string BuildResponse(bool is_porn) {
base::Value dict(base::Value::Type::DICTIONARY);
auto classification_dict =
std::make_unique<base::Value>(base::Value::Type::DICTIONARY);
base::Value::Dict dict;
base::Value::Dict classification_dict;
if (is_porn)
classification_dict->SetBoolKey("pornography", is_porn);
auto classifications_list = std::make_unique<base::ListValue>();
classifications_list->Append(std::move(classification_dict));
dict.SetKey("classifications",
base::Value::FromUniquePtrValue(std::move(classifications_list)));
classification_dict.Set("pornography", is_porn);
base::Value::List classifications_list;
classifications_list.Append(std::move(classification_dict));
dict.Set("classifications", std::move(classifications_list));
std::string result;
base::JSONWriter::Write(dict, &result);
return result;

14
components/safe_search_api/stub_url_checker.cc

@ -24,15 +24,13 @@ constexpr char kSafeSearchApiUrl[] =
"https://safesearch.googleapis.com/v1:classify";
std::string BuildResponse(bool is_porn) {
base::Value dict(base::Value::Type::DICTIONARY);
auto classification_dict =
std::make_unique<base::Value>(base::Value::Type::DICTIONARY);
base::Value::Dict dict;
base::Value::Dict classification_dict;
if (is_porn)
classification_dict->SetBoolKey("pornography", is_porn);
auto classifications_list = std::make_unique<base::ListValue>();
classifications_list->Append(std::move(classification_dict));
dict.SetKey("classifications",
base::Value::FromUniquePtrValue(std::move(classifications_list)));
classification_dict.Set("pornography", is_porn);
base::Value::List classifications_list;
classifications_list.Append(std::move(classification_dict));
dict.Set("classifications", std::move(classifications_list));
std::string result;
base::JSONWriter::Write(dict, &result);
return result;