0

[Lens] Add unary API with HTTP transport feature flag.

Bug: b/369159694
Change-Id: I59c4bd4eb0da53c570332569260fbb3d762faa5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5959252
Reviewed-by: Jason Hu <hujasonx@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Charles Yang <cmyang@google.com>
Cr-Commit-Position: refs/heads/main@{#1373497}
This commit is contained in:
Charles Yang
2024-10-24 19:15:53 +00:00
committed by Chromium LUCI CQ
parent ae2832200a
commit 11dd8ab03f
6 changed files with 27 additions and 0 deletions

@ -5749,6 +5749,11 @@
"owners": ["cmyang@google.com", "ericappelbaum@google.com"],
"expiry_milestone": 135
},
{
"name": "lens-unary-apis-with-http-transport-enabled",
"owners": ["cmyang@google.com", "brandonli@google.com"],
"expiry_milestone": 140
},
{
"name": "lens-web-page-load-optimization-enabled",
"owners": ["cmyang@google.com"],

@ -1999,6 +1999,11 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flag_descriptions::kPostProfileSwitchActionsName,
flag_descriptions::kPostProfileSwitchActionsDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kPostProfileSwitchActions)},
{"lens-unary-apis-with-http-transport-enabled",
flag_descriptions::kLensUnaryApisWithHttpTransportEnabledName,
flag_descriptions::kLensUnaryApisWithHttpTransportEnabledDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kLensUnaryApisWithHttpTransportEnabled)},
};
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {

@ -642,6 +642,11 @@ const char kLensTranslateToggleModeEnabledName[] =
const char kLensTranslateToggleModeEnabledDescription[] =
"Enables the translate toggle mode.";
const char kLensUnaryApisWithHttpTransportEnabledName[] =
"Lens unary APIs with HTTP transport enabled";
const char kLensUnaryApisWithHttpTransportEnabledDescription[] =
"Enables the unary APIs with HTTP transport.";
const char kLensWebPageLoadOptimizationEnabledName[] =
"Lens web page load optimization";
const char kLensWebPageLoadOptimizationEnabledDescription[] =

@ -555,6 +555,11 @@ extern const char kLensOverlayEnableIPadCompatibilityDescription[];
extern const char kLensTranslateToggleModeEnabledName[];
extern const char kLensTranslateToggleModeEnabledDescription[];
// Title and description for the flag to enable the Lens unary APIs with HTTP
// transport.
extern const char kLensUnaryApisWithHttpTransportEnabledName[];
extern const char kLensUnaryApisWithHttpTransportEnabledDescription[];
// Title and description for the flag to enable the Lens web page load
// optimization.
extern const char kLensWebPageLoadOptimizationEnabledName[];

@ -28,4 +28,7 @@ int LensTranslateToggleMode();
// Whether to enable the Lens web page load optimization.
BASE_DECLARE_FEATURE(kLensWebPageLoadOptimizationEnabled);
// Whether to use unary APIs with HTTP transport.
BASE_DECLARE_FEATURE(kLensUnaryApisWithHttpTransportEnabled);
#endif // IOS_CHROME_BROWSER_UI_LENS_FEATURES_H_

@ -31,3 +31,7 @@ int LensTranslateToggleMode() {
BASE_FEATURE(kLensWebPageLoadOptimizationEnabled,
"LensWebPageLoadOptimizationEnabled",
base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kLensUnaryApisWithHttpTransportEnabled,
"LensUnaryApisWithHttpTransportEnabled",
base::FEATURE_DISABLED_BY_DEFAULT);