chromium/src
0
Fork 0
Code Activity

Enable benchmark retries for android-pixel6-perf-pgo

Browse Source 
This can help reduce failure rate of the builder.

Bug: b:364850602
Change-Id: I781457a310e7d8484aa7f4fe24daedadfdb52aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836584
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354908}
This commit is contained in:
Zhaoyang Li
2024-09-13 00:18:06 +00:00
committed by Chromium LUCI CQ
parent 3a27dfbe57
commit 13efc7904b
3 changed files with 10 additions and 2 deletions

2
testing/buildbot/chromium.perf.json

@ -591,7 +591,7 @@
"--browser=android-trichrome-chrome-google-64-32-bundle",
"--upload-results",
"--test-shard-map-filename=android-pixel6-perf-pgo_map.json",
"--ignore-benchmark-exit-code"
"--benchmark-max-runs=3"
],
"merge": {
"script": "//tools/perf/process_perf_results.py"

2
testing/buildbot/chromium.perf.pinpoint.json

@ -519,7 +519,7 @@
"--browser=android-trichrome-chrome-google-64-32-bundle",
"--upload-results",
"--test-shard-map-filename=android-pixel6-perf-pgo_map.json",
"--ignore-benchmark-exit-code"
"--benchmark-max-runs=3"
],
"merge": {
"script": "//tools/perf/process_perf_results.py"

8
tools/perf/core/perf_data_generator.py

@ -54,6 +54,9 @@ from telemetry import decorators
# # Arguments to pass to the test suite as a list of strings.
# 'extra_args': ['--arg1', '--arg2', ...],
#
# # Arguments to be removed from the test suite (as a list of strings).
# 'remove_args': ['--arg1', '--arg2', ...],
#
# # Name of the isolate to run as a string.
# 'isolate': 'isolate_name',
#
@ -565,6 +568,8 @@ BUILDERS = {
'tests': [{
'isolate':
'performance_test_suite_android_clank_trichrome_chrome_google_64_32_bundle',
'extra_args': ['--benchmark-max-runs=3'],
'remove_args': ['--ignore-benchmark-exit-code'],
}],
'platform':
'android-trichrome-chrome-google-64-32-bundle',
@ -1668,6 +1673,9 @@ def generate_performance_test(tester_config, test, builder_name):
assert shards
# Append any additional args specific to an isolate
test_args += test.get('extra_args', [])
test_args = [
arg for arg in test_args if arg not in test.get('remove_args', [])
]
result = {
'args': test_args,