0

Replace absl::make_unique with std::make_unique

These have been the same for some time. At least one of these
absl::make_unique calls was actually relying on a transitive include
that goes away when absl::optional and absl::variant become
std::optional and std::variant.

Switch to the standard spelling, which is both more consistent and
doesn't rely on a transitive include deep in Abseil.

Bug: 1373620, 1373619
Change-Id: Ib3d850672d289a1907d3149d3d0216df4b019715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4462217
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1134762}
This commit is contained in:
David Benjamin
2023-04-24 19:17:44 +00:00
committed by Chromium LUCI CQ
parent 6570b69dda
commit 1521404c32
4 changed files with 4 additions and 4 deletions
android_webview/browser
chrome/browser/ui/tabs
components/password_manager/core/browser/leak_detection
tools/accessibility/inspect

@ -64,7 +64,7 @@ AwBrowserProcess::AwBrowserProcess(
&AwBrowserProcess::OnLoseForeground, base::Unretained(this)));
app_link_manager_ =
absl::make_unique<EnterpriseAuthenticationAppLinkManager>(local_state());
std::make_unique<EnterpriseAuthenticationAppLinkManager>(local_state());
}
AwBrowserProcess::~AwBrowserProcess() {

@ -194,7 +194,7 @@ TabGroupModelFactory* TabGroupModelFactory::GetInstance() {
std::unique_ptr<TabGroupModel> TabGroupModelFactory::Create(
TabGroupController* controller) {
return absl::make_unique<TabGroupModel>(controller);
return std::make_unique<TabGroupModel>(controller);
}
///////////////////////////////////////////////////////////////////////////////

@ -94,7 +94,7 @@ class LeakDetectionCheckImplTest : public testing::TestWithParam<bool> {
identity_env().SetCookieAccounts({{info.email, info.gaia}});
identity_env().SetRefreshTokenForAccount(info.account_id);
}
leak_check_ = absl::make_unique<LeakDetectionCheckImpl>(
leak_check_ = std::make_unique<LeakDetectionCheckImpl>(
&delegate_, identity_test_env_.identity_manager(),
base::MakeRefCounted<network::TestSharedURLLoaderFactory>(), api_key);
auto mock_request_factory =

@ -116,7 +116,7 @@ int main(int argc, char** argv) {
}
auto server =
absl::make_unique<content::AXTreeServer>(*selector, *scenario, api);
std::make_unique<content::AXTreeServer>(*selector, *scenario, api);
if (server->error) {
return 1;