0

Forward declare base::FilePath in some commonly used headers.

Don't include file_path.h when it is not required. Then fix the build by
adding in missing includes that are required.

Change-Id: I5edb0c159dc5755f253bb8c15f74dedebd9adaaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881321
Commit-Queue: Nico Weber <thakis@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881201}
This commit is contained in:
Lei Zhang
2021-05-10 20:19:18 +00:00
committed by Chromium LUCI CQ
parent 99955725b1
commit 175750867d
20 changed files with 26 additions and 10 deletions
base
chrome/browser
components
content/public
courgette/third_party/bsdiff
gpu/config
services/resource_coordinator/memory_instrumentation

@ -7,6 +7,7 @@
#include "base/allocator/partition_allocator/oom_callback.h"
#include "base/compiler_specific.h"
#include "base/immediate_crash.h"
#include "base/process/memory.h"
#include "build/build_config.h"

@ -16,6 +16,7 @@
#include "base/base_export.h"
#include "base/command_line.h"
#include "base/environment.h"
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/process/process.h"
#include "base/process/process_handle.h"

@ -8,6 +8,7 @@
#include <stddef.h>
#include "base/base_export.h"
#include "base/compiler_specific.h"
#include "base/process/process_handle.h"
#include "build/build_config.h"

@ -8,8 +8,9 @@
#include <stdint.h>
#include <sys/types.h>
#include <iosfwd>
#include "base/base_export.h"
#include "base/files/file_path.h"
#include "build/build_config.h"
#if defined(OS_WIN)
@ -22,6 +23,8 @@
namespace base {
class FilePath;
// ProcessHandle is a platform specific type which represents the underlying OS
// handle to a process.
// ProcessId is a number which identifies the process in the OS.

@ -9,6 +9,7 @@
#include <sys/sysctl.h>
#include <sys/types.h>
#include "base/files/file_path.h"
#include "base/logging.h"
namespace base {

@ -13,7 +13,6 @@
#include "base/base_export.h"
#include "base/callback_forward.h"
#include "base/files/file_path.h"
#include "base/gtest_prod_util.h"
#include "base/time/time.h"
#include "build/build_config.h"
@ -25,6 +24,7 @@ namespace debug {
FORWARD_DECLARE_TEST(SystemMetricsTest, ParseMeminfo);
}
class FilePath;
struct SystemMemoryInfoKB;
class BASE_EXPORT SysInfo {

@ -10,6 +10,7 @@
#include "base/android/jni_string.h"
#include "base/android/scoped_java_ref.h"
#include "base/feature_list.h"
#include "base/files/file_path.h"
#include "chrome/browser/download/android/jni_headers/DownloadManagerBridge_jni.h"
#include "components/download/public/common/download_features.h"
#include "url/gurl.h"

@ -4,6 +4,7 @@
#include "chrome/browser/enterprise/signals/device_info_fetcher_win.h"
#include "base/files/file_path.h"
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"

@ -6,6 +6,8 @@
#include <windows.h>
#include <ostream>
#include "base/check.h"
#include "components/crash/core/app/crash_export_thunks.h"

@ -4,6 +4,7 @@
#include "components/download/public/common/download_item_rename_handler.h"
#include "base/files/file_path.h"
#include "components/download/public/common/download_interrupt_reasons.h"
#include "components/download/public/common/download_item.h"

@ -9,6 +9,7 @@
#include <vector>
#include "base/bind.h"
#include "base/files/file_path.h"
#include "base/metrics/field_trial_params.h"
#include "base/strings/string_number_conversions.h"
#include "base/threading/thread_task_runner_handle.h"

@ -24,7 +24,6 @@
#include <vector>
#include "base/callback_forward.h"
#include "base/files/file_path.h"
#include "base/memory/ref_counted.h"
#include "base/optional.h"
#include "base/supports_user_data.h"

@ -11,6 +11,7 @@
#include <vector>
#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/observer_list.h"
#include "base/optional.h"
#include "base/time/time.h"

@ -19,7 +19,6 @@
#include "base/check.h"
#include "base/containers/flat_set.h"
#include "base/feature_list.h"
#include "base/files/file_path.h"
#include "base/location.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"

@ -11,7 +11,6 @@
#include <string>
#include "base/callback_forward.h"
#include "base/files/file_path.h"
#include "base/time/time.h"
#include "components/services/storage/public/mojom/cache_storage_control.mojom-forward.h"
#include "components/services/storage/public/mojom/indexed_db_control.mojom-forward.h"
@ -24,6 +23,7 @@
class GURL;
namespace base {
class FilePath;
class Time;
}

@ -15,7 +15,6 @@
#include "base/callback_forward.h"
#include "base/callback_helpers.h"
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
#include "base/optional.h"
#include "base/process/kill.h"
#include "base/supports_user_data.h"
@ -51,6 +50,11 @@
#include "base/android/scoped_java_ref.h"
#endif
namespace base {
class FilePath;
class TimeTicks;
} // namespace base
namespace blink {
namespace web_pref {
struct WebPreferences;
@ -60,10 +64,6 @@ struct UserAgentOverride;
struct RendererPreferences;
} // namespace blink
namespace base {
class TimeTicks;
}
namespace device {
namespace mojom {
class WakeLockContext;

@ -4,6 +4,7 @@
#include "content/public/test/fake_pepper_plugin_instance.h"
#include "base/files/file_path.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/shared_impl/ppapi_permissions.h"

@ -15,6 +15,7 @@
#include <iterator>
#include <type_traits>
#include "base/check.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/process/memory.h"

@ -19,6 +19,7 @@
#include "base/base_paths.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/sparse_histogram.h"

@ -13,6 +13,7 @@
#include "base/gtest_prod_util.h"
#include "base/macros.h"
#include "base/process/process_handle.h"
#include "base/strings/string_piece.h"
#include "base/trace_event/memory_allocator_dump_guid.h"
namespace memory_instrumentation {