chromium/src
0
Fork 0
Code Activity

Remove CRONET_BUILD buildflag in iOS code

Browse Source 
Cronet for iOS has been deprecated.
So removing remaining CRONET_BUILD buildflag from iOS code.

Bug: 345183789
Change-Id: I668f7b385e3f6c3853fb6052a3978413b5e7531f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088085
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Md Hasibul Hasan <hasibul.h@samsung.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395885}
This commit is contained in:
Md Hasibul Hasan
2024-12-13 04:34:54 -08:00
committed by Chromium LUCI CQ
parent 9375cc2d51
commit 17a0f7905b
4 changed files with 1 additions and 11 deletions

1
AUTHORS

@ -969,6 +969,7 @@ Mc Zeng <zengmcong@gmail.com>
Md Abdullah Al Alamin <a.alamin.cse@gmail.com>
Md. Hasanur Rashid <hasanur.r@samsung.com>
Md Hasibul Hasan <hasibulhasan873@gmail.com>
Md Hasibul Hasan <hasibul.h@samsung.com>
Md Jobed Hossain <jobed.h@samsung.com>
Md Raiyan bin Sayeed <mrbsayee@uwaterloo.ca>
Md. Sadiqul Amin <sadiqul.amin@samsung.com>

2
ios/net/BUILD.gn

@ -3,14 +3,12 @@
# found in the LICENSE file.
import("//build/buildflag_header.gni")
import("//build/config/cronet/config.gni")
import("//ios/build/config.gni")
import("//testing/test.gni")
import("//url/features.gni")
buildflag_header("ios_net_buildflags") {
header = "ios_net_buildflags.h"
flags = [ "CRONET_BUILD=$is_cronet_build" ]
}
group("all_tests") {

4
ios/net/cookies/cookie_creation_time_manager.mm

@ -24,11 +24,7 @@ base::Time GetCreationTimeFromObject(NSHTTPCookie* cookie) {
// The "Created" key is not documented.
// Return a null time if the key is missing.
id created = [[cookie properties] objectForKey:kHTTPCookieCreated];
#if !BUILDFLAG(CRONET_BUILD)
// In Cronet the cookie store is recreated on startup, so |created| could be
// nil.
DCHECK(created && [created isKindOfClass:[NSNumber class]]);
#endif
if (!created || ![created isKindOfClass:[NSNumber class]])
return base::Time();
// created is the time from January 1st, 2001 in seconds.

5
ios/net/cookies/system_cookie_store.mm

@ -50,13 +50,8 @@ NSInteger SystemCookieStore::CompareCookies(NSHTTPCookie* cookie_a,
static_cast<CookieCreationTimeManager*>(context);
base::Time created_a = manager->GetCreationTime(cookie_a);
base::Time created_b = manager->GetCreationTime(cookie_b);
#if !BUILDFLAG(CRONET_BUILD)
// CookieCreationTimeManager is returning creation times that are null.
// Since in Cronet, the cookie store is recreated on startup, let's suppress
// this warning for now.
DLOG_IF(ERROR, created_a.is_null() || created_b.is_null())
<< "Cookie without creation date";
#endif
if (created_a < created_b)
return NSOrderedAscending;
if (created_a > created_b)