mb_config: stop forcing -std=c++17 for tidy builders
People are checking in c++20 code, which leads to build errors, which slows down these bots significantly. It seems better to tweak clang-tidy's config until C++20 is fully deployed. This also prevents false-positives like those in crbug.com/1434819. Bug: 1444563, 1434844 Change-Id: Ib251c5241552f3ce7cdf05632b46f635cba8c820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4527456 Reviewed-by: Erik Staab <estaab@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143466}
This commit is contained in:
George Burgess IV
committed by
Chromium LUCI CQ
Chromium LUCI CQ
parent
825afb0844
commit
17c8e4fd4f
@ -1,6 +1,9 @@
|
||||
---
|
||||
# TODO(crbug.com/1282228): reenable google-readability-casting once it no
|
||||
# longer has as many false-positives.
|
||||
# TODO(crbug.com/1406869): reenable modernize-use-default-member-init once
|
||||
# C++20 is everywhere; it recommends using default member init for bit fields,
|
||||
# which is C++20-only.
|
||||
Checks: '-*,
|
||||
bugprone-argument-comment,
|
||||
bugprone-assert-side-effect,
|
||||
@ -24,7 +27,6 @@
|
||||
modernize-replace-random-shuffle,
|
||||
modernize-shrink-to-fit,
|
||||
modernize-use-bool-literals,
|
||||
modernize-use-default-member-init,
|
||||
modernize-use-emplace,
|
||||
modernize-use-equals-default,
|
||||
modernize-use-equals-delete,
|
||||
|
||||
@ -1363,17 +1363,14 @@
|
||||
'win-swangle-try-x86': 'angle_deqp_release_trybot_x86_reclient',
|
||||
},
|
||||
|
||||
# crbug.com/1417003: `-Werror` is removed for these to work around the
|
||||
# existence of C++20-only code in Chromium, while we're forcing -std=c++17.
|
||||
# Tons of build failures slow down these builders significantly.
|
||||
'tryserver.chromium.tricium': {
|
||||
'android-clang-tidy-rel': 'android_release_trybot_reclient_cxx17_no_werror',
|
||||
'fuchsia-clang-tidy-rel': 'release_trybot_fuchsia_reclient_cxx17_no_werror',
|
||||
'linux-chromeos-clang-tidy-rel': 'chromeos_with_codecs_release_trybot_reclient_cxx17_no_werror',
|
||||
'linux-clang-tidy-rel': 'release_trybot_reclient_cxx17_no_werror',
|
||||
'linux-lacros-clang-tidy-rel': 'lacros_on_linux_release_trybot_reclient_cxx17_no_werror',
|
||||
'mac-clang-tidy-rel': 'release_trybot_reclient_cxx17_no_werror',
|
||||
'win10-clang-tidy-rel': 'release_trybot_reclient_cxx17_no_werror',
|
||||
'android-clang-tidy-rel': 'android_release_trybot_reclient',
|
||||
'fuchsia-clang-tidy-rel': 'release_trybot_fuchsia_reclient',
|
||||
'linux-chromeos-clang-tidy-rel': 'chromeos_with_codecs_release_trybot_reclient',
|
||||
'linux-clang-tidy-rel': 'release_trybot_reclient',
|
||||
'linux-lacros-clang-tidy-rel': 'lacros_on_linux_release_trybot_reclient',
|
||||
'mac-clang-tidy-rel': 'release_trybot_reclient',
|
||||
'win10-clang-tidy-rel': 'release_trybot_reclient',
|
||||
},
|
||||
|
||||
'tryserver.chromium.updater': {
|
||||
@ -1765,10 +1762,6 @@
|
||||
'android', 'release_trybot_reclient', 'strip_debug_info',
|
||||
],
|
||||
|
||||
'android_release_trybot_reclient_cxx17_no_werror': [
|
||||
'android', 'release_trybot_reclient', 'strip_debug_info', 'force_cxx17', 'no_werror',
|
||||
],
|
||||
|
||||
'android_release_trybot_x64_coverage_fastbuild_webview_trichrome_reclient': [
|
||||
'android', 'release_trybot_reclient', 'strip_debug_info', 'x64',
|
||||
'android_fastbuild', 'use_java_coverage', 'partial_code_coverage_instrumentation',
|
||||
@ -2345,8 +2338,8 @@
|
||||
'chromeos_with_codecs', 'release_trybot_reclient', 'no_symbols', 'invert_fieldtrials',
|
||||
],
|
||||
|
||||
'chromeos_with_codecs_release_trybot_reclient_cxx17_no_werror': [
|
||||
'chromeos_with_codecs', 'release_trybot_reclient', 'no_symbols', 'force_cxx17', 'no_werror',
|
||||
'chromeos_with_codecs_release_trybot_reclient': [
|
||||
'chromeos_with_codecs', 'release_trybot_reclient', 'no_symbols',
|
||||
],
|
||||
|
||||
'chromeos_with_codecs_with_lacros_release_bot_reclient': [
|
||||
@ -3010,10 +3003,6 @@
|
||||
'lacros_on_linux_release_trybot_reclient',
|
||||
],
|
||||
|
||||
'lacros_on_linux_release_trybot_reclient_cxx17_no_werror': [
|
||||
'lacros_on_linux_release_trybot_reclient', 'force_cxx17', 'no_werror', 'no_werror',
|
||||
],
|
||||
|
||||
'lacros_on_linux_tot_debug': [
|
||||
'lacros_on_linux', 'debug', 'also_build_ash_chrome', 'clang_tot',
|
||||
],
|
||||
@ -3591,10 +3580,6 @@
|
||||
'release_trybot_reclient', 'fuchsia',
|
||||
],
|
||||
|
||||
'release_trybot_fuchsia_reclient_cxx17_no_werror': [
|
||||
'release_trybot_reclient', 'fuchsia', 'force_cxx17', 'no_werror',
|
||||
],
|
||||
|
||||
'release_trybot_minimal_symbols_reclient': [
|
||||
'release_trybot_minimal_symbols_reclient',
|
||||
],
|
||||
@ -3611,10 +3596,6 @@
|
||||
'release_trybot_reclient',
|
||||
],
|
||||
|
||||
'release_trybot_reclient_cxx17_no_werror': [
|
||||
'release_trybot_reclient', 'force_cxx17', 'no_werror',
|
||||
],
|
||||
|
||||
'release_trybot_reclient_x64': [
|
||||
'release_trybot_reclient', 'x64',
|
||||
],
|
||||
@ -4208,10 +4189,6 @@
|
||||
'gn_args': 'ffmpeg_branding="ChromeOS"',
|
||||
},
|
||||
|
||||
'force_cxx17': {
|
||||
'gn_args': 'use_cxx17=true',
|
||||
},
|
||||
|
||||
'fuchsia': {
|
||||
'gn_args': 'target_os="fuchsia"',
|
||||
},
|
||||
@ -4443,10 +4420,6 @@
|
||||
'gn_args': 'symbol_level=0',
|
||||
},
|
||||
|
||||
'no_werror': {
|
||||
'gn_args': 'treat_warnings_as_errors=false',
|
||||
},
|
||||
|
||||
'no_widevine_cdm_host_verification': {
|
||||
'gn_args': 'ignore_missing_widevine_signing_cert=true',
|
||||
},
|
||||
|
||||
@ -10,8 +10,6 @@
|
||||
"strip_debug_info": true,
|
||||
"symbol_level": 0,
|
||||
"target_os": "android",
|
||||
"treat_warnings_as_errors": false,
|
||||
"use_cxx17": true,
|
||||
"use_remoteexec": true
|
||||
}
|
||||
},
|
||||
@ -22,8 +20,6 @@
|
||||
"is_debug": false,
|
||||
"symbol_level": 0,
|
||||
"target_os": "fuchsia",
|
||||
"treat_warnings_as_errors": false,
|
||||
"use_cxx17": true,
|
||||
"use_remoteexec": true
|
||||
}
|
||||
},
|
||||
@ -36,8 +32,6 @@
|
||||
"proprietary_codecs": true,
|
||||
"symbol_level": 0,
|
||||
"target_os": "chromeos",
|
||||
"treat_warnings_as_errors": false,
|
||||
"use_cxx17": true,
|
||||
"use_remoteexec": true
|
||||
}
|
||||
},
|
||||
@ -47,8 +41,6 @@
|
||||
"is_component_build": false,
|
||||
"is_debug": false,
|
||||
"symbol_level": 0,
|
||||
"treat_warnings_as_errors": false,
|
||||
"use_cxx17": true,
|
||||
"use_remoteexec": true
|
||||
}
|
||||
},
|
||||
@ -61,8 +53,6 @@
|
||||
"is_debug": false,
|
||||
"symbol_level": 0,
|
||||
"target_os": "chromeos",
|
||||
"treat_warnings_as_errors": false,
|
||||
"use_cxx17": true,
|
||||
"use_remoteexec": true
|
||||
}
|
||||
},
|
||||
@ -72,8 +62,6 @@
|
||||
"is_component_build": false,
|
||||
"is_debug": false,
|
||||
"symbol_level": 0,
|
||||
"treat_warnings_as_errors": false,
|
||||
"use_cxx17": true,
|
||||
"use_remoteexec": true
|
||||
}
|
||||
},
|
||||
@ -83,8 +71,6 @@
|
||||
"is_component_build": false,
|
||||
"is_debug": false,
|
||||
"symbol_level": 0,
|
||||
"treat_warnings_as_errors": false,
|
||||
"use_cxx17": true,
|
||||
"use_remoteexec": true
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user