chromium/src
0
Fork 0
Code Activity

Whitelist font_name from fallback tracing events

Browse Source 
This CL is adding the font_name to track the resulting font when
performing an FontLink falllback.

    TRACE_EVENT_INSTANT1("ui", "RenderTextHarfBuzz::FallbackFont",
                           TRACE_EVENT_SCOPE_THREAD, "font_name",
                           TRACE_STR_COPY(font_name.c_str()));

The goal is to determine when the FontLink is used and why.

R=oysteine@chromium.org

Bug: 995789
Change-Id: Ic47dfdd82e669f1ac38c04cef6ffdb2e9d02ecd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776879
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691857}
This commit is contained in:
Etienne Bergeron
2019-08-29 23:32:45 +00:00
committed by Commit Bot
parent 74c69a759f
commit 17fa2e6236
1 changed files with 2 additions and 0 deletions

2
services/tracing/public/cpp/trace_event_args_whitelist.cc

@ -26,6 +26,7 @@ struct WhitelistEntry {
const char* const kScopedBlockingCallAllowedArgs[] = {"file_name",
"function_name", nullptr};
const char* const kFallbackFontAllowedArgs[] = {"font_name", nullptr};
const char* const kGetFallbackFontsAllowedArgs[] = {"script", nullptr};
const char* const kGPUAllowedArgs[] = {nullptr};
const char* const kInputLatencyAllowedArgs[] = {"data", nullptr};
@ -72,6 +73,7 @@ const WhitelistEntry kEventArgsWhitelist[] = {
{TRACE_DISABLED_BY_DEFAULT("memory-infra"), "*", kMemoryDumpAllowedArgs},
{TRACE_DISABLED_BY_DEFAULT("system_stats"), "*", nullptr},
{TRACE_DISABLED_BY_DEFAULT("v8.gc"), "*", kV8GCAllowedArgs},
{"ui", "RenderTextHarfBuzz::FallbackFont", kFallbackFontAllowedArgs},
{"ui", "RenderTextHarfBuzz::GetFallbackFonts",
kGetFallbackFontsAllowedArgs},
{"ui", "UserEvent", nullptr},