0

[Peripherals][Refactor] Moved MotionEventUtil to util package and added OWNERS

Change-Id: I8b8c04532321710d4c7fc8b8ad0d8856c2d67d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378204
Commit-Queue: Sirisha Kavuluru <skavuluru@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439011}
This commit is contained in:
Sirisha Kavuluru
2025-03-27 14:33:52 -07:00
committed by Chromium LUCI CQ
parent c87263fa5f
commit 19cff8d0a7
12 changed files with 15 additions and 13 deletions
chrome
android
java
src
org
chromium
chrome
browser
browser
ui
android
omnibox
java
src
org
chromium
chrome
browser
toolbar
java
src
org
chromium
chrome
browser
content/public/android
java
src
org
chromium
junit
src
org
chromium
ui/android
BUILD.gn
java
junit
src
org

@@ -13,7 +13,7 @@ import androidx.annotation.Nullable;
import org.chromium.chrome.browser.compositor.overlays.strip.StripLayoutView;
import org.chromium.chrome.browser.compositor.overlays.strip.TooltipManager;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.util.MotionEventUtils;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

@@ -118,11 +118,11 @@ import org.chromium.components.tab_group_sync.SavedTabGroup;
import org.chromium.components.tab_group_sync.TabGroupSyncService;
import org.chromium.components.tab_group_sync.TriggerSource;
import org.chromium.components.tab_groups.TabGroupColorId;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.base.LocalizationUtils;
import org.chromium.ui.base.WindowAndroid;
import org.chromium.ui.modaldialog.ModalDialogManager;
import org.chromium.ui.util.ColorUtils;
import org.chromium.ui.util.MotionEventUtils;
import org.chromium.ui.widget.RectProvider;
import java.util.ArrayList;

@@ -32,9 +32,9 @@ import org.chromium.chrome.browser.layouts.components.VirtualView;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tasks.tab_management.TabUiThemeUtil;
import org.chromium.components.browser_ui.styles.SemanticColorUtils;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.base.LocalizationUtils;
import org.chromium.ui.util.ColorUtils;
import org.chromium.ui.util.MotionEventUtils;
import java.util.List;
import java.util.Optional;

@@ -41,9 +41,9 @@ import org.chromium.chrome.browser.util.KeyNavigationUtil;
import org.chromium.components.browser_ui.widget.RoundedCornerOutlineProvider;
import org.chromium.components.omnibox.OmniboxFeatures;
import org.chromium.ui.KeyboardVisibilityDelegate;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.base.DeviceFormFactor;
import org.chromium.ui.base.ViewUtils;
import org.chromium.ui.util.MotionEventUtils;
import java.util.Optional;

@@ -62,8 +62,8 @@ import org.chromium.chrome.browser.user_education.UserEducationHelper;
import org.chromium.chrome.browser.util.BrowserUiUtils;
import org.chromium.chrome.browser.util.BrowserUiUtils.ModuleTypeOnStartAndNtp;
import org.chromium.components.feature_engagement.Tracker;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.base.ViewUtils;
import org.chromium.ui.util.MotionEventUtils;
import org.chromium.ui.util.TokenHolder;
import org.chromium.url.GURL;

@@ -25,12 +25,11 @@ import org.chromium.content.browser.webcontents.WebContentsImpl;
import org.chromium.content_public.browser.ViewEventSink.InternalAccessDelegate;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContents.UserDataFactory;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.base.EventForwarder;
import org.chromium.ui.util.MotionEventUtils;
/**
* Called from native to handle UI events that need access to various Java layer
* content components.
* Called from native to handle UI events that need access to various Java layer content components.
*/
@JNINamespace("content")
@NullMarked

@@ -26,8 +26,8 @@ import org.chromium.base.test.BaseRobolectricTestRunner;
import org.chromium.content.browser.webcontents.WebContentsImpl;
import org.chromium.content.browser.webcontents.WebContentsImplJni;
import org.chromium.content_public.browser.NavigationController;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.base.EventForwarder;
import org.chromium.ui.util.MotionEventUtils;
/** Unit tests for {@link ContentUiEventHandler} */
@RunWith(BaseRobolectricTestRunner.class)

@@ -311,7 +311,6 @@ android_library("ui_utils_java") {
sources = [
"java/src/org/chromium/ui/KeyboardUtils.java",
"java/src/org/chromium/ui/KeyboardVisibilityDelegate.java",
"java/src/org/chromium/ui/MotionEventUtils.java",
"java/src/org/chromium/ui/UiUtils.java",
]
deps = [
@@ -488,6 +487,7 @@ android_library("ui_no_recycler_view_java") {
"java/src/org/chromium/ui/util/AttrUtils.java",
"java/src/org/chromium/ui/util/ColorBlendAnimationFactory.java",
"java/src/org/chromium/ui/util/ColorUtils.java",
"java/src/org/chromium/ui/util/MotionEventUtils.java",
"java/src/org/chromium/ui/util/RunnableTimer.java",
"java/src/org/chromium/ui/util/StyleUtils.java",
"java/src/org/chromium/ui/util/TokenHolder.java",

@@ -27,7 +27,7 @@ import org.chromium.base.TraceEvent;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.build.annotations.NullMarked;
import org.chromium.build.annotations.Nullable;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.util.MotionEventUtils;
import java.lang.reflect.UndeclaredThrowableException;
import java.util.ArrayList;

@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
package org.chromium.ui;
package org.chromium.ui.util;
import android.os.Build;
import android.view.InputDevice;
@@ -140,6 +140,7 @@ public class MotionEventUtils {
return (buttons & MotionEvent.BUTTON_TERTIARY) != 0;
}
/** Checks if the motion event was generated by a secondary button (middle mouse button). */
public static boolean isSecondaryClick(int buttons) {
return (buttons & MotionEvent.BUTTON_SECONDARY) != 0;
}

@@ -1 +1,3 @@
per-file XrUtils.java=file://components/webxr/OWNERS
per-file MotionEventUtils.java=skavuluru@google.com
per-file MotionEventUtils.java=aishwaryarj@google.com

@@ -35,7 +35,7 @@ import org.robolectric.annotation.Config;
import org.chromium.base.test.BaseRobolectricTestRunner;
import org.chromium.base.test.util.HistogramWatcher;
import org.chromium.ui.MotionEventUtils;
import org.chromium.ui.util.MotionEventUtils;
/** Tests logic in the {@link EventForwarder} class. */
@RunWith(BaseRobolectricTestRunner.class)