chromium/src
0
Fork 0
Code Activity

[Docs] Fix broken link in commit_checklist.md

Browse Source 
Change-Id: I953b976c800bf5826a8c4f3702ac1d93210c5c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3393766
Reviewed-by: Andrew Williams <awillia@google.com>
Commit-Queue: Andrew Williams <awillia@google.com>
Cr-Commit-Position: refs/heads/main@{#959910}
This commit is contained in:
David Sanders
2022-01-17 03:14:39 +00:00
committed by Chromium LUCI CQ
parent 089e67ba63
commit 1a95e9cfcf
1 changed files with 4 additions and 2 deletions

6
docs/commit_checklist.md

@ -209,8 +209,9 @@ You are expected to wait for all actively participating reviewers to CR+1 the
change before submitting (CQ+2), even if your CL already has all required owners
reviews. Other than preventing confusion and mistakes, this expectation exists
because:
1. Participating reviewers are [helping you write sustainable code](cr_respect),
and letting them sign off is respectful of their efforts.
1. Participating reviewers are
[helping you write sustainable code][sustainable-code], and letting them sign
off is respectful of their efforts.
1. The owners system is not perfect, and sometimes you will need an owner who
*can* approve the whole change, but will delegate approval of pieces to
other, more knowledgeable owners.
@ -285,3 +286,4 @@ branches. Please mark the associated crbug as "fixed".
[simple-chrome]: https://chromium.googlesource.com/chromiumos/docs/+/HEAD/simple_chrome_workflow.md
[uploading-a-change-for-review]: contributing.md#Uploading-a-change-for-review
[respectful-changes]: cl_respect.md
[sustainable-code]: cr_respect.md