chromium/src
0
Fork 0
Code Activity

Update GPU documentation on builder addition

Browse Source 
Updates the GPU documentation on adding new builders/testers to clarify
what to do if adding both a new parent builder and a tester triggered by
it, as it turns out that it's not as simple as performing the
tester-only steps two separate times.

Change-Id: Iddb3336db0fc12a22e8cb73ac6aa3dffe13f0ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613667
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840824}
This commit is contained in:
Brian Sheedy
2021-01-06 23:43:03 +00:00
committed by Chromium LUCI CQ
parent 961a937352
commit 1ac3f67756
1 changed files with 18 additions and 0 deletions

18
docs/gpu/gpu_testing_bot_details.md

@ -468,6 +468,23 @@ Builder].
add a manually-triggered trybot at the same time that the CI bot is added.
This is described in [How to add a new manually-triggered trybot].
While the above instructions assume that an existing parent builder will be
be used, a new one can be set up by performing a modified version of the steps:
1. Make a [`tools/build`][tools/build] CL that adds the config for *only* the
new builder and land it.
1. Make and land Chromium CL that makes the above changes in addition to the
following:
1. Add the new builder to the necessary `//infra/config` files in the same
way as the tester.
1. Add the new builder to [`src/tools/mb/mb_config.pyl`][mb_config.pyl].
1. Make a [`tools/build`][tools/build] CL that adds the config for *only* the
new tester and land it.
Attempting to set up the builder/tester pair without first landing the
[`tools/build`][tools/build] CL for the new builder will result in things
breaking as seen in [this bug][misconfigured builder bug].
[How to add a new manually-triggered trybot]: https://chromium.googlesource.com/chromium/src/+/master/docs/gpu/gpu_testing_bot_details.md#How-to-add-a-new-manually_triggered-trybot
[ci.star]: https://chromium.googlesource.com/chromium/src/+/master/infra/config/subprojects/ci.star
@ -477,6 +494,7 @@ Builder].
[luci-scheduler.cfg]: https://chromium.googlesource.com/chromium/src/+/master/infra/config/generated/luci-scheduler.cfg
[luci-milo.cfg]: https://chromium.googlesource.com/chromium/src/+/master/infra/config/generated/luci-milo.cfg
[GPU FYI Win Builder]: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Win%20Builder
[misconfigured builder bug]: https://bugs.chromium.org/p/chromium/issues/detail?id=1163657
### How to start running tests on a new GPU type on an existing try bot