chromium/src
0
Fork 0
Code Activity

[keyboard-alt]: Fix casing in right-click notification strings

Browse Source 
Bug: b/279503977
Change-Id: Idcf9415750b16a5bee55653513f0163d9bd90ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4766329
Commit-Queue: David Padlipsky <dpad@google.com>
Reviewed-by: David Padlipsky <dpad@google.com>
Commit-Queue: Michael Checo <michaelcheco@google.com>
Auto-Submit: Michael Checo <michaelcheco@google.com>
Cr-Commit-Position: refs/heads/main@{#1181717}
This commit is contained in:
Michael Checo
2023-08-09 21:39:13 +00:00
committed by Chromium LUCI CQ
parent ae17f4515a
commit 1beabc441a
4 changed files with 6 additions and 7 deletions

5
ash/ash_strings.grd

@ -6970,13 +6970,12 @@ To shut down the device, press and hold the power button on the device again.
Toolbar
</message>
<!-- TODO(b/286937607): Finalize and translate these strings -->
<!-- Input device settings notifications -->
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_ALT_RIGHT_CLICK" desc="The message shown to notify a user that the shortcut used to simulate a right-click using touchpad and keyboard has changed.">
The right-click shortcut is updated to <ph name="LAUNCHER_KEY_NAME">$1<ex>Launcher</ex></ph> key + click from Alt + click
The right-click shortcut is updated to <ph name="LAUNCHER_KEY_NAME">$1<ex>launcher</ex></ph> key + click from alt + click
</message>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_LAUNCHER_RIGHT_CLICK" desc="The message shown to notify a user that the shortcut used to simulate a right-click using touchpad and keyboard has changed.">
The right-click shortcut is updated to Alt + click from <ph name="LAUNCHER_KEY_NAME">$1<ex>Launcher</ex></ph> key + click
The right-click shortcut is updated to alt + click from <ph name="LAUNCHER_KEY_NAME">$1<ex>launcher</ex></ph> key + click
</message>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_RIGHT_CLICK_DISABLED" desc="The message shown to notify a user that the shortcut used to simulate a right-click using touchpad and keyboard is disabled.">
The right-click shortcut is currently off

2
ash/ash_strings_grd/IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_ALT_RIGHT_CLICK.png.sha1

@ -1 +1 @@
95a29ddd8ba83c9969e7f2b27698c9d1b9bac09d
8812eca875cd3de05fb8b45c6dff9e2b594ea1fd

2
ash/ash_strings_grd/IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_LAUNCHER_RIGHT_CLICK.png.sha1

@ -1 +1 @@
95a29ddd8ba83c9969e7f2b27698c9d1b9bac09d
8812eca875cd3de05fb8b45c6dff9e2b594ea1fd

4
ash/system/input_device_settings/input_device_settings_notification_controller.cc

@ -114,8 +114,8 @@ std::u16string GetRightClickRewriteNotificationMessage(
const int launcher_key_name_id =
Shell::Get()->keyboard_capability()->HasLauncherButtonOnAnyKeyboard()
? IDS_ASH_SHORTCUT_MODIFIER_LAUNCHER
: IDS_ASH_SHORTCUT_MODIFIER_SEARCH;
? IDS_ASH_SETTINGS_SHORTCUT_MODIFIER_LAUNCHER
: IDS_ASH_SETTINGS_SHORTCUT_MODIFIER_SEARCH;
const std::u16string launcher_key_name =
l10n_util::GetStringUTF16(launcher_key_name_id);