Add two feature flags for PDF save.
Add flags for PDF WebUI to get save data from renderer in blocks and use in-memory bytes to save a PDF to disk instead of redownloading it. Bug: 394111292,40293042 Change-Id: I2320453aee0bd15243da1f92734e71eef43bfe3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6263346 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/main@{#1420302}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
f1a0a6d2a3
commit
1d09f0e684
@ -263,6 +263,9 @@ void AddAdditionalData(bool enable_printing,
|
||||
#endif // BUILDFLAG(ENABLE_PDF_INK2)
|
||||
dict->Set("printingEnabled", printing_enabled);
|
||||
dict->Set("pdfAnnotationsEnabled", annotations_enabled);
|
||||
dict->Set("PdfGetSaveDataInBlocks",
|
||||
base::FeatureList::IsEnabled(
|
||||
chrome_pdf::features::kPdfGetSaveDataInBlocks));
|
||||
dict->Set("pdfUseShowSaveFilePicker",
|
||||
base::FeatureList::IsEnabled(
|
||||
chrome_pdf::features::kPdfUseShowSaveFilePicker));
|
||||
|
@ -35,6 +35,17 @@ BASE_FEATURE(kPdfPartialLoading,
|
||||
|
||||
BASE_FEATURE(kPdfPortfolio, "PdfPortfolio", base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
// Enables PDF WebUI save to get PDF content from renderer in blocks.
|
||||
BASE_FEATURE(kPdfGetSaveDataInBlocks,
|
||||
"PdfGetSaveDataInBlocks",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
// Saves original PDFs to disk from the in-memory copy instead of redownloading
|
||||
// them.
|
||||
BASE_FEATURE(kPdfSaveOriginalFromMemory,
|
||||
"PdfSaveOriginalFromMemory",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
BASE_FEATURE(kPdfSearchify, "PdfSearchify", base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
BASE_FEATURE(kPdfSearchifySave,
|
||||
|
@ -17,10 +17,12 @@ namespace chrome_pdf::features {
|
||||
|
||||
BASE_DECLARE_FEATURE(kAccessiblePDFForm);
|
||||
BASE_DECLARE_FEATURE(kPdfCr23);
|
||||
BASE_DECLARE_FEATURE(kPdfGetSaveDataInBlocks);
|
||||
BASE_DECLARE_FEATURE(kPdfIncrementalLoading);
|
||||
BASE_DECLARE_FEATURE(kPdfOopif);
|
||||
BASE_DECLARE_FEATURE(kPdfPartialLoading);
|
||||
BASE_DECLARE_FEATURE(kPdfPortfolio);
|
||||
BASE_DECLARE_FEATURE(kPdfSaveOriginalFromMemory);
|
||||
BASE_DECLARE_FEATURE(kPdfSearchify);
|
||||
BASE_DECLARE_FEATURE(kPdfSearchifySave);
|
||||
BASE_DECLARE_FEATURE(kPdfTags);
|
||||
|
Reference in New Issue
Block a user