0

[CrOS Hotspot] Update hotspot strings

Updates the hotspot related string according to UXW review. See details:
go/cros-hotspot-strings

Bug: b/269353926
Change-Id: I3af96f153cf48112089f2dab5bdff4469a3238df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4683738
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Jason Zhang <jiajunz@google.com>
Cr-Commit-Position: refs/heads/main@{#1170729}
This commit is contained in:
Jason Zhang
2023-07-14 21:57:01 +00:00
committed by Chromium LUCI CQ
parent 1edffe9b22
commit 1f6e7f8ef5
11 changed files with 25 additions and 25 deletions

@ -2724,19 +2724,19 @@ Turning on battery saver to increase your battery life.
Off
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_STATUS_ENABLING" desc="The sublabel for hotspot feature pod in quick settings to show hotspot is enabling.">
Enabling...
Turning on...
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_STATUS_DISABLING" desc="The sublabel for hotspot feature pod in quick settings to show hotspot is disabling.">
Disabling...
Turning off...
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_DRILL_IN_TOOLTIP_STATUS_ON" desc="The tooltip for the drill in button in hotspot feature tile of quick settings when hotspot is on.">
Show hotspot details. Hotspot is on.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_ENABLING" desc="The tooltip for the hotspot feature tile of quick settings when hotspot is enabling.">
Show hotspot details. Hotspot is enabling.
Show hotspot details. Hotspot is turning on.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_DISABLING" desc="The tooltip for the hotspot feature tile of quick settings when hotspot is disabling.">
Show hotspot details. Hotspot is disabling.
Show hotspot details. Hotspot is turning off.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_DRILL_IN_TOOLTIP_STATUS_OFF" desc="The tooltip for the drill in button in hotspot feature tile of quick settings when hotspot is off and is not allowed to turn on.">
Show hotspot details. Hotspot is off.
@ -2763,7 +2763,7 @@ Turning on battery saver to increase your battery life.
Show hotspot details. Hotspot is blocked by your administrator.
</message>
<message name="IDS_ASH_HOTSPOT_DETAILED_VIEW_SUBLABEL_NO_MOBILE_DATA" desc="The sublabel text in the hotspot detailed view when hotspot is off and not allowed to turn on due to no mobile network connection.">
Connect to mobile data to use hotspot
Connect to mobile data
</message>
<message name="IDS_ASH_HOTSPOT_DETAILED_VIEW_INFO_TOOLTIP_MOBILE_DATA_NOT_SUPPORTED" desc="The tooltip for the info icon in hotspot detailed view when hotspot is off and not allowed to turn on due to the connected mobile data doesn't support hotspot.">
Your mobile network doesn't support hotspot
@ -2787,13 +2787,13 @@ Turning on battery saver to increase your battery life.
"<ph name="NAME">$1<ex>Chromebook</ex></ph>" visible to Bluetooth devices.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_ON_MULTIPLE_CONNECTED_DEVICES" desc="Tooltip or accessiblity text for the hotspot icon in system tray when hotspot is turned on and multiple devices are connected.">
<ph name="DEVICECOUNT">$1</ph> devices connected to your <ph name="DEVICE_NAME">$2<ex>Chromebook</ex></ph> hotspot
<ph name="DEVICECOUNT">$1</ph> devices connected to <ph name="DEVICE_NAME">$2<ex>Chromebook</ex></ph> hotspot
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_ON_ONE_CONNECTED_DEVICE" desc="Tooltip or accessiblity text for the hotspot icon in system tray when hotspot is turned on and one device is connected.">
1 device connected to your <ph name="DEVICE_NAME">$1<ex>Chromebook</ex></ph> hotspot
1 device connected to <ph name="DEVICE_NAME">$1<ex>Chromebook</ex></ph> hotspot
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_ON_NO_CONNECTED_DEVICES" desc="Tooltip or accessiblity text for the hotspot icon in system tray when hotspot is turned on and no devices are connected.">
Your <ph name="DEVICE_NAME">$1<ex>Chromebook</ex></ph> hotspot is on, no devices connected
<ph name="DEVICE_NAME">$1<ex>Chromebook</ex></ph> hotspot is on, no devices connected
</message>
<message name="IDS_ASH_HOTSPOT_ON_TITLE" desc="Title used for the system notification shown when the hotspot is turned on.">
Hotspot is on

@ -1 +1 @@
a2ffa585697b62e6ba485351fadc9a9080499e2d
d3164995a665731bb3853aede459fd70153d5d5a

@ -1 +1 @@
dbe1d97dc41ad169a9e099ad49b4e7f5247fa292
274e8611258179c489ed1ce82169277bff8ee380

@ -1 +1 @@
2e5dfc85a9f4002669b2041b65140eea7271c3e5
3ab0ac5dda5bfe223b5a91a1b53a69724bcc1e56

@ -1 +1 @@
3c6e87b0d382c233ffdc39bf225b5f8cd098964c
63406e201c600661d046b1a4ac30cf9d2a9af358

@ -1 +1 @@
715c510681742a43d345ebdc39dfc27c7717aa8a
cd42db657367aa18f58212fbbd6410d02288e9cb

@ -1 +1 @@
03dc4cf6fe484d2539e231a7ae81af1b7c219b67
f41e8f1321dad6811754d7b62ee9816bae21c5c6

@ -1 +1 @@
2a7c4d18feedf1a0c2c5744da0ebcc4a4ae72647
274e8611258179c489ed1ce82169277bff8ee380

@ -1 +1 @@
4a653bbafadb77d633f8274f05b828bd2af9e503
3ab0ac5dda5bfe223b5a91a1b53a69724bcc1e56

@ -219,7 +219,7 @@ TEST_F(HotspotDetailedViewTest, HotspotEnablingUI) {
ASSERT_TRUE(hotspot_detailed_view_);
AssertTextLabel(kHotspotTitle);
AssertSubtextLabel(u"Enabling");
AssertSubtextLabel(u"Turning on");
AssertEntryRowEnabled(/*expected_enabled=*/false);
AssertToggleOn(/*expected_toggle_on=*/true);
views::ImageView* extra_icon = GetExtraIcon();
@ -245,7 +245,7 @@ TEST_F(HotspotDetailedViewTest, HotspotDisablingUI) {
ASSERT_TRUE(hotspot_detailed_view_);
AssertTextLabel(kHotspotTitle);
AssertSubtextLabel(u"Disabling");
AssertSubtextLabel(u"Turning off");
AssertEntryRowEnabled(/*expected_enabled=*/false);
AssertToggleOn(/*expected_toggle_on=*/false);
views::ImageView* extra_icon = GetExtraIcon();
@ -280,7 +280,7 @@ TEST_F(HotspotDetailedViewTest, HotspotDisabledAndNoMobileNetworkUI) {
ASSERT_TRUE(hotspot_detailed_view_);
AssertTextLabel(kHotspotTitle);
AssertSubtextLabel(u"Connect to mobile data to use hotspot");
AssertSubtextLabel(u"Connect to mobile data");
AssertEntryRowEnabled(/*expected_enabled=*/false);
AssertToggleOn(/*expected_toggle_on=*/false);
views::ImageView* extra_icon = GetExtraIcon();

@ -192,10 +192,10 @@ TEST_F(HotspotFeaturePodControllerTest, HotspotEnabling) {
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Enabling", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Hotspot is enabling.",
EXPECT_EQ(u"Turning on", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Hotspot is turning on.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is enabling.",
EXPECT_EQ(u"Show hotspot details. Hotspot is turning on.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_STREQ(kHotspotDotIcon.name, GetVectorIconName());
// Verifies the hotspot icon is animating when enabling.
@ -221,10 +221,10 @@ TEST_F(HotspotFeaturePodControllerTest, HotspotDisabling) {
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Disabling", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Hotspot is disabling.",
EXPECT_EQ(u"Turning off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Hotspot is turning off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is disabling.",
EXPECT_EQ(u"Show hotspot details. Hotspot is turning off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_STREQ(kHotspotOffIcon.name, GetVectorIconName());