0

[IOS][Omnibox] Prepare experimental flag for actions in suggest

Change-Id: I8c9192a5bc9690676667ef1f2f235641bc2c2348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474122
Auto-Submit: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Ameur Hosni <ameurhosni@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291924}
This commit is contained in:
Ameur Hosni
2024-04-24 16:36:02 +00:00
committed by Chromium LUCI CQ
parent 60972bb96d
commit 20b75fe5b9
5 changed files with 19 additions and 0 deletions

@ -1592,6 +1592,10 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAutofillEnableVerveCardSupportDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(autofill::features::kAutofillEnableVerveCardSupport)},
{"omnibox-actions-in-suggest",
flag_descriptions::kOmniboxActionsInSuggestName,
flag_descriptions::kOmniboxActionsInSuggestDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kOmniboxActionsInSuggest)},
};
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {

@ -716,6 +716,10 @@ const char kNTPViewHierarchyRepairName[] = "NTP View Hierarchy Repair";
const char kNTPViewHierarchyRepairDescription[] =
"Checks if NTP view hierarchy is broken and fixes it if necessary.";
const char kOmniboxActionsInSuggestName[] = "Omnibox actions in suggest";
const char kOmniboxActionsInSuggestDescription[] =
"Enables actions in suggest for IOS";
const char kOmniboxCompanyEntityIconAdjustmentName[] =
"Omnibox Company Entity Icon Adjustment";
const char kOmniboxCompanyEntityIconAdjustmentDescription[] =

@ -639,6 +639,10 @@ extern const char kOverflowMenuCustomizationDescription[];
extern const char kNTPViewHierarchyRepairName[];
extern const char kNTPViewHierarchyRepairDescription[];
// Title and description for the flag to enable actions in suggest.
extern const char kOmniboxActionsInSuggestName[];
extern const char kOmniboxActionsInSuggestDescription[];
// Title and description for the flag to possibly remove company entity images.
extern const char kOmniboxCompanyEntityIconAdjustmentName[];
extern const char kOmniboxCompanyEntityIconAdjustmentDescription[];

@ -32,6 +32,10 @@ BASE_FEATURE(kOmniboxPopupRowContentConfiguration,
"OmniboxPopupRowContentConfiguration",
base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kOmniboxActionsInSuggest,
"OmniboxIOSActionsInSuggest",
base::FEATURE_DISABLED_BY_DEFAULT);
bool IsIpadPopoutOmniboxEnabled() {
return base::FeatureList::IsEnabled(kEnablePopoutOmniboxIpad) &&
ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_TABLET;

@ -31,6 +31,9 @@ BASE_DECLARE_FEATURE(kOmniboxLockIconEnabled);
// Feature flag to enable the use of content configuration for the popup rows.
BASE_DECLARE_FEATURE(kOmniboxPopupRowContentConfiguration);
// Feature flag to enable actions in suggest.
BASE_DECLARE_FEATURE(kOmniboxActionsInSuggest);
// Type of rich autocompletion implementation.
enum class RichAutocompletionImplementation {
// kRichAutocompletionParamLabel.