chromium/src
0
Fork 0
Code Activity

Revert of Revert of Isolate courgette_unittests (patchset id:1 of https://codereview.chromium.org/865133002/)

Browse Source 
Reason for revert:
The revert might have been wrong: reverting the revert again.
BUG=450912

Original issue's description:
> Revert of Isolate courgette_unittests (patchset  id:1 of https://codereview.chromium.org/868433002/)
>
> Reason for revert:
> http://crbug.com/450912
>
> courget_unittests is failing on Win7(dbg) bots since build#34639.
> http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34639
>
> Original issue's description:
> > Isolate courgette_unittests
> >
> > Adding link to http://www.chromium.org/developers/testing/isolated-testing/for-swes for my future self.
> >
> > R=maruel@chromium.org,jochen@chromium.org
> > TBR=jam@chromium.org
> > BUG=98637
> >
> > Committed: https://crrev.com/c9bd3b9a5667a36c05592ec9d16533be91b4567c
> > Cr-Commit-Position: refs/heads/master@{#312531}
>
> TBR=jam@chromium.org,jochen@chromium.org,maruel@chromium.org,scottmg@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=98637
>
> Committed: https://crrev.com/1bdeeeb5eae42e95f82806da9351d77a05403e67
> Cr-Commit-Position: refs/heads/master@{#312571}

TBR=jam@chromium.org,jochen@chromium.org,maruel@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637

Review URL: https://codereview.chromium.org/867523002

Cr-Commit-Position: refs/heads/master@{#312577}
This commit is contained in:
kochi
2015-01-21 23:20:19 -08:00
committed by Commit bot
parent 88c7b3339b
commit 217c53ca81
5 changed files with 110 additions and 13 deletions

17
courgette/courgette.gyp

@ -213,5 +213,22 @@
},
],
}],
['test_isolation_mode != "noop"', {
'targets': [
{
'target_name': 'courgette_unittests_run',
'type': 'none',
'dependencies': [
'courgette_unittests',
],
'includes': [
'../build/isolate.gypi',
],
'sources': [
'courgette_unittests.isolate',
],
},
],
}],
],
}

14
courgette/courgette_unittests.isolate Normal file

@ -0,0 +1,14 @@
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'variables': {
'files': [
'<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
'testdata/',
],
'command': [
'<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
],
},
}

56
testing/buildbot/chromium.fyi.json

@ -366,7 +366,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",
@ -413,7 +418,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",
@ -460,7 +470,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",
@ -507,7 +522,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",
@ -554,7 +574,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",
@ -601,7 +626,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",
@ -648,7 +678,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",
@ -695,7 +730,12 @@
"cacheinvalidation_unittests",
"chrome_elf_unittests",
"components_unittests",
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"gcm_unit_tests",

35
testing/buildbot/chromium.win.json

@ -42,7 +42,12 @@
"can_use_on_swarming_builders": true
}
},
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"events_unittests",
"extensions_unittests",
@ -162,7 +167,12 @@
"can_use_on_swarming_builders": true
}
},
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"extensions_unittests",
"events_unittests",
@ -293,7 +303,12 @@
"can_use_on_swarming_builders": true
}
},
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"device_unittests",
"events_unittests",
@ -431,7 +446,12 @@
"can_use_on_swarming_builders": true
}
},
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"device_unittests",
"events_unittests",
@ -567,7 +587,12 @@
"can_use_on_swarming_builders": true
}
},
"courgette_unittests",
{
"test": "courgette_unittests",
"swarming": {
"can_use_on_swarming_builders": true
}
},
"crypto_unittests",
"events_unittests",
"extensions_unittests",

1
testing/buildbot/chromium_trybot.json

@ -79,6 +79,7 @@
},
{
"test": "courgette_unittests",
"can_use_on_swarming_builders": true,
"platforms": ["win"]
},
{